From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] tracing: Fix a compilation error without CONFIG_MODULES
Date: Tue, 18 Mar 2025 10:25:52 +0900 [thread overview]
Message-ID: <20250318102552.7c7400873fa3f304cbefa9b6@kernel.org> (raw)
In-Reply-To: <20250314054257.3218dc35@batman.local.home>
On Fri, 14 Mar 2025 05:42:57 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 14 Mar 2025 01:26:51 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > @@ -6040,9 +6042,10 @@ static void update_last_data(struct trace_array *tr)
> > memset(tscratch->entries, 0,
> > flex_array_size(tscratch, entries, tscratch->nr_entries));
> > tscratch->nr_entries = 0;
> > -
> > +#ifdef CONFIG_MODULES
> > guard(mutex)(&scratch_mutex);
> > module_for_each_mod(save_mod, tr);
> > +#endif
> > }
>
> Hmm, I think the real fix for this would be to make
> module_for_each_mod() a nop when modules are not configured.
Yeah, but in this case, save_mod() need to be removed too[*]. Or is it
better to make save_mod() a nop too?
[*] https://lore.kernel.org/oe-kbuild-all/202503142045.0sE1neLa-lkp@intel.com/
Thank you,
>
> -- Steve
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-03-18 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 16:26 [PATCH v4 0/2] tracing: Show last boot module symbols Masami Hiramatsu (Google)
2025-03-13 16:26 ` [PATCH v4 1/2] tracing: Fix a compilation error without CONFIG_MODULES Masami Hiramatsu (Google)
2025-03-14 9:42 ` Steven Rostedt
2025-03-18 1:25 ` Masami Hiramatsu [this message]
2025-03-13 16:26 ` [PATCH v4 2/2] tracing: Show last module text symbols in the stacktrace Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318102552.7c7400873fa3f304cbefa9b6@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox