From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E5C1EB9E3 for ; Thu, 20 Mar 2025 09:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742461359; cv=none; b=OHA2n2UfnHgrMnaCzyqQpvxyBz/wX1LzMa+85eQ+o5//8AfdB6kq0aaMt3b46Wt0dJYRPxFTO4p/5gKeMz7ihavVWe1y1+6e+HJouiJoFt5lC72QCw3Vj7rS2fQ1upqRgDZc4bfJFIo7aGjx3/WjN+UXzaFBUDiRFdh1UJJDDr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742461359; c=relaxed/simple; bh=pGrzZsD7jQD4q+HpXNfMs+ajcvDEH8ArFztx4QnT5O4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pK9KcFc01NXcTSXjrULjY1yJrPTWXTycAHJcJs1z2QDROgzapYNETELsBp3o9PA9WHmVJ5oG0b0aiOTwPjf13ehOrvuS/Cc+V3dqWmvHJ4EcaJMWhYXCwvF0L1SCf5XbtmGIw13pHWUqcU0WNBz0oeol5YlVwu+3YDV9I54B5GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=If9Q4JJk; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="If9Q4JJk" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso5395455e9.3 for ; Thu, 20 Mar 2025 02:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1742461356; x=1743066156; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=72uAcvX5/rJRkialBraZlcCWh3cO7qq403Dc9iTXm5o=; b=If9Q4JJkjEBVVzG0hxA/8zqxT9dhbAx2BRcb1XkAOFsU3ReicbKkGFVENv4A0S2TXH x8WyT34JHFfUtINwfWNgZZvuKcNRC/poA/bG6ic66qtu9Xmp0ycGJRs19M9gbtFbDZ86 dXQ/Z6UECNg2a95YzwMq7a1twsp9BFIeJLCwdjO6cnmCDd/nGsiSZBqO+ipWu50AlQwV 4GIyMd8HqWPxqGadMVZicadBvkiAKu3srh6xXkk3sBSYXpBYqvJor+0ibHzOySECrDCk uyu9V5GkVSoy2JBHH2oV/RIIYaK50yIS1pU+Cuz72idYNVZFN4sepxnRoLdiGQuVXJtr F3Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742461356; x=1743066156; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=72uAcvX5/rJRkialBraZlcCWh3cO7qq403Dc9iTXm5o=; b=WLWhdwjRmX9lvDErDYR9LvaKx6YsgLl837pEhCIO6qb7LdPnU7M/CCBcW1wsNhppPh 5mbR7f8Xt7pqos9gV43bMn8bFNvcBJ0twqiUmp2nQuy9bSywRZhsjF99UPFS78KIXTMl XQNuasL5PvhaJUNt6LNfpchEcOzp30nQGx814r8ITAv6n62YixKcgjQb7aKnEpNQWIua 7FOe3NFUVCrvCRkJ2q07cI6rIaR2QGkq9Y9nkyEMMARakdHmDe7K2u0ltKgbNuEyrJ7n FbJ/wxsJcJRrpbS77V4t0/OVBoMRwPZVgFYmokrEL6WXuo5TBSUFnLObWSY7bb3akouE 2UWA== X-Forwarded-Encrypted: i=1; AJvYcCXfONnpfVm0AcKenn01UkCAMsAyosffGZP5mZR+O4ED2+StiffD/iuPd3eP6ifD69SC73YXqYS1KwV5xoobPoB9ixg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0RNz0/Tl9b5j2Ft2IxjvAsdqxI8lCfd8u3ADsbcYiF0INIbSB rVA/EtdM2x+IKhoHobUWf81A6yEGhmj4YsQ3Xc3CfmlbgmC+zZ+LLxFUX55YrK0= X-Gm-Gg: ASbGnctzFlTANfKGnbPfEsleIs5m+5Jzn/bVU7vBnzm04RM2OCbjtMNoG3DOqr7S4D5 7IuXmOxsDVqlWiSLTM4wU8T3OIy145WkCTP8HBVrOX41+JN5dx5DOXaK7boJASpLAiOTXca8rk1 7a77VmE/JZQOK4v9CYfDZsIMSUysaRdJC2xtZovFiiHsJ8e8ky+YrP/GBTisCb98UyhKBhyZM7i O7K4CcRwn6Mqx9UZ6S/Yx2lucKUuSc+mAELwIaUfoxg2m/MmL7Y8ATcukz/uEffCBn2fYRJArW+ /wLCR5dUkMwjko9nxUDreNJcQlCq4qKF X-Google-Smtp-Source: AGHT+IGEgBOjhueRBJQDOOD+YjPfNJuNtGPXMADUyLrPBgDpdIBjVWb7iZ7LsyjAfh/7UNsZ+oLmUA== X-Received: by 2002:a05:6000:1565:b0:391:122c:8b2 with SMTP id ffacd0b85a97d-399795ae3a9mr2247824f8f.31.1742461355604; Thu, 20 Mar 2025 02:02:35 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::59a5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df413esm22708633f8f.20.2025.03.20.02.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 02:02:34 -0700 (PDT) Date: Thu, 20 Mar 2025 10:02:33 +0100 From: Andrew Jones To: Charlie Jenkins Cc: Paul Walmsley , Palmer Dabbelt , Ard Biesheuvel , Ben Dooks , Pasha Bouzarjomehri , Emil Renner Berthing , Alexandre Ghiti , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Albert Ou , Peter Zijlstra , Josh Poimboeuf , Jason Baron , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v10 1/2] riscv: Move nop definition to insn-def.h Message-ID: <20250320-25d2b6edb008a666151b786f@orel> References: <20250319-runtime_const_riscv-v10-0-745b31a11d65@rivosinc.com> <20250319-runtime_const_riscv-v10-1-745b31a11d65@rivosinc.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319-runtime_const_riscv-v10-1-745b31a11d65@rivosinc.com> On Wed, Mar 19, 2025 at 11:35:19AM -0700, Charlie Jenkins wrote: > We have duplicated the definition of the nop instruction in ftrace.h and > in jump_label.c. Move this definition into the generic file insn-def.h > so that they can share the definition with each other and with future > files. > > Signed-off-by: Charlie Jenkins > Reviewed-by: Alexandre Ghiti > Tested-by: Alexandre Ghiti > --- > arch/riscv/include/asm/ftrace.h | 1 - > arch/riscv/include/asm/insn-def.h | 3 +++ > arch/riscv/kernel/ftrace.c | 6 +++--- > arch/riscv/kernel/jump_label.c | 4 ++-- > 4 files changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Andrew Jones