From: Steven Rostedt <rostedt@goodmis.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sahil Gupta <s.gupta@arista.com>,
stable@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Dmitry Safonov <dima@arista.com>,
Kevin Mitchell <kevmitch@arista.com>
Subject: Re: [PATCH 6.1 6.6 6.12 6.13] scripts/sorttable: fix ELF64 mcount_loc address parsing when compiling on 32-bit
Date: Tue, 25 Mar 2025 20:47:31 -0400 [thread overview]
Message-ID: <20250325204731.24f26003@batman.local.home> (raw)
In-Reply-To: <2025032554-compile-unlivable-0fb4@gregkh>
On Tue, 25 Mar 2025 20:45:00 -0400
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 25, 2025 at 08:37:23PM -0400, Steven Rostedt wrote:
> > On Tue, 25 Mar 2025 20:32:36 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > I guess it is loosely based on 4acda8edefa1 ("scripts/sorttable: Get
> > > start/stop_mcount_loc from ELF file directly"), which may take a bit of
> > > work to backport (or we just add everything that this commit depends on).
> >
> > And looking at what was done, it was my rewrite of the sorttable.c code.
> >
> > If it's OK to backport a rewrite, then we could just do that.
> >
> > See commits:
> >
> > 4f48a28b37d5 scripts/sorttable: Remove unused write functions
> > 7ffc0d0819f4 scripts/sorttable: Make compare_extable() into two functions
> > 157fb5b3cfd2 scripts/sorttable: Convert Elf_Ehdr to union
> > 545f6cf8f4c9 scripts/sorttable: Replace Elf_Shdr Macro with a union
> > 200d015e73b4 scripts/sorttable: Convert Elf_Sym MACRO over to a union
> > 1dfb59a228dd scripts/sorttable: Add helper functions for Elf_Ehdr
> > 67afb7f50440 scripts/sorttable: Add helper functions for Elf_Shdr
> > 17bed33ac12f scripts/sorttable: Add helper functions for Elf_Sym
> > 58d87678a0f4 scripts/sorttable: Move code from sorttable.h into sorttable.c
>
> Backport away!
Actually, I only did a git log on scripts/sorttable.c. I left out
sorttable.h which gives me this list:
$ git log --pretty=oneline --abbrev-commit --reverse v6.12..4acda8edefa1ce66d3de845f1c12745721cd14c3 scripts/sorttable.[ch]
0210d251162f scripts/sorttable: fix orc_sort_cmp() to maintain symmetry and transitivity
28b24394c6e9 scripts/sorttable: Remove unused macro defines
4f48a28b37d5 scripts/sorttable: Remove unused write functions
6f2c2f93a190 scripts/sorttable: Remove unneeded Elf_Rel
66990c003306 scripts/sorttable: Have the ORC code use the _r() functions to read
7ffc0d0819f4 scripts/sorttable: Make compare_extable() into two functions
157fb5b3cfd2 scripts/sorttable: Convert Elf_Ehdr to union
545f6cf8f4c9 scripts/sorttable: Replace Elf_Shdr Macro with a union
200d015e73b4 scripts/sorttable: Convert Elf_Sym MACRO over to a union
1dfb59a228dd scripts/sorttable: Add helper functions for Elf_Ehdr
67afb7f50440 scripts/sorttable: Add helper functions for Elf_Shdr
17bed33ac12f scripts/sorttable: Add helper functions for Elf_Sym
1b649e6ab8dc scripts/sorttable: Use uint64_t for mcount sorting
58d87678a0f4 scripts/sorttable: Move code from sorttable.h into sorttable.c
4acda8edefa1 scripts/sorttable: Get start/stop_mcount_loc from ELF file directly
-- Steve
next prev parent reply other threads:[~2025-03-26 0:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABEuK15=+Bo7xkBn5ufytVowt0j3fVEsdGVsryn1zH8KxfoCyQ@mail.gmail.com>
2025-03-24 17:36 ` ftrace: sorttable unable to sort ELF64 on 32-bit host Steven Rostedt
2025-03-24 18:39 ` Sahil Gupta
2025-03-24 18:52 ` Greg KH
2025-03-24 19:07 ` Steven Rostedt
2025-03-25 11:58 ` Greg KH
2025-03-25 12:15 ` Steven Rostedt
2025-03-25 17:52 ` Sahil Gupta
2025-03-25 18:02 ` Steven Rostedt
2025-03-25 18:10 ` Sahil Gupta
2025-03-25 18:19 ` Steven Rostedt
2025-03-25 18:23 ` Sahil Gupta
2025-03-26 0:06 ` [PATCH 6.1 6.6 6.12 6.13] scripts/sorttable: fix ELF64 mcount_loc address parsing when compiling on 32-bit Sahil Gupta
2025-03-26 0:23 ` Greg KH
2025-03-26 0:32 ` Steven Rostedt
2025-03-26 0:37 ` Steven Rostedt
2025-03-26 0:45 ` Greg KH
2025-03-26 0:47 ` Steven Rostedt [this message]
2025-03-26 1:07 ` Sahil Gupta
2025-05-03 10:24 ` Sahil Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325204731.24f26003@batman.local.home \
--to=rostedt@goodmis.org \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=kevmitch@arista.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=s.gupta@arista.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).