From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EBF01EEA2C; Thu, 3 Apr 2025 19:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707709; cv=none; b=sqd8JQSXlJnPnZIk+a5a3SyYqUvC0nwvm3A+ZWg9CWnh8FcdhDkbcY1M5hhsaq37CDUhm9c7B33TNa17YY3gPIr4aRspJR19RXSwUw/yt1WUyudMEuxl4pw3a6Y34lgquqIvut3/s12KQ4kZ3Djs86LOfBnKM3T6jY04LAq5zxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707709; c=relaxed/simple; bh=r+jGbRe1qTe8mUrlj+W7WsE9TH+Jz+fpGST/vO7nmD4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CiRTdw4NmI6NQGWjko6lrDoZ5+KF25VM6DMs7ji5+pkcrb6vuPhGXolEAAhHnn4Bc7jCI5WPHil5BmzQ2zq62HnJBXxPZ+l3w+EtbXOzb3+IOg0SKnDB1v1YIKGJvA4a2619bq4E8ZkW+dNmUYyfx6Jk4AVzG85kxG1rAdHoDko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FqCmGQEK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FqCmGQEK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A8B7C4CEEB; Thu, 3 Apr 2025 19:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707709; bh=r+jGbRe1qTe8mUrlj+W7WsE9TH+Jz+fpGST/vO7nmD4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FqCmGQEKYX9+FiNNvDnDGagtQHTx0NWstKhNhe0toXdZ1jGXhvHeD5h5HIKiPA0ml ClVZk6qe8my7LlScFhsEtKENrq4go2Y8rfqD+GChxjfHvMi2LH3iKhJVN0+HMZAiQN EwJdWF1wVZwKws7K67lslMQaTjnTeVKorz2+KooEp4l5UIr741xZ3beBn2Ex9cgosx X4nUWXitkF95h6hbwqXn+d4qlaoceZygDPaGfEWX4EbZTQsAOfFbG3VjVyHmUq77+c UQztI7REm3hTvpwJx8o4yG9rcrcFosaqJ2LxuoqgtgJb312A0VsClHbaddtWClhepQ rzql+7kxy1dYA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Masami Hiramatsu (Google)" , Steven Rostedt , Sasha Levin , linux-trace-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 41/44] tracing: probe-events: Add comments about entry data storing code Date: Thu, 3 Apr 2025 15:13:10 -0400 Message-Id: <20250403191313.2679091-41-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403191313.2679091-1-sashal@kernel.org> References: <20250403191313.2679091-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14 Content-Transfer-Encoding: 8bit From: "Masami Hiramatsu (Google)" [ Upstream commit bb9c6020f4c3a07a90dc36826cb5fbe83f09efd5 ] Add comments about entry data storing code to __store_entry_arg() and traceprobe_get_entry_data_size(). These are a bit complicated because of building the entry data storing code and scanning it. This just add comments, no behavior change. Link: https://lore.kernel.org/all/174061715004.501424.333819546601401102.stgit@devnote2/ Reported-by: Steven Rostedt Closes: https://lore.kernel.org/all/20250226102223.586d7119@gandalf.local.home/ Reviewed-by: Steven Rostedt (Google) Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Sasha Levin --- kernel/trace/trace_probe.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 8f58ee1e8858a..2eeecb6c95eea 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -770,6 +770,10 @@ static int check_prepare_btf_string_fetch(char *typename, #ifdef CONFIG_HAVE_FUNCTION_ARG_ACCESS_API +/* + * Add the entry code to store the 'argnum'th parameter and return the offset + * in the entry data buffer where the data will be stored. + */ static int __store_entry_arg(struct trace_probe *tp, int argnum) { struct probe_entry_arg *earg = tp->entry_arg; @@ -793,6 +797,20 @@ static int __store_entry_arg(struct trace_probe *tp, int argnum) tp->entry_arg = earg; } + /* + * The entry code array is repeating the pair of + * [FETCH_OP_ARG(argnum)][FETCH_OP_ST_EDATA(offset of entry data buffer)] + * and the rest of entries are filled with [FETCH_OP_END]. + * + * To reduce the redundant function parameter fetching, we scan the entry + * code array to find the FETCH_OP_ARG which already fetches the 'argnum' + * parameter. If it doesn't match, update 'offset' to find the last + * offset. + * If we find the FETCH_OP_END without matching FETCH_OP_ARG entry, we + * will save the entry with FETCH_OP_ARG and FETCH_OP_ST_EDATA, and + * return data offset so that caller can find the data offset in the entry + * data buffer. + */ offset = 0; for (i = 0; i < earg->size - 1; i++) { switch (earg->code[i].op) { @@ -826,6 +844,16 @@ int traceprobe_get_entry_data_size(struct trace_probe *tp) if (!earg) return 0; + /* + * earg->code[] array has an operation sequence which is run in + * the entry handler. + * The sequence stopped by FETCH_OP_END and each data stored in + * the entry data buffer by FETCH_OP_ST_EDATA. The FETCH_OP_ST_EDATA + * stores the data at the data buffer + its offset, and all data are + * "unsigned long" size. The offset must be increased when a data is + * stored. Thus we need to find the last FETCH_OP_ST_EDATA in the + * code array. + */ for (i = 0; i < earg->size; i++) { switch (earg->code[i].op) { case FETCH_OP_END: -- 2.39.5