From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10B1C230D35; Fri, 11 Apr 2025 17:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744392745; cv=none; b=emywwYRt9vVYoJGXmHFD55MrZB1gx2TljuePJ0/DbyC6s8fBbrBlzygRGi6bA1cv0ldTCVbfhzB7RwhSBgA/oje/A56s2EIXiEiOa8ALtxYBHjHWU43mqCXsUMDk+zdE60lJU8fzja5ANaOSWJgRPlMK0UKSkdb7zgiaAD69kF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744392745; c=relaxed/simple; bh=8UJVOTaqMOUXwqVG2cSezf+/NN8n6SPcvSZu3a0lZzY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ArF3Ac36xdXeyOMgR98YpscvaBefmTJL/pJ8NJI/8q922Z21DAPfOyR7LwnPFxALFhpaVLslSAJjyCTQjftAyd18gyRVrj00aiX5N83GFuN/EZBHdCafI4XvqgSxkykFXt1NhUYYhVAEDx6IW7b8o730lU07jr+acpEkAkwE7kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B68DAC4CEE2; Fri, 11 Apr 2025 17:32:22 +0000 (UTC) Date: Fri, 11 Apr 2025 13:33:47 -0400 From: Steven Rostedt To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Sven Schnelle , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Donglin Peng , Zheng Yejian , Aishwarya.TCV@arm.com Subject: Re: [PATCH v4 2/4] ftrace: Add support for function argument to graph tracer Message-ID: <20250411133347.014986f9@gandalf.local.home> In-Reply-To: <20250411130200.76b52a61@gandalf.local.home> References: <20250227185804.639525399@goodmis.org> <20250227185822.810321199@goodmis.org> <20250410131745.04c126eb@gandalf.local.home> <20250411124552.36564a07@gandalf.local.home> <20250411124849.30d612ed@gandalf.local.home> <20250411130200.76b52a61@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Apr 2025 13:02:00 -0400 Steven Rostedt wrote: > diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c > index 2f077d4158e5..718f6e84cc83 100644 > --- a/kernel/trace/trace_functions_graph.c > +++ b/kernel/trace/trace_functions_graph.c > @@ -971,11 +971,10 @@ print_graph_entry_leaf(struct trace_iterator *iter, > > if (args_size >= FTRACE_REGS_MAX_ARGS * sizeof(long)) { > print_function_args(s, entry->args, ret_func); > - trace_seq_putc(s, ';'); > + trace_seq_puts(s, ";\n"); > } else > - trace_seq_puts(s, "();"); > + trace_seq_puts(s, "();\n"); > } > - trace_seq_printf(s, "\n"); > > print_graph_irq(iter, graph_ret->func, TRACE_GRAPH_RET, > cpu, iter->ent->pid, flags); I changed the patch to have print_graph_retval() simply not add a newline, and instead just have the caller always print the newline. I should have never let that function do that. But when it was added, there wasn't as many options, so it didn't look so bad, so I didn't ask for that to be changed. -- Steve