* [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event
@ 2025-04-16 17:06 Breno Leitao
2025-04-16 19:35 ` Kuniyuki Iwashima
2025-04-18 2:51 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Breno Leitao @ 2025-04-16 17:06 UTC (permalink / raw)
To: Eric Dumazet, Neal Cardwell, Kuniyuki Iwashima, Steven Rostedt,
Masami Hiramatsu, Mathieu Desnoyers, pabeni, andrew+netdev, kuba,
davem
Cc: netdev, linux-kernel, linux-trace-kernel, kernel-team,
Breno Leitao
Change the tcp_probe tracepoint to accept a const struct sk_buff
parameter instead of a non-const one. This improves type safety and
better reflects that the skb is not modified within the tracepoint
implementation.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
Sending this for net-next to avoid bringing this to stable tree, which
would make backport harder for not a big benefit.
---
include/trace/events/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 75d3d53a3832c..53e878fa14d14 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -293,7 +293,7 @@ DECLARE_TRACE(tcp_cwnd_reduction_tp,
TRACE_EVENT(tcp_probe,
- TP_PROTO(struct sock *sk, struct sk_buff *skb),
+ TP_PROTO(struct sock *sk, const struct sk_buff *skb),
TP_ARGS(sk, skb),
---
base-commit: 40ad72f88a65814ffeb1ab362074c6f8c4dc3f61
change-id: 20250416-tcp_probe-004337dc78a5
Best regards,
--
Breno Leitao <leitao@debian.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event
2025-04-16 17:06 [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event Breno Leitao
@ 2025-04-16 19:35 ` Kuniyuki Iwashima
2025-04-18 2:51 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Kuniyuki Iwashima @ 2025-04-16 19:35 UTC (permalink / raw)
To: leitao
Cc: andrew+netdev, davem, edumazet, kernel-team, kuba, kuniyu,
linux-kernel, linux-trace-kernel, mathieu.desnoyers, mhiramat,
ncardwell, netdev, pabeni, rostedt
From: Breno Leitao <leitao@debian.org>
Date: Wed, 16 Apr 2025 10:06:12 -0700
> Change the tcp_probe tracepoint to accept a const struct sk_buff
> parameter instead of a non-const one. This improves type safety and
> better reflects that the skb is not modified within the tracepoint
> implementation.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event
2025-04-16 17:06 [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event Breno Leitao
2025-04-16 19:35 ` Kuniyuki Iwashima
@ 2025-04-18 2:51 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-18 2:51 UTC (permalink / raw)
To: Breno Leitao
Cc: edumazet, ncardwell, kuniyu, rostedt, mhiramat, mathieu.desnoyers,
pabeni, andrew+netdev, kuba, davem, netdev, linux-kernel,
linux-trace-kernel, kernel-team
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Apr 2025 10:06:12 -0700 you wrote:
> Change the tcp_probe tracepoint to accept a const struct sk_buff
> parameter instead of a non-const one. This improves type safety and
> better reflects that the skb is not modified within the tracepoint
> implementation.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
>
> [...]
Here is the summary with links:
- [net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event
https://git.kernel.org/netdev/net-next/c/1df4a945444f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-18 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 17:06 [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event Breno Leitao
2025-04-16 19:35 ` Kuniyuki Iwashima
2025-04-18 2:51 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).