From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Subject: Re: [PATCH] tracing: Fix filter string testing
Date: Thu, 17 Apr 2025 16:29:27 -0700 [thread overview]
Message-ID: <20250417162927.e1117ce02e612e29a34985ef@linux-foundation.org> (raw)
In-Reply-To: <20250417183003.505835fb@gandalf.local.home>
On Thu, 17 Apr 2025 18:30:03 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> The filter string testing uses strncpy_from_kernel/user_nofault() to
> retrieve the string to test the filter against. The if() statement was
> incorrect as it considered 0 as a fault, when it is only negative that it
> faulted.
changelog forgot to describe the userspace-visible effects of the bug?
> Cc: stable@vger.kernel.org
Which is more important when proposing this!
next prev parent reply other threads:[~2025-04-17 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 22:30 [PATCH] tracing: Fix filter string testing Steven Rostedt
2025-04-17 23:29 ` Andrew Morton [this message]
2025-04-18 0:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417162927.e1117ce02e612e29a34985ef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrii.nakryiko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mykyta.yatsenko5@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).