Linux Trace Kernel
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Junxuan Liao <ljx@cs.wisc.edu>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] x86/tracing: introduce enter/exit tracepoint pairs for page faults
Date: Fri, 18 Apr 2025 23:39:45 +0200	[thread overview]
Message-ID: <20250418213945.GJaALGod4-j86Squ43@fat_crate.local> (raw)
In-Reply-To: <20250416140115.5b836b33@gandalf.local.home>

On Wed, Apr 16, 2025 at 02:01:15PM -0400, Steven Rostedt wrote:
> The above was created by:
> 
>  # trace-cmd sqlhist -e -n user_faults SELECT TIMESTAMP_DELTA_USECS as delta FROM page_fault_user_enter as start JOIN \
>      page_fault_user_exit as end ON start.common_pid = end.common_pid

Pfff, that's SQL.

You're too old fashioned - you need an AI thing now :-P

So tell me: I as a silly user, how do I figure out how to use trace-cmd?
I guess it has docs somewhere...

And apparently I need trace-cmd now - I can't type all that into sysfs... Or
I guess I can use trace-cmd to generate the commands and then I can echo them
into the target machine.

I.e., ftrace still doesn't need a special tool to be used...

> This was just a simple example. I rather see where in the kernel it happens.
> I can still use the synthetic events and user stack trace to find where the
> big faults occur.

Right, so it would be great to have the actual use case in a patch's commit
message... i.e., why is a patch important.

> > Now if only that info were in the commit message along with the usage scenario
> > so that people can *actually* do what you guys are bragging about...
> 
> I plan on adding things like this to Documentation/trace/debugging.rst
> 
> I need to get time out to add a bunch of helpful tricks there.

Yap, please.

I have to admit I was able to catch a trace for tglx using only the ftrace
documentation we have so it must be good. But moar is better. :-P

Thx man!

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

      parent reply	other threads:[~2025-04-18 21:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 20:35 [PATCH] x86/tracing: introduce enter/exit tracepoint pairs for page faults Junxuan Liao
2025-04-14 20:42 ` Dave Hansen
2025-04-14 20:57   ` Steven Rostedt
2025-04-14 23:14   ` Junxuan Liao
2025-04-14 23:22     ` Junxuan Liao
2025-04-14 23:37       ` Dave Hansen
2025-04-14 23:43         ` Steven Rostedt
2025-04-14 23:48           ` Junxuan Liao
2025-04-14 20:54 ` Borislav Petkov
2025-04-14 22:20   ` Steven Rostedt
2025-04-15  1:23     ` Junxuan Liao
2025-04-16 17:47     ` Borislav Petkov
2025-04-16 18:01       ` Steven Rostedt
2025-04-16 18:06         ` Steven Rostedt
2025-04-18 21:39         ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418213945.GJaALGod4-j86Squ43@fat_crate.local \
    --to=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=ljx@cs.wisc.edu \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox