linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: KaFai Wan <mannkafai@gmail.com>
To: song@kernel.org, jolsa@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
	eddyz87@gmail.com, yonghong.song@linux.dev,
	john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
	haoluo@google.com, mattbobrowski@google.com, rostedt@goodmis.org,
	mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, mykolal@fb.com,
	shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, leon.hwang@linux.dev,
	mannkafai@gmail.com
Subject: [PATCH bpf-next 4/4] selftests/bpf: Add tests for get_func_[arg|arg_cnt] helpers in raw tracepoint programs
Date: Sun, 27 Apr 2025 00:00:27 +0800	[thread overview]
Message-ID: <20250426160027.177173-5-mannkafai@gmail.com> (raw)
In-Reply-To: <20250426160027.177173-1-mannkafai@gmail.com>

Adding tests for get_func_[arg|arg_cnt] helpers in raw tracepoint programs.
Using these helpers in raw_tp/tp_btf programs.

Signed-off-by: KaFai Wan <mannkafai@gmail.com>
---
 .../bpf/prog_tests/raw_tp_get_func_args.c     | 48 +++++++++++++++++++
 .../bpf/progs/test_raw_tp_get_func_args.c     | 47 ++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/raw_tp_get_func_args.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_raw_tp_get_func_args.c

diff --git a/tools/testing/selftests/bpf/prog_tests/raw_tp_get_func_args.c b/tools/testing/selftests/bpf/prog_tests/raw_tp_get_func_args.c
new file mode 100644
index 000000000000..cbe9b441d8d9
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/raw_tp_get_func_args.c
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <test_progs.h>
+#include <linux/bpf.h>
+#include "bpf/libbpf_internal.h"
+#include "test_raw_tp_get_func_args.skel.h"
+
+static void test_raw_tp_args(bool is_tp_btf)
+{
+	__u64 args[2] = {0x1234ULL, 0x5678ULL};
+	int expected_retval = 0x1234 + 0x5678;
+	struct test_raw_tp_get_func_args *skel;
+	LIBBPF_OPTS(bpf_test_run_opts, opts,
+		.ctx_in = args,
+		.ctx_size_in = sizeof(args),
+	);
+	int err, prog_fd;
+
+	skel = test_raw_tp_get_func_args__open_and_load();
+	if (!ASSERT_OK_PTR(skel, "skel_open"))
+		goto cleanup;
+
+	bpf_program__set_autoattach(skel->progs.tp_btf_test, is_tp_btf);
+	bpf_program__set_autoattach(skel->progs.raw_tp_test, !is_tp_btf);
+
+	err = test_raw_tp_get_func_args__attach(skel);
+	if (!ASSERT_OK(err, "skel_attach"))
+		goto cleanup;
+
+	if (is_tp_btf)
+		prog_fd = bpf_program__fd(skel->progs.tp_btf_test);
+	else
+		prog_fd = bpf_program__fd(skel->progs.raw_tp_test);
+	err = bpf_prog_test_run_opts(prog_fd, &opts);
+	ASSERT_OK(err, "test_run");
+	ASSERT_EQ(opts.retval, expected_retval, "check_retval");
+	ASSERT_EQ(skel->bss->test_result, 1, "test_result");
+
+cleanup:
+	test_raw_tp_get_func_args__destroy(skel);
+}
+
+void test_raw_tp_get_func_args(void)
+{
+	if (test__start_subtest("raw_tp"))
+		test_raw_tp_args(false);
+	if (test__start_subtest("tp_btf"))
+		test_raw_tp_args(true);
+}
diff --git a/tools/testing/selftests/bpf/progs/test_raw_tp_get_func_args.c b/tools/testing/selftests/bpf/progs/test_raw_tp_get_func_args.c
new file mode 100644
index 000000000000..5069bbd15283
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/test_raw_tp_get_func_args.c
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: GPL-2.0
+#include "vmlinux.h"
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+#include <errno.h>
+
+__u64 test_result = 0;
+
+static __always_inline int check_args(void *ctx, struct task_struct *task,
+				      char *comm)
+{
+	__u64 cnt = bpf_get_func_arg_cnt(ctx);
+	__u64 a = 0, b = 0, z = 0;
+	__s64 err;
+
+	if ((__u64)task != 0x1234ULL || (__u64)comm != 0x5678ULL)
+		return 0;
+
+	test_result = cnt == 2;
+
+	/* valid arguments */
+	err = bpf_get_func_arg(ctx, 0, &a);
+	test_result &= err == 0 && a == 0x1234ULL;
+
+	err = bpf_get_func_arg(ctx, 1, &b);
+	test_result &= err == 0 && b == 0x5678ULL;
+
+	/* not valid argument */
+	err = bpf_get_func_arg(ctx, 2, &z);
+	test_result &= err == -EINVAL;
+
+	return a + b;
+}
+
+SEC("raw_tp/task_rename")
+int BPF_PROG(raw_tp_test, struct task_struct *task, char *comm)
+{
+	return check_args(ctx, task, comm);
+}
+
+SEC("tp_btf/task_rename")
+int BPF_PROG(tp_btf_test, struct task_struct *task, char *comm)
+{
+	return check_args(ctx, task, comm);
+}
+
+char _license[] SEC("license") = "GPL";
-- 
2.43.0


      parent reply	other threads:[~2025-04-26 16:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26 16:00 [PATCH bpf-next 0/4] bpf: Allow get_func_[arg|arg_cnt] helpers in raw tracepoint programs KaFai Wan
2025-04-26 16:00 ` [PATCH bpf-next 1/4] " KaFai Wan
2025-04-30  2:46   ` Alexei Starovoitov
2025-04-30 12:43     ` Kafai Wan
2025-04-30 15:54       ` Leon Hwang
2025-04-30 16:53         ` Alexei Starovoitov
2025-05-02 14:25           ` Leon Hwang
2025-05-06 21:01             ` Andrii Nakryiko
2025-05-12 11:12               ` Leon Hwang
2025-05-12 15:25                 ` Alexei Starovoitov
2025-05-12 16:01                   ` Leon Hwang
2025-05-01 20:53       ` Andrii Nakryiko
2025-04-26 16:00 ` [PATCH bpf-next 2/4] bpf: Enable BPF_PROG_TEST_RUN for tp_btf KaFai Wan
2025-05-01 20:55   ` Andrii Nakryiko
2025-04-26 16:00 ` [PATCH bpf-next 3/4] selftests/bpf: Add raw_tp_test_run " KaFai Wan
2025-04-26 16:00 ` KaFai Wan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250426160027.177173-5-mannkafai@gmail.com \
    --to=mannkafai@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=haoluo@google.com \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon.hwang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mattbobrowski@google.com \
    --cc=mhiramat@kernel.org \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).