From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
john.ogness@linutronix.de, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v5 21/23] rv: Add rtapp_sleep monitor
Date: Wed, 30 Apr 2025 10:38:19 +0200 [thread overview]
Message-ID: <20250430083819.-UXxRu1U@linutronix.de> (raw)
In-Reply-To: <c0dca589e8615e1e0105cf1ae20f3f613992d33d.camel@redhat.com>
On Wed, Apr 30, 2025 at 10:05:07AM +0200, Gabriele Monaco wrote:
> I've got one more small remark though, the name ALLOWLIST doesn't give
> justice to what you explained above.
> It suggests me something potentially wrong that we can't do much about,
> while in case of RT mutexes and futex lock, we just don't want the
> monitor to yell in a perfectly RT-compliant scenario.
>
> What is happening here, from what I see, is that the kernel is handling
> the RT behaviour and your monitor is just meant to tell when userspace
> is doing something it could do better (unless we deal with kthreads,
> there we are in fact whitelisting the ones we know are not complying).
>
> What about calling it RT_KERNEL_MANAGED_SLEEP or something along the
> line to say we just trust what the kernel is doing?
That would also work. The generated automaton should be exactly the same.
But I think this is quite subjective, so let's not argue too much about it.
In short, I prefer it as is, sorry.
I think "ALLOWLIST" is a suitable name. From Wikipedia: "A whitelist or
allowlist is a list or register of entities that are being provided a
particular privilege, service, mobility, access or recognition. Entities on
the list will be accepted, approved and/or recognized".
We trust rt_mutex and futex_lock_pi to do the right things, so I think they
belong to the allowlist. We also trust the RCU thread and the migration/
threads to be correct.
Best regards,
Nam
next prev parent reply other threads:[~2025-04-30 8:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 12:00 [PATCH v5 00/23] RV: Linear temporal logic monitors for RT application Nam Cao
2025-04-29 12:00 ` [PATCH v5 01/23] rv: Add #undef TRACE_INCLUDE_FILE Nam Cao
2025-04-29 12:00 ` [PATCH v5 02/23] printk: Make vprintk_deferred() public Nam Cao
2025-04-29 12:00 ` [PATCH v5 03/23] panic: Add vpanic() Nam Cao
2025-04-29 12:00 ` [PATCH v5 04/23] rv: Let the reactors take care of buffers Nam Cao
2025-04-29 12:00 ` [PATCH v5 05/23] verification/dot2k: Make a separate dot2k_templates/Kconfig_container Nam Cao
2025-04-29 12:00 ` [PATCH v5 06/23] verification/dot2k: Remove __buff_to_string() Nam Cao
2025-04-29 12:00 ` [PATCH v5 07/23] verification/dot2k: Replace is_container() hack with subparsers Nam Cao
2025-04-29 12:00 ` [PATCH v5 08/23] rv: rename CONFIG_DA_MON_EVENTS to CONFIG_RV_MON_EVENTS Nam Cao
2025-04-29 12:00 ` [PATCH v5 09/23] verification/dot2k: Prepare the frontend for LTL inclusion Nam Cao
2025-04-29 12:00 ` [PATCH v5 10/23] Documentation/rv: Prepare monitor synthesis document " Nam Cao
2025-04-29 12:00 ` [PATCH v5 11/23] verification/rvgen: Restructure the templates files Nam Cao
2025-04-29 12:00 ` [PATCH v5 12/23] verification/rvgen: Restructure the classes to prepare for LTL inclusion Nam Cao
2025-04-29 12:00 ` [PATCH v5 13/23] rv: Add support for LTL monitors Nam Cao
2025-04-29 12:00 ` [PATCH v5 14/23] rv: Add rtapp container monitor Nam Cao
2025-04-29 12:01 ` [PATCH v5 15/23] x86/tracing: Remove redundant trace_pagefault_key Nam Cao
2025-04-29 12:01 ` [PATCH v5 16/23] x86/tracing: Move page fault trace points to generic Nam Cao
2025-04-29 12:01 ` [PATCH v5 17/23] arm64: mm: Add page fault trace points Nam Cao
2025-04-29 12:01 ` [PATCH v5 18/23] riscv: " Nam Cao
2025-04-29 12:01 ` [PATCH v5 19/23] rv: Add rtapp_pagefault monitor Nam Cao
2025-04-29 12:01 ` [PATCH v5 20/23] locking/rtmutex: Add block_on_rt_mutex tracepoints Nam Cao
2025-04-29 12:01 ` [PATCH v5 21/23] rv: Add rtapp_sleep monitor Nam Cao
2025-04-29 16:01 ` Gabriele Monaco
2025-04-29 17:20 ` Nam Cao
2025-04-30 8:05 ` Gabriele Monaco
2025-04-30 8:38 ` Nam Cao [this message]
2025-04-29 12:01 ` [PATCH v5 22/23] rv: Add documentation for rtapp monitor Nam Cao
2025-04-29 12:01 ` [PATCH v5 23/23] rv: Allow to configure the number of per-task monitor Nam Cao
2025-08-10 21:12 ` [PATCH v5 00/23] RV: Linear temporal logic monitors for RT application patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430083819.-UXxRu1U@linutronix.de \
--to=namcao@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=gmonaco@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).