From: Al Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v2] kill vfs_submount()
Date: Mon, 5 May 2025 23:00:47 +0100 [thread overview]
Message-ID: <20250505220047.GJ2023217@ZenIV> (raw)
In-Reply-To: <20250505213829.GI2023217@ZenIV>
On Mon, May 05, 2025 at 10:38:29PM +0100, Al Viro wrote:
> On Mon, May 05, 2025 at 12:55:34PM +0200, Jan Kara wrote:
> > > if (!type)
> > > return NULL;
> > > - mnt = vfs_submount(mntpt, type, "tracefs", NULL);
> > > +
> > > + fc = fs_context_for_submount(type, mntpt);
> > > + if (IS_ERR(fc))
> > > + return ERR_CAST(fc);
> >
> > Missing put_filesystem() here?
>
> Actually, I'd rather have it done unconditionally right after
> fc_context_for_submount() - fs_context allocation grabs
> a reference and it's held until put_fs_context, so...
Just in case - that stuff is still on top of ->d_automount() calling
conventions change; see viro/vfs.git#work.automount for both.
next prev parent reply other threads:[~2025-05-05 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 21:29 [PATCH][RFC][CFT] kill vfs_submount(), already Al Viro
2025-05-05 10:55 ` Jan Kara
2025-05-05 21:38 ` [PATCH v2] kill vfs_submount() Al Viro
2025-05-05 22:00 ` Al Viro [this message]
2025-05-06 0:19 ` Steven Rostedt
2025-05-06 10:57 ` Jan Kara
2025-05-05 13:57 ` [PATCH][RFC][CFT] kill vfs_submount(), already Christian Brauner
2025-05-05 14:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505220047.GJ2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).