From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: <rostedt@goodmis.org>, <lukas@wunner.de>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <helgaas@kernel.org>,
<bhelgaas@google.com>, <tony.luck@intel.com>, <bp@alien8.de>,
<mhiramat@kernel.org>, <mathieu.desnoyers@efficios.com>,
<oleg@redhat.com>, <naveen@kernel.org>, <davem@davemloft.net>,
<anil.s.keshavamurthy@intel.com>, <mark.rutland@arm.com>,
<peterz@infradead.org>, <tianruidong@linux.alibaba.com>
Subject: Re: [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for hotplug event
Date: Wed, 7 May 2025 12:09:14 +0100 [thread overview]
Message-ID: <20250507120914.000001c8@huawei.com> (raw)
In-Reply-To: <20250507011535.43800-1-xueshuai@linux.alibaba.com>
On Wed, 7 May 2025 09:15:35 +0800
Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> Hotplug events are critical indicators for analyzing hardware health,
> particularly in AI supercomputers where surprise link downs can
> significantly impact system performance and reliability.
>
> To this end, define a new TRACING_SYSTEM named pci, add a generic RAS
> tracepoint for hotplug event to help healthy check, and generate
> tracepoints for pcie hotplug event. Add enum pci_hotplug_event in
> include/uapi/linux/pci.h so applications like rasdaemon can register
> tracepoint event handlers for it.
>
> The output like below:
>
> $ echo 1 > /sys/kernel/debug/tracing/events/pci/pci_hp_event/enable
> $ cat /sys/kernel/debug/tracing/trace_pipe
> <...>-206 [001] ..... 40.373870: pci_hp_event: 0000:00:02.0 slot:10, event:Link Down
>
> <...>-206 [001] ..... 40.374871: pci_hp_event: 0000:00:02.0 slot:10, event:Card not present
>
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
FWIW looks good to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Any userspace tooling planned for this?
next prev parent reply other threads:[~2025-05-07 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 1:15 [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for hotplug event Shuai Xue
2025-05-07 11:09 ` Jonathan Cameron [this message]
2025-05-07 12:03 ` Shuai Xue
2025-05-07 15:36 ` Steven Rostedt
2025-05-08 1:24 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507120914.000001c8@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tianruidong@linux.alibaba.com \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox