From: Andrew Morton <akpm@linux-foundation.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Yushan Zhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v1 2/5] relayfs: introduce dump of relayfs statistics function
Date: Mon, 12 May 2025 20:41:24 -0700 [thread overview]
Message-ID: <20250512204124.5f201b7bcc394f773f2d40b9@linux-foundation.org> (raw)
In-Reply-To: <CAL+tcoD+VrRfAGMjj=9uAbanMO=W+cW0xgxMzVwrpiTgagmQ2w@mail.gmail.com>
On Tue, 13 May 2025 10:26:45 +0800 Jason Xing <kerneljasonxing@gmail.com> wrote:
> >
> > Maybe we don't need to check !chan either. Can it be NULL here?
>
> It depends on how users call this. If users call this without
> initialization of chan, relay_dump() can avoid the crash. It works
> like kfree() which prevents the NULL object from being freed.
hm, OK. Generally, I don't think that kernel code should be very
tolerant of bugs in the caller. If the caller passes us bad stuff then
that's the caller's fault and the caller should be fixed. If the
client code responds to bad input with a nice solid oops, then great!
The caller will get fixed.
> BTW, should I merge this commit [1] into the series in V2 so that you
> can easily review?
>
> [1]: https://lore.kernel.org/all/20250507134225.63248-1-kerneljasonxing@gmail.com/
That seems unrelated to this work so it seems inappropriate to combine
the two.
I skipped [1] because I'm waiting for overall clarity on what's
happening with relay[fs].
next prev parent reply other threads:[~2025-05-13 3:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 2:49 [PATCH v1 0/5] relayfs: misc changes Jason Xing
2025-05-12 2:49 ` [PATCH v1 1/5] relayfs: support a counter tracking if per-cpu buffers is full Jason Xing
2025-05-13 0:51 ` Andrew Morton
2025-05-13 1:37 ` Jason Xing
2025-05-12 2:49 ` [PATCH v1 2/5] relayfs: introduce dump of relayfs statistics function Jason Xing
2025-05-13 0:51 ` Andrew Morton
2025-05-13 1:48 ` Jason Xing
2025-05-13 2:04 ` Andrew Morton
2025-05-13 2:26 ` Jason Xing
2025-05-13 3:41 ` Andrew Morton [this message]
2025-05-13 3:48 ` Jason Xing
2025-05-13 9:58 ` Masami Hiramatsu
2025-05-13 10:32 ` Jason Xing
2025-05-13 13:22 ` Masami Hiramatsu
2025-05-13 13:46 ` Jason Xing
2025-05-14 1:29 ` Masami Hiramatsu
2025-05-14 2:06 ` Jason Xing
2025-05-12 2:49 ` [PATCH v1 3/5] blktrace: use rbuf->stats.full as a drop indicator in relayfs Jason Xing
2025-05-12 2:49 ` [PATCH v1 4/5] relayfs: support a counter tracking if data is too big to write Jason Xing
2025-05-12 2:49 ` [PATCH v1 5/5] relayfs: uniformally use possible cpu iteration Jason Xing
2025-05-13 0:52 ` Andrew Morton
2025-05-13 2:03 ` Jason Xing
2025-05-13 3:21 ` Andrew Morton
2025-05-13 3:25 ` Jason Xing
2025-05-13 5:52 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512204124.5f201b7bcc394f773f2d40b9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=katrinzhou@tencent.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).