From: Steven Rostedt <rostedt@goodmis.org>
To: Kassey Li <quic_yingangl@quicinc.com>
Cc: <James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <mathieu.desnoyers@efficios.com>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: trace: change the rtn log in string
Date: Wed, 14 May 2025 09:09:17 -0400 [thread overview]
Message-ID: <20250514090917.0fd363d5@batman.local.home> (raw)
In-Reply-To: <20250514074456.450006-1-quic_yingangl@quicinc.com>
On Wed, 14 May 2025 15:44:56 +0800
Kassey Li <quic_yingangl@quicinc.com> wrote:
> In default it showed rtn in decimal.
>
> kworker/3:1H-183 [003] .... 51.035474: scsi_dispatch_cmd_error: host_no=0 channel=0 id=0 lun=4 data_sgl=1 prot_sgl=0 prot_op=SCSI_PROT_NORMAL cmnd=(READ_10 lba=3907214 txlen=1 protect=0 raw=28 00 00 3b 9e 8e 00 00 01 00) rtn=4181
>
> In source code we define these possible value as hexadecimal:
>
> include/scsi/scsi.h
>
> SCSI_MLQUEUE_HOST_BUSY 0x1055
> SCSI_MLQUEUE_DEVICE_BUSY 0x1056
> SCSI_MLQUEUE_EH_RETRY 0x1057
> SCSI_MLQUEUE_TARGET_BUSY 0x1058
>
> This change shows the string type.
Nit, but would an example of the new output be useful in the change log?
>
> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
Other than that,
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2025-05-14 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 7:44 [PATCH v2] scsi: trace: change the rtn log in string Kassey Li
2025-05-14 13:09 ` Steven Rostedt [this message]
2025-05-19 9:40 ` Kassey Li quic
2025-05-14 13:39 ` James Bottomley
2025-05-19 9:37 ` Kassey Li quic
2025-05-14 23:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514090917.0fd363d5@batman.local.home \
--to=rostedt@goodmis.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=quic_yingangl@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox