From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69CA1F4190; Fri, 23 May 2025 20:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748032112; cv=none; b=W6n8yFR2lGn0mBcn9R3FWXpXG1mLWFj6fGn22SN8i0rkZJvuIVvwtyrSJc/LOXOJyjeGFW1tg+gO6azZq4kvkli3h/V2/rkMPqzxPlT5cf4RgD9qE1quoql+foa3ShwzNZjQmdW+TzXXFKiBrtYZP03b4QhOU4sn9GWxg7Kx4vQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748032112; c=relaxed/simple; bh=mCqS/Kijb63hfjRogkIoo1V9a7plAKd5pBatsPb3zS4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LS/8fhVg7sm2WnQpDtlIWJXQPnT21aQZ0YJbS+Ew4ew/yArd+lQg115XcXZvJ7dSpWLhngt3D5PgGQN7++nVC4tWRk7jQ09zk55CdAQyI+raymGMHNAOcL39A5WLp6yQ49CmvdLGVQbLeWPHYGyn2+0F+rclSRhj4QLJkkDtM0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cKCTWrMO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cKCTWrMO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 704C1C4CEE9; Fri, 23 May 2025 20:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748032111; bh=mCqS/Kijb63hfjRogkIoo1V9a7plAKd5pBatsPb3zS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKCTWrMOz8QGFkwtap37uEMcxPQVostPEoFPh+liJpGoIZm7yUbph01VSxYIZ9Mnu Xp2SFx8fCFcAMCn/ELInspiWG36xJF3J7d0jPlVxo6aeh9oNz5+dzf8Kq3g/Xe/so1 mYCrUnXAuBAVZPsZr7ruImlYVc+gipnIRXGuB54FA2ds4IMAQQ3eh1QLM/4b0qJj2M gTr/IjcVsa0wubmGcNRixgHZajZrPNsHowCdWXY/LC03W+Pu6hAChB6eWCEPXnK99u 2vaA5rFoq3M2ELAJVxf64ufJ8UJLD7jY5t0UU+6I6+n7SgWhzCzujvRIpD5lc47LG4 +IQz87qYLaslQ== Date: Fri, 23 May 2025 13:28:28 -0700 From: Kees Cook To: Sean Christopherson Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches Message-ID: <202505231327.3FA45E4B@keescook> References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 23, 2025 at 07:35:03AM -0700, Sean Christopherson wrote: > On Thu, May 22, 2025, Kees Cook wrote: > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > > index 921c1c783bc1..72f13d643fca 100644 > > --- a/arch/x86/kernel/kvm.c > > +++ b/arch/x86/kernel/kvm.c > > @@ -420,7 +420,7 @@ static u64 kvm_steal_clock(int cpu) > > return steal; > > } > > > > -static inline void __set_percpu_decrypted(void *ptr, unsigned long size) > > +static __always_inline void __set_percpu_decrypted(void *ptr, unsigned long size) > > I'd rather drop the "inline" and explicitly mark this "__init". There's value > in documenting and enforcing that memory is marked decrypted/shared only during > boot. Sure! I will swap this around. Thanks! -Kees -- Kees Cook