From: Simon Horman <horms@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsd: use threads array as-is in netlink interface
Date: Wed, 28 May 2025 18:07:05 +0100 [thread overview]
Message-ID: <20250528170705.GG1484967@horms.kernel.org> (raw)
In-Reply-To: <20250527-rpc-numa-v1-1-fa1d98e9a900@kernel.org>
On Tue, May 27, 2025 at 08:12:47PM -0400, Jeff Layton wrote:
> The old nfsdfs interface for starting a server with multiple pools
> handles the special case of a single entry array passed down from
> userland by distributing the threads over every NUMA node.
>
> The netlink control interface however constructs an array of length
> nfsd_nrpools() and fills any unprovided slots with 0's. This behavior
> defeats the special casing that the old interface relies on.
>
> Change nfsd_nl_threads_set_doit() to pass down the array from userland
> as-is.
>
> Fixes: 7f5c330b2620 ("nfsd: allow passing in array of thread counts via netlink")
> Reported-by: Mike Snitzer <snitzer@kernel.org>
> Closes: https://lore.kernel.org/linux-nfs/aDC-ftnzhJAlwqwh@kernel.org/
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-28 17:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 0:12 [PATCH 0/2] nfsd: use threads array as-is in netlink thread set interface Jeff Layton
2025-05-28 0:12 ` [PATCH 1/2] nfsd: use threads array as-is in netlink interface Jeff Layton
2025-05-28 17:07 ` Simon Horman [this message]
2025-06-12 15:57 ` Jeff Layton
2025-06-12 16:05 ` Chuck Lever
2025-06-12 16:15 ` Jeff Layton
2025-06-12 16:42 ` Chuck Lever
2025-06-13 11:33 ` Benjamin Coddington
2025-06-13 14:56 ` Chuck Lever
2025-06-13 15:23 ` Benjamin Coddington
2025-06-13 15:38 ` Chuck Lever
2025-06-13 21:05 ` Jeff Layton
2025-06-13 18:57 ` Mike Snitzer
2025-06-13 19:00 ` Chuck Lever
2025-05-28 0:12 ` [PATCH 2/2] sunrpc: new tracepoints around svc thread wakeups Jeff Layton
2025-05-28 17:13 ` Simon Horman
2025-05-28 18:11 ` [PATCH 0/2] nfsd: use threads array as-is in netlink thread set interface cel
2025-05-28 18:22 ` Jeff Layton
2025-05-28 18:25 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528170705.GG1484967@horms.kernel.org \
--to=horms@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=snitzer@kernel.org \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).