From: Steven Rostedt <rostedt@goodmis.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: open list <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
lkft-triage@lists.linaro.org,
Linux Regressions <regressions@lists.linux.dev>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Masami Hiramatsu <mhiramat@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
Anders Roxell <anders.roxell@linaro.org>
Subject: Re: next-20250604: qemu-riscv64 ltp tracing warning kernel trace trace.c ignore_event
Date: Thu, 5 Jun 2025 09:21:17 -0400 [thread overview]
Message-ID: <20250605092117.37a245dd@batman.local.home> (raw)
In-Reply-To: <CA+G9fYuXxxPG7YY4ffbJ=hrBvBU4171J_FykYC2xoPV6uUB2sg@mail.gmail.com>
On Thu, 5 Jun 2025 18:24:08 +0530
Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> Regression while running LTP tracing on the Linux next-20250604 and
> next-20250605
> the following kernel warnings found on the qemu-riscv64.
>
> Regressions found on qemu-riscv64
> - LTP tracing
>
> Regression Analysis:
> - New regression? Yes
> - Reproducibility? Yes
>
> First seen on the next-20250604
> Good: next-20250603
> Bad: next-20250604
>
> Test regression: qemu-riscv64 ltp tracing warning kernel trace trace.c
Does riscv64 place __func__ in rodata? If not, this may consider the
string unsafe to use in an event.
> ignore_event
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> ## Test error
>
> ------------[ cut here ]------------
> [ 28.134981] event 'ma_read' has unsafe pointer field 'fn'
In lib/maple_tree.c we have:
trace_ma_read(__func__, &mas);
Where it records the address of "__func__" into the ring buffer 'fn' field.
At a much later time (when the ring buffer is read), that pointer is
dereferenced. As rodata doesn't change for the life of the kernel, it
is safe to dereference. But if riscv doesn't place __func__ into
rodata, this will be considered unsafe to use.
-- Steve
prev parent reply other threads:[~2025-06-05 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 12:54 next-20250604: qemu-riscv64 ltp tracing warning kernel trace trace.c ignore_event Naresh Kamboju
2025-06-05 13:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605092117.37a245dd@batman.local.home \
--to=rostedt@goodmis.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mhiramat@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=regressions@lists.linux.dev \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox