[PATCH] binder: Remove unused binder lock events

[PATCH] binder: Remove unused binder lock events

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

Trace events can take up to 5K each when they are defined, regardless if
they are used or not. The binder lock events: binder_lock, binder_locked
and binder_unlock are no longer used.

Remove them.

Fixes: a60b890f607d ("binder: remove global binder lock")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Note, I will be adding code soon that will make unused events cause a warning.

 drivers/android/binder_trace.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/android/binder_trace.h b/drivers/android/binder_trace.h
index 16de1b9e72f7..97a78e5623db 100644
--- a/drivers/android/binder_trace.h
+++ b/drivers/android/binder_trace.h
@@ -34,27 +34,6 @@ TRACE_EVENT(binder_ioctl,
 	TP_printk("cmd=0x%x arg=0x%lx", __entry->cmd, __entry->arg)
 );
 
-DECLARE_EVENT_CLASS(binder_lock_class,
-	TP_PROTO(const char *tag),
-	TP_ARGS(tag),
-	TP_STRUCT__entry(
-		__field(const char *, tag)
-	),
-	TP_fast_assign(
-		__entry->tag = tag;
-	),
-	TP_printk("tag=%s", __entry->tag)
-);
-
-#define DEFINE_BINDER_LOCK_EVENT(name)	\
-DEFINE_EVENT(binder_lock_class, name,	\
-	TP_PROTO(const char *func), \
-	TP_ARGS(func))
-
-DEFINE_BINDER_LOCK_EVENT(binder_lock);
-DEFINE_BINDER_LOCK_EVENT(binder_locked);
-DEFINE_BINDER_LOCK_EVENT(binder_unlock);
-
 DECLARE_EVENT_CLASS(binder_function_return_class,
 	TP_PROTO(int ret),
 	TP_ARGS(ret),
-- 
2.47.2

Re: [PATCH] binder: Remove unused binder lock events

[Carlos Llamas]

On Thu, Jun 12, 2025 at 09:34:08AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> Trace events can take up to 5K each when they are defined, regardless if
> they are used or not. The binder lock events: binder_lock, binder_locked
> and binder_unlock are no longer used.
> 
> Remove them.
> 
> Fixes: a60b890f607d ("binder: remove global binder lock")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---

Thanks Steven!

Acked-by: Carlos Llamas <cmllamas@google.com>

Re: [PATCH] binder: Remove unused binder lock events

[Alice Ryhl]

On Thu, Jun 12, 2025 at 09:34:08AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> Trace events can take up to 5K each when they are defined, regardless if
> they are used or not. The binder lock events: binder_lock, binder_locked
> and binder_unlock are no longer used.
> 
> Remove them.
> 
> Fixes: a60b890f607d ("binder: remove global binder lock")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>