linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	bpf@vger.kernel.org, x86@kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrii Nakryiko <andrii@kernel.org>,
	Indu Bhagat <indu.bhagat@oracle.com>,
	"Jose E. Marchesi" <jemarch@gnu.org>,
	Beau Belgrave <beaub@linux.microsoft.com>,
	Jens Remus <jremus@linux.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v10 05/11] perf: Skip user unwind if the task is a kernel thread
Date: Fri, 13 Jun 2025 22:46:10 -0400	[thread overview]
Message-ID: <20250614024716.450609897@goodmis.org> (raw)
In-Reply-To: 20250614024605.597728558@goodmis.org

From: Josh Poimboeuf <jpoimboe@kernel.org>

If the task is not a user thread, there's no user stack to unwind.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/events/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 375115492c02..55d5d4ded7ab 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8144,7 +8144,8 @@ struct perf_callchain_entry *
 perf_callchain(struct perf_event *event, struct pt_regs *regs)
 {
 	bool kernel = !event->attr.exclude_callchain_kernel;
-	bool user   = !event->attr.exclude_callchain_user;
+	bool user   = !event->attr.exclude_callchain_user &&
+		!(current->flags & PF_KTHREAD);
 	/* Disallow cross-task user callchains. */
 	bool crosstask = event->ctx->task && event->ctx->task != current;
 	const u32 max_stack = event->attr.sample_max_stack;
-- 
2.47.2



  parent reply	other threads:[~2025-06-14  2:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-14  2:46 [PATCH v10 00/11] perf: Support the deferred unwinding infrastructure Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 01/11] perf: Remove get_perf_callchain() init_nr argument Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 02/11] perf: Have get_perf_callchain() return NULL if crosstask and user are set Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 03/11] perf: Use current->flags & PF_KTHREAD instead of current->mm == NULL Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 04/11] perf: Simplify get_perf_callchain() user logic Steven Rostedt
2025-06-14  2:46 ` Steven Rostedt [this message]
2025-06-14  2:46 ` [PATCH v10 06/11] perf: Support deferred user callchains Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 07/11] perf: Support deferred user callchains for per CPU events Steven Rostedt
2025-06-15  2:41   ` Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 08/11] perf tools: Minimal CALLCHAIN_DEFERRED support Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 09/11] perf record: Enable defer_callchain for user callchains Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 10/11] perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED Steven Rostedt
2025-06-14  2:46 ` [PATCH v10 11/11] perf tools: Merge deferred user callchains Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250614024716.450609897@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=beaub@linux.microsoft.com \
    --cc=bpf@vger.kernel.org \
    --cc=indu.bhagat@oracle.com \
    --cc=jemarch@gnu.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=jremus@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).