* [PATCH] fgraph: Make pid_str size match the comment
@ 2025-06-17 15:21 Artem Sadovnikov
2025-06-20 0:30 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Artem Sadovnikov @ 2025-06-17 15:21 UTC (permalink / raw)
To: linux-kernel
Cc: Artem Sadovnikov, Steven Rostedt, Masami Hiramatsu,
linux-trace-kernel, lvc-project
The comment above buffer mentions sign, 10 bytes width for number and null
terminator, but buffer itself isn't large enough to hold that much data.
This is a cosmetic change, since PID cannot be negative, other than -1.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artem Sadovnikov <a.sadovnikov@ispras.ru>
---
kernel/trace/trace_functions_graph.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index a8c1f56340680..d789d308ab1de 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -344,7 +344,7 @@ static void print_graph_proc(struct trace_seq *s, pid_t pid)
{
char comm[TASK_COMM_LEN];
/* sign + log10(MAX_INT) + '\0' */
- char pid_str[11];
+ char pid_str[12];
int spaces = 0;
int len;
int i;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fgraph: Make pid_str size match the comment
2025-06-17 15:21 [PATCH] fgraph: Make pid_str size match the comment Artem Sadovnikov
@ 2025-06-20 0:30 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2025-06-20 0:30 UTC (permalink / raw)
To: Artem Sadovnikov
Cc: linux-kernel, Steven Rostedt, Masami Hiramatsu,
linux-trace-kernel, lvc-project
On Tue, 17 Jun 2025 15:21:09 +0000
Artem Sadovnikov <a.sadovnikov@ispras.ru> wrote:
> The comment above buffer mentions sign, 10 bytes width for number and null
> terminator, but buffer itself isn't large enough to hold that much data.
>
> This is a cosmetic change, since PID cannot be negative, other than -1.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
Looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks,
>
> Signed-off-by: Artem Sadovnikov <a.sadovnikov@ispras.ru>
> ---
> kernel/trace/trace_functions_graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index a8c1f56340680..d789d308ab1de 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -344,7 +344,7 @@ static void print_graph_proc(struct trace_seq *s, pid_t pid)
> {
> char comm[TASK_COMM_LEN];
> /* sign + log10(MAX_INT) + '\0' */
> - char pid_str[11];
> + char pid_str[12];
> int spaces = 0;
> int len;
> int i;
> --
> 2.43.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-20 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 15:21 [PATCH] fgraph: Make pid_str size match the comment Artem Sadovnikov
2025-06-20 0:30 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).