From: Steven Rostedt <rostedt@goodmis.org>
To: Nam Cao <namcao@linutronix.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
Gabriele Monaco <gmonaco@redhat.com>,
john.ogness@linutronix.de
Subject: Re: [PATCH] tracing: Remove pointless memory barriers
Date: Thu, 26 Jun 2025 11:37:08 -0400 [thread overview]
Message-ID: <20250626113708.4a96e47c@gandalf.local.home> (raw)
In-Reply-To: <20250626113520.315db641@gandalf.local.home>
On Thu, 26 Jun 2025 11:35:20 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > @@ -2710,8 +2705,6 @@ void trace_buffered_event_enable(void)
> >
> > static void enable_trace_buffered_event(void *data)
> > {
> > - /* Probably not needed, but do it anyway */
> > - smp_rmb();
>
> As the comment says, this one actually isn't needed, and yes, it can be
> removed.
One reason this isn't needed is because it's called via on_each_cpu() which
will trigger its own barriers.
-- Steve
next prev parent reply other threads:[~2025-06-26 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 15:19 [PATCH] tracing: Remove pointless memory barriers Nam Cao
2025-06-26 15:35 ` Steven Rostedt
2025-06-26 15:37 ` Steven Rostedt [this message]
2025-06-26 16:04 ` Nam Cao
2025-06-26 16:34 ` Steven Rostedt
2025-06-26 17:41 ` John Ogness
2025-07-03 8:05 ` Gabriele Monaco
2025-07-08 7:42 ` Nam Cao
2025-07-09 15:08 ` Steven Rostedt
2025-07-11 8:29 ` David Laight
2025-07-11 16:07 ` Steven Rostedt
2025-07-09 8:22 ` David Laight
2025-07-22 0:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626113708.4a96e47c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gmonaco@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namcao@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox