From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Ghiti <alex@ghiti.fr>, ChenMiao <chenmiao.ku@gmail.com>,
linux-arch@vger.kernel.org
Subject: Re: [RFC][PATCH] ftrace: Make DYNAMIC_FTRACE always enabled for architectures that support it
Date: Fri, 4 Jul 2025 11:12:48 -0400 [thread overview]
Message-ID: <20250704111248.511cc248@gandalf.local.home> (raw)
In-Reply-To: <CAHk-=wgdM_A1iWs6=y__nDcVq9pZRynd1mO8F9XnAeZuHumHtA@mail.gmail.com>
On Thu, 3 Jul 2025 13:58:17 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> So the reason I dislike the HAVE_xyz pattern is exactly that there
> _isn't_ a pattern. When there are fifteen different patterns, it's not
> a pattern at all.
>
> That said, maybe it's better to have one place that has that "if
> FUNCTION_TRACER, even if I despise the nonsensical "helper
> indirection" just because of the random naming.
At least with HAVE_FTRACE_* there is a pattern. The HAVE_* may not be
consistent across other parts of the kernel, but it has been with ftrace.
As I have stated, ftrace is very tightly coupled with the architectures due
to the assembly written trampolines. And having a simple way for the
architectures to denote what it supports and what it does not makes the
generic code much simpler to implement.
-- Steve
prev parent reply other threads:[~2025-07-04 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 15:52 [RFC][PATCH] ftrace: Make DYNAMIC_FTRACE always enabled for architectures that support it Steven Rostedt
2025-07-03 16:57 ` Linus Torvalds
2025-07-03 19:26 ` Steven Rostedt
2025-07-03 19:49 ` Steven Rostedt
2025-07-03 19:52 ` Steven Rostedt
2025-07-03 20:58 ` Linus Torvalds
2025-07-04 15:12 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704111248.511cc248@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alex@ghiti.fr \
--cc=chenmiao.ku@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox