* [PATCH] tools: bootconfig: Regex brackets need escape
@ 2025-07-08 9:16 Bhaskar Chowdhury
2025-07-09 2:12 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Bhaskar Chowdhury @ 2025-07-08 9:16 UTC (permalink / raw)
To: mhiramat, linux-kernel, linux-trace-kernel; +Cc: Bhaskar Chowdhury
It was showing malformed syntax colors below those lines,escaping the posix
class brackets bring back the syntatic reference back.
Oh, malformed syntax colors means,(in a editor,in this case Vim, where syntax
highlight is on). In essence, it might complain while running the script.
Hence, this trivialities.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
tools/bootconfig/test-bootconfig.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
index a2c484c243f5..211409539737 100755
--- a/tools/bootconfig/test-bootconfig.sh
+++ b/tools/bootconfig/test-bootconfig.sh
@@ -167,8 +167,8 @@ echo > $INITRD
xpass $BOOTCONF -a $TEMPCONF $INITRD
$BOOTCONF $INITRD > $OUTFILE
-xfail grep -q val[[:space:]] $OUTFILE
-xpass grep -q val2[[:space:]] $OUTFILE
+xfail grep -q val\[\[:space:\]\] $OUTFILE
+xpass grep -q val2\[\[:space:\]\] $OUTFILE
echo "=== expected failure cases ==="
for i in samples/bad-* ; do
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: bootconfig: Regex brackets need escape
2025-07-08 9:16 [PATCH] tools: bootconfig: Regex brackets need escape Bhaskar Chowdhury
@ 2025-07-09 2:12 ` Masami Hiramatsu
2025-07-09 2:55 ` Bhaskar Chowdhury
0 siblings, 1 reply; 3+ messages in thread
From: Masami Hiramatsu @ 2025-07-09 2:12 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: linux-kernel, linux-trace-kernel
Hi Bhaskar,
On Tue, 8 Jul 2025 14:46:08 +0530
Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
> It was showing malformed syntax colors below those lines,escaping the posix
> class brackets bring back the syntatic reference back.
>
> Oh, malformed syntax colors means,(in a editor,in this case Vim, where syntax
> highlight is on). In essence, it might complain while running the script.
Hmm, that means your editor's parser's bug, right?
>
> Hence, this trivialities.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> tools/bootconfig/test-bootconfig.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
> index a2c484c243f5..211409539737 100755
> --- a/tools/bootconfig/test-bootconfig.sh
> +++ b/tools/bootconfig/test-bootconfig.sh
> @@ -167,8 +167,8 @@ echo > $INITRD
>
> xpass $BOOTCONF -a $TEMPCONF $INITRD
> $BOOTCONF $INITRD > $OUTFILE
> -xfail grep -q val[[:space:]] $OUTFILE
> -xpass grep -q val2[[:space:]] $OUTFILE
> +xfail grep -q val\[\[:space:\]\] $OUTFILE
> +xpass grep -q val2\[\[:space:\]\] $OUTFILE
Can you escape it by quotations? In that case, it is acceptable
as a cleanup. e.g. 'val[[:space:]]'.
Thank you,
>
> echo "=== expected failure cases ==="
> for i in samples/bad-* ; do
> --
> 2.49.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: bootconfig: Regex brackets need escape
2025-07-09 2:12 ` Masami Hiramatsu
@ 2025-07-09 2:55 ` Bhaskar Chowdhury
0 siblings, 0 replies; 3+ messages in thread
From: Bhaskar Chowdhury @ 2025-07-09 2:55 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: linux-kernel, linux-trace-kernel
On 11:12 Wed 09 Jul 2025, Masami Hiramatsu wrote:
>Hi Bhaskar,
>
>On Tue, 8 Jul 2025 14:46:08 +0530
>Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
>
>> It was showing malformed syntax colors below those lines,escaping the posix
>> class brackets bring back the syntatic reference back.
>>
>> Oh, malformed syntax colors means,(in a editor,in this case Vim, where syntax
>> highlight is on). In essence, it might complain while running the script.
>
>Hmm, that means your editor's parser's bug, right?
>
>>
>> Hence, this trivialities.
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> tools/bootconfig/test-bootconfig.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
>> index a2c484c243f5..211409539737 100755
>> --- a/tools/bootconfig/test-bootconfig.sh
>> +++ b/tools/bootconfig/test-bootconfig.sh
>> @@ -167,8 +167,8 @@ echo > $INITRD
>>
>> xpass $BOOTCONF -a $TEMPCONF $INITRD
>> $BOOTCONF $INITRD > $OUTFILE
>> -xfail grep -q val[[:space:]] $OUTFILE
>> -xpass grep -q val2[[:space:]] $OUTFILE
>> +xfail grep -q val\[\[:space:\]\] $OUTFILE
>> +xpass grep -q val2\[\[:space:\]\] $OUTFILE
>
>Can you escape it by quotations? In that case, it is acceptable
>as a cleanup. e.g. 'val[[:space:]]'.
>
Yup...looks sane with quotation....sending you V2 in a while.
>Thank you,
>
>
>>
>> echo "=== expected failure cases ==="
>> for i in samples/bad-* ; do
>> --
>> 2.49.0
>>
>
>
>--
>Masami Hiramatsu (Google) <mhiramat@kernel.org>
--
Thanks,
Bhaskar
"Here's looking at you kid"-- Casablanca
https://about.me/unixbhaskar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-09 2:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08 9:16 [PATCH] tools: bootconfig: Regex brackets need escape Bhaskar Chowdhury
2025-07-09 2:12 ` Masami Hiramatsu
2025-07-09 2:55 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).