From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kernel test robot <lkp@intel.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
<oe-kbuild-all@lists.linux.dev>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tracing: Remove "__attribute__()" from the type field of event format
Date: Thu, 10 Jul 2025 22:47:11 +0900 [thread overview]
Message-ID: <20250710224711.8c5fd7b4510db3c4e9f5e787@kernel.org> (raw)
In-Reply-To: <20250709125118.3caad8b6@batman.local.home>
On Wed, 9 Jul 2025 12:51:18 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 9 Jul 2025 09:06:10 +0800
> kernel test robot <lkp@intel.com> wrote:
>
> > kernel/trace/trace_events.c: In function 'sanitize_field_type':
> > >> kernel/trace/trace_events.c:120:30: error: initializer element is not constant
> > static const int attr_len = strlen(ATTRIBUTE_STR);
> > ^~~~~~
>
> I guess this could be fixed by making the above:
>
> static const int attr_len = sizeof(ATTRIBUTE_STR) - 1;
OK, let me fix it.
Thanks!
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-07-10 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 11:54 [PATCH 0/2] tracing: Fix an event field filter issue Masami Hiramatsu (Google)
2025-07-08 11:54 ` [PATCH 1/2] tracing: Remove "__attribute__()" from the type field of event format Masami Hiramatsu (Google)
2025-07-09 1:06 ` kernel test robot
2025-07-09 16:51 ` Steven Rostedt
2025-07-10 13:47 ` Masami Hiramatsu [this message]
2025-07-09 17:11 ` Steven Rostedt
2025-07-10 13:45 ` Masami Hiramatsu
2025-07-10 13:53 ` Steven Rostedt
2025-07-11 1:44 ` Masami Hiramatsu
2025-07-11 5:37 ` Masami Hiramatsu
2025-07-11 16:03 ` Steven Rostedt
2025-07-12 11:45 ` Masami Hiramatsu
2025-07-12 14:37 ` Steven Rostedt
2025-07-12 15:13 ` Steven Rostedt
2025-07-14 14:14 ` Masami Hiramatsu
2025-07-14 14:32 ` Steven Rostedt
2025-07-08 11:54 ` [PATCH 2/2] tracing: Allocate field->type only if it needs to be sanitized Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710224711.8c5fd7b4510db3c4e9f5e787@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).