From: Steven Rostedt <rostedt@goodmis.org>
To: "Fusheng Huang(黄富生)" <Fusheng.Huang@luxshare-ict.com>
Cc: "mhiramat@kernel.org" <mhiramat@kernel.org>,
"GuoJin Dai( 戴国金)" <GuoJin.Dai@luxshare-ict.com>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>
Subject: Re: 【ftrace_events list】race between trace_event_eval_update and __register_event discuss
Date: Thu, 17 Jul 2025 10:52:26 -0400 [thread overview]
Message-ID: <20250717105226.1ab19b95@batman.local.home> (raw)
In-Reply-To: <20250717105007.46ccd18f@batman.local.home>
On Thu, 17 Jul 2025 10:50:07 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 120531268abf..f00d3901cd3b 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -3675,10 +3675,12 @@ static void trace_module_add_events(struct module *mod)
> start = mod->trace_events;
> end = mod->trace_events + mod->num_trace_events;
>
> + down_write(&trace_event_sem);
> for_each_event(call, start, end) {
> __register_event(*call, mod);
> __add_event_to_tracers(*call);
> }
> + up_write(&trace_event_sem);
Bah, it appears that this semaphore is taken within these callers. Let
me fix this up properly.
-- Steve
>
> update_cache_events(mod);
> }
next prev parent reply other threads:[~2025-07-17 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3c1259275c784bbd9e2f33e1b2d846c1@luxshare-ict.com>
2025-07-17 14:50 ` 【ftrace_events list】race between trace_event_eval_update and __register_event discuss Steven Rostedt
2025-07-17 14:52 ` Steven Rostedt [this message]
2025-07-17 14:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717105226.1ab19b95@batman.local.home \
--to=rostedt@goodmis.org \
--cc=Fusheng.Huang@luxshare-ict.com \
--cc=GuoJin.Dai@luxshare-ict.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox