From: Nam Cao <namcao@linutronix.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] rv: Ensure containers are registered first
Date: Fri, 18 Jul 2025 12:40:18 +0200 [thread overview]
Message-ID: <20250718104018.lyupqBnR@linutronix.de> (raw)
In-Reply-To: <2025071835-enjoying-darn-f5d8@gregkh>
On Fri, Jul 18, 2025 at 12:27:14PM +0200, Greg KH wrote:
> On Fri, Jul 18, 2025 at 11:18:50AM +0200, Nam Cao wrote:
> > If rv_register_monitor() is called with a non-NULL parent pointer (i.e. by
> > monitors inside a container), it is expected that the parent (a.k.a
> > container) is already registered.
> >
> > The containers seem to always be registered first. I suspect because of the
> > order in Makefile. But nothing guarantees this.
>
> Yes, linking order matters, and it does guarantee this. We rely on
> linking order in the kernel in many places.
Hmm, I thought this is just how the linker happens to behave, but not a
guarantee.
Let's discard this patch then.
Nam
prev parent reply other threads:[~2025-07-18 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:18 [PATCH] rv: Ensure containers are registered first Nam Cao
2025-07-18 9:35 ` Gabriele Monaco
2025-07-18 10:27 ` Greg KH
2025-07-18 10:40 ` Nam Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718104018.lyupqBnR@linutronix.de \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).