From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Steven Rostedt <rostedt@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v5 2/3] tracing: Add a tracepoint verification check at build time
Date: Fri, 25 Jul 2025 09:41:21 -0400 [thread overview]
Message-ID: <20250725094121.1521e14d@gandalf.local.home> (raw)
In-Reply-To: <a1f2f201-61f9-4564-b0c8-45c4d912bd00@efficios.com>
On Fri, 25 Jul 2025 09:15:34 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> > Add a verifier that injects a string of the name of the tracepoint it
> > calls that is added to the discarded section "__tracepoint_check".
> > For every builtin tracepoint, it's
>
> its
Weird Al would be ashamed of me!
Although, you shouldn't delete the word that comes next in your reply, as
I can't tell if you were correct or not from the context you kept.
>
> [...]
>
> > + /*
> > + * The __tracepoint_check section is filled with strings of the
> > + * names of tracepoints (in tracepoint_strings). Create an array
> > + * that points to each string and then sort the array.
> > + */
> > + for_each_shdr_str(len, ehdr, check_data_sec) {
> > + if (!len)
> > + continue;
>
> The len==0 case would be when this skips section alignment padding when
> the linker decides to align the beginning of each .o sections, which
> ends up appearing as zeroed padding within the resulting vmlinux.o
> section after the individual sections have been stitched together, am I
> correct ?
I'm guessing. But when I walked through it in the debugger, there was more
zero length strings than strings with content. But it had all the strings I
was looking for.
-- Steve
next prev parent reply other threads:[~2025-07-25 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 2:51 [PATCH v5 0/3] tracepoints: Add warnings for unused tracepoints and trace events Steven Rostedt
2025-07-25 2:51 ` [PATCH v5 1/3] sorttable: Move ELF parsing into scripts/elf-parse.[ch] Steven Rostedt
2025-07-25 2:51 ` [PATCH v5 2/3] tracing: Add a tracepoint verification check at build time Steven Rostedt
2025-07-25 13:15 ` Mathieu Desnoyers
2025-07-25 13:41 ` Steven Rostedt [this message]
2025-07-25 13:49 ` Steven Rostedt
2025-07-26 10:36 ` kernel test robot
2025-07-25 2:51 ` [PATCH v5 3/3] tracepoint: Do not warn for unused event that is exported Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725094121.1521e14d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=rostedt@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).