From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] tracing: Remove "__attribute__()" from the type field of event format
Date: Tue, 29 Jul 2025 12:33:49 -0400 [thread overview]
Message-ID: <20250729123349.61dbcc92@batman.local.home> (raw)
In-Reply-To: <175376583493.1688759.12333973498014733551.stgit@mhiramat.tok.corp.google.com>
On Tue, 29 Jul 2025 14:10:35 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> static void update_event_fields(struct trace_event_call *call,
> struct trace_eval_map *map)
> {
> struct ftrace_event_field *field;
> + const char *eval_string = NULL;
> struct list_head *head;
> + int len = 0;
> char *ptr;
> char *str;
> - int len = strlen(map->eval_string);
>
> /* Dynamic events should never have field maps */
> - if (WARN_ON_ONCE(call->flags & TRACE_EVENT_FL_DYNAMIC))
> + if (call->flags & TRACE_EVENT_FL_DYNAMIC)
> return;
Is there a reason you removed the WARN_ON_ONCE()?
Even for the attribute, this shouldn't be called by dynamic events. Or
do you know of a case?
-- Steve
next prev parent reply other threads:[~2025-07-29 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 5:10 [PATCH v5 0/1] tracing: Fix an event field filter issue Masami Hiramatsu (Google)
2025-07-29 5:10 ` [PATCH v5 1/1] tracing: Remove "__attribute__()" from the type field of event format Masami Hiramatsu (Google)
2025-07-29 16:33 ` Steven Rostedt [this message]
2025-07-30 0:20 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729123349.61dbcc92@batman.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox