From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Tomas Glozar <tglozar@redhat.com>, Juri Lelli <jlelli@redhat.com>,
Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH v5 7/9] rv: Replace tss and sncid monitors with more complete sts
Date: Wed, 30 Jul 2025 16:44:50 +0200 [thread overview]
Message-ID: <20250730144450.rpfei2in@linutronix.de> (raw)
In-Reply-To: <20250730141643.RD-uucXa@linutronix.de>
On Wed, Jul 30, 2025 at 04:16:46PM +0200, Nam Cao wrote:
> Quite interesting that the last "normal" line for cpu1 is:
>
> test-762 [001] dn... 112.407548: da_event_sts: cant_sched x irq_enable -> can_sched (final)
>
> But in the next error line, it mentions the "enable_to_exit". Where did
> this state come from??
>
> <...>-1621 [001] d.... 119.919846: da_event_sts: rv: monitor sts does not allow event sched_switch on state enable_to_exit
Never mind about this one, only cpu3 is accurate here, because I cut off
the trace_printk() as soon as the first error appears:
diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index 17fa4f6e5ea6..927cf2cda03f 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h
@@ -18,15 +18,22 @@
#ifdef CONFIG_RV_REACTORS
+static bool nam_stop = true;
+
#define DECLARE_RV_REACTING_HELPERS(name, type) \
static void cond_react_##name(type curr_state, type event) \
{ \
if (!rv_reacting_on() || !rv_##name.react) \
return; \
+ nam_stop = true;\
rv_##name.react("rv: monitor %s does not allow event %s on state %s\n", \
#name, \
model_get_event_name_##name(event), \
model_get_state_name_##name(curr_state)); \
+ trace_printk("rv: monitor %s does not allow event %s on state %s\n", \
+ #name, \
+ model_get_event_name_##name(event), \
+ model_get_state_name_##name(curr_state)); \
}
#else /* CONFIG_RV_REACTOR */
@@ -136,6 +143,14 @@ da_event_##name(struct da_monitor *da_mon, enum events_##name event) \
model_get_event_name_##name(event), \
model_get_state_name_##name(next_state), \
model_is_final_state_##name(next_state)); \
+ if (nam_stop)\
+ return true;\
+ trace_printk("%s x %s -> %s%s\n", \
+ model_get_state_name_##name(curr_state), \
+ model_get_event_name_##name(event), \
+ model_get_state_name_##name(next_state), \
+ model_is_final_state_##name(next_state)? \
+ " (final)" : ""); \
return true; \
} \
} \
next prev parent reply other threads:[~2025-07-30 14:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250728135022.255578-1-gmonaco@redhat.com>
2025-07-28 13:50 ` [PATCH v5 1/9] rv: Add da_handle_start_run_event_ to per-task monitors Gabriele Monaco
2025-07-28 13:50 ` [PATCH v5 2/9] rv: Remove trailing whitespace from tracepoint string Gabriele Monaco
2025-07-28 13:50 ` [PATCH v5 3/9] rv: Use strings in da monitors tracepoints Gabriele Monaco
2025-07-28 13:50 ` [PATCH v5 4/9] rv: Adjust monitor dependencies Gabriele Monaco
2025-07-28 13:50 ` [PATCH v5 5/9] rv: Retry when da monitor detects race conditions Gabriele Monaco
2025-07-28 14:18 ` Nam Cao
2025-07-28 13:50 ` [PATCH v5 6/9] sched: Adapt sched tracepoints for RV task model Gabriele Monaco
2025-07-28 16:02 ` Nam Cao
2025-07-28 13:50 ` [PATCH v5 7/9] rv: Replace tss and sncid monitors with more complete sts Gabriele Monaco
2025-07-28 15:53 ` Nam Cao
2025-07-29 8:46 ` Gabriele Monaco
2025-07-29 9:25 ` Nam Cao
2025-07-29 9:37 ` Nam Cao
2025-07-29 14:06 ` Gabriele Monaco
2025-07-30 12:52 ` Nam Cao
2025-07-30 14:16 ` Nam Cao
2025-07-30 14:44 ` Nam Cao [this message]
2025-07-30 15:09 ` Nam Cao
2025-07-30 16:28 ` Nam Cao
2025-07-28 13:50 ` [PATCH v5 8/9] rv: Add nrp and sssw per-task monitors Gabriele Monaco
2025-07-28 15:56 ` Nam Cao
2025-07-28 13:50 ` [PATCH v5 9/9] rv: Add opid per-cpu monitor Gabriele Monaco
2025-07-28 15:58 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730144450.rpfei2in@linutronix.de \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=jkacur@redhat.com \
--cc=jlelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).