From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 560C31990B7 for ; Fri, 8 Aug 2025 04:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754625973; cv=none; b=cqCsWj7rmeCgqGCBeD5arDj3ojEkcOA5HY3QzDPm5r8JzDynip7Dsr62qogEE9CQQhr77NkdhfgxjlG+sVBF33PvjTyFmMlKmMUDNaYkOmuN6bZgbTPOK+CwvaLtSS+KPHQLN5MmbDGDv9p6KhkrL0JBsIrTzAaI09RpSGtqUqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754625973; c=relaxed/simple; bh=hAlHxZgp123abcDlCAe4hLooeK+QSEHWh7S7DenqCZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c3yyl9sN8RdnAm8eSK3WbgyJRdJOIlrauXbGs65JRPq9cWK3zjIlHb4LKypPEwEcEn4lCZjliJq/oMBSu0LdIiYaHkdlJuNwsbj9AI4+2nSifKFJN7iUyl5BdGU0utxb3nSAuqdEMuTehn2A0xsFa+/OzKzyJ7BtZFE8Uf0RrJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vQwBfYHi; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vQwBfYHi" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1754625959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EyRW6+jgu8v2tPvU9GwSnYS/RWU/00H/0M7Q5DWKSUg=; b=vQwBfYHiJhKPtMTdsbcQFLbHjlcTTNXZX/UYRaizB0i1xNz14la31qfAOpRMWtUj27Nx/c qk3ClTDOQ+SY1MpnvJhIH26CDHB12r/2DqfUzpLFYg9Gert2dC9fzrx7lSbP4ma696JATg kOheMuzIXL6DUWd7v8n79d60zknM71s= From: Tao Chen To: rostedt@goodmis.org, bristot@kernel.org, tglozar@redhat.com Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Tao Chen Subject: [RESEND PATCH linux-next 2/2] rtla: Check pkg-config install Date: Fri, 8 Aug 2025 12:05:27 +0800 Message-ID: <20250808040527.2036023-2-chen.dylane@linux.dev> In-Reply-To: <20250808040527.2036023-1-chen.dylane@linux.dev> References: <20250808040527.2036023-1-chen.dylane@linux.dev> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The tool pkg-config used to check libtraceevent and libtracefs, if not installed, it will report the libs not found, even though they have already been installed. Before: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel libtracefs is missing. Please install libtracefs-dev/libtracefs-devel After: Makefile.config:10: *** Error: pkg-config needed by libtraceevent/libtracefs is missing on this system, please install it. Fixes: 01474dc706ca ("tools/rtla: Use tools/build makefiles to build rtla") Signed-off-by: Tao Chen --- tools/tracing/rtla/Makefile.config | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/tracing/rtla/Makefile.config b/tools/tracing/rtla/Makefile.config index 5f2231d8d626..07ff5e8f3006 100644 --- a/tools/tracing/rtla/Makefile.config +++ b/tools/tracing/rtla/Makefile.config @@ -1,10 +1,18 @@ # SPDX-License-Identifier: GPL-2.0-only +include $(srctree)/tools/scripts/utilities.mak + STOP_ERROR := LIBTRACEEVENT_MIN_VERSION = 1.5 LIBTRACEFS_MIN_VERSION = 1.6 +ifndef ($(NO_LIBTRACEEVENT),1) + ifeq ($(call get-executable,$(PKG_CONFIG)),) + $(error Error: $(PKG_CONFIG) needed by libtraceevent/libtracefs is missing on this system, please install it) + endif +endif + define lib_setup $(eval LIB_INCLUDES += $(shell sh -c "$(PKG_CONFIG) --cflags lib$(1)")) $(eval LDFLAGS += $(shell sh -c "$(PKG_CONFIG) --libs-only-L lib$(1)")) -- 2.48.1