From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F2324166F; Thu, 28 Aug 2025 21:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756415875; cv=none; b=dRhmlgmwZ5yHsROhH6kkbSnnor8X1NXYe90ML/R+tzwSaixUF6dZo29a4wEnbcYya0njn9wPPg+lEMwy6C6tX3/hmRKkopFL1S9DHAfGj75deHn1CzvmrHTdlKLEo4yFqfjGcSBHdQtx+OkEbtbGvFnWR1moqdsl48Pxz/EFnhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756415875; c=relaxed/simple; bh=DsWvnwU0agen7P/TzIjwPCjxm648KDDyXYfW50yobXQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EAlX/vAS/roxFGIsGMx7GjGGKNKhAh26kCrLkN3DsEYE2ByPcqdIARVJ+1i8iWfXeJth4o6s7mZYbQNxcpqClj8dsdtnT24O3CmI9f2aaUcdQf6on/3rEfaMwIZDUCh0hntoz81NOyQYT+Z5PuISfP1M1yecryd6UBo54GM9MMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=go7VN8SP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="go7VN8SP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A995C4CEEB; Thu, 28 Aug 2025 21:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756415874; bh=DsWvnwU0agen7P/TzIjwPCjxm648KDDyXYfW50yobXQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=go7VN8SP0EZolIzwXVJtzgtipce2TQyifuynBtMra1UBQxK/rygnw7MXrAMa2xtNu ZUMtUeQvOqz6x9acjyfxMtIWU7Ui/GWKdKNvsY0gPLUgxArVtHAmTwpu8NulRukP/3 07UQ8HP0fK5SZWfSZ7wTpkD1rZkSmsXUi3/P4VwZEKQWnu0swLFsWNPDX6DkDG4Qse bKGM2/MJupgpEfGN0m5v2R4fh+IuayqE1V98dkH8S5mCzwS/DmqYV6O6r4cc2qR3DG 7vPoMjhzqsiY0wfKGrVcMXvPctGKgFSDfrnLiojQ3xXK19Ow05MTi1IPkAM1J3cHdw 4LQopuKGtowtA== Date: Thu, 28 Aug 2025 17:17:48 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, x86@kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Arnaldo Carvalho de Melo , Namhyung Kim , Thomas Gleixner , Andrii Nakryiko , Indu Bhagat , "Jose E. Marchesi" , Beau Belgrave , Jens Remus , Andrew Morton , Florian Weimer , Sam James , Kees Cook , "Carlos O'Donell" Subject: Re: [PATCH v6 5/6] tracing: Show inode and device major:minor in deferred user space stacktrace Message-ID: <20250828171748.07681a63@batman.local.home> In-Reply-To: References: <20250828180300.591225320@kernel.org> <20250828180357.223298134@kernel.org> <20250828161718.77cb6e61@batman.local.home> <20250828164819.51e300ec@batman.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Aug 2025 14:06:39 -0700 Linus Torvalds wrote: > So you can certainly use siphash for hashing, but make sure to not use > the same secret key that the printing does. Right, I just meant to use the same algorithm. The key would be different. > > As to the ID to hash, I actually think a 'struct file *' might be the > best thing to use - that's directly in the vma, no need to follow any > other pointers for it. But that's unique per task, right? What I liked about the f_inode pointer, is that it appears to be shared between tasks. I only want to add a new hash and print the path for a new file. If several tasks are using the same file (which they are with the libraries), then having the hash be the same between tasks would be more efficient. -- Steve