* [PATCH 1/3] cdns2: Remove unused tracepoints
2025-08-29 1:55 [PATCH 0/3] cdns: Remove unused tracepoints Steven Rostedt
@ 2025-08-29 1:55 ` Steven Rostedt
2025-08-29 1:55 ` [PATCH 2/3] cdns3: " Steven Rostedt
2025-08-29 1:55 ` [PATCH 3/3] cdnsp: " Steven Rostedt
2 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2025-08-29 1:55 UTC (permalink / raw)
To: linux-kernel, linux-trace-kernel, linux-usb
Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Peter Chen, Pawel Laszczak, Greg Kroah-Hartman
From: Steven Rostedt <rostedt@goodmis.org>
Tracepoints that are defined take up around 5K each, even if they are not
used. If they are defined and not used, then they waste memory for unused
code. Soon unused tracepoints will cause warnings.
Remove the unused tracepoints of the cdns2 subsystem. They are:
cdns2_ep0_enqueue
cdns2_ep0_set_config
cdns2_ep_queue
cdns2_iso_out_ep_disable
cdns2_lpm
cdns2_mapped_request
cdns2_map_request
cdns2_may_wakeup
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
drivers/usb/gadget/udc/cdns2/cdns2-trace.h | 69 ----------------------
1 file changed, 69 deletions(-)
diff --git a/drivers/usb/gadget/udc/cdns2/cdns2-trace.h b/drivers/usb/gadget/udc/cdns2/cdns2-trace.h
index ade1752956b1..f4df0e2ff853 100644
--- a/drivers/usb/gadget/udc/cdns2/cdns2-trace.h
+++ b/drivers/usb/gadget/udc/cdns2/cdns2-trace.h
@@ -47,16 +47,6 @@ DEFINE_EVENT(cdns2_log_enable_disable, cdns2_pullup,
TP_ARGS(set)
);
-DEFINE_EVENT(cdns2_log_enable_disable, cdns2_lpm,
- TP_PROTO(int set),
- TP_ARGS(set)
-);
-
-DEFINE_EVENT(cdns2_log_enable_disable, cdns2_may_wakeup,
- TP_PROTO(int set),
- TP_ARGS(set)
-);
-
DECLARE_EVENT_CLASS(cdns2_log_simple,
TP_PROTO(char *msg),
TP_ARGS(msg),
@@ -79,11 +69,6 @@ DEFINE_EVENT(cdns2_log_simple, cdns2_ep0_status_stage,
TP_ARGS(msg)
);
-DEFINE_EVENT(cdns2_log_simple, cdns2_ep0_set_config,
- TP_PROTO(char *msg),
- TP_ARGS(msg)
-);
-
DEFINE_EVENT(cdns2_log_simple, cdns2_ep0_setup,
TP_PROTO(char *msg),
TP_ARGS(msg)
@@ -340,11 +325,6 @@ DEFINE_EVENT(cdns2_log_request, cdns2_free_request,
TP_ARGS(preq)
);
-DEFINE_EVENT(cdns2_log_request, cdns2_ep_queue,
- TP_PROTO(struct cdns2_request *preq),
- TP_ARGS(preq)
-);
-
DEFINE_EVENT(cdns2_log_request, cdns2_request_dequeue,
TP_PROTO(struct cdns2_request *preq),
TP_ARGS(preq)
@@ -355,50 +335,6 @@ DEFINE_EVENT(cdns2_log_request, cdns2_request_giveback,
TP_ARGS(preq)
);
-TRACE_EVENT(cdns2_ep0_enqueue,
- TP_PROTO(struct cdns2_device *dev_priv, struct usb_request *request),
- TP_ARGS(dev_priv, request),
- TP_STRUCT__entry(
- __field(int, dir)
- __field(int, length)
- ),
- TP_fast_assign(
- __entry->dir = dev_priv->eps[0].dir;
- __entry->length = request->length;
- ),
- TP_printk("Queue to ep0%s length: %u", __entry->dir ? "in" : "out",
- __entry->length)
-);
-
-DECLARE_EVENT_CLASS(cdns2_log_map_request,
- TP_PROTO(struct cdns2_request *priv_req),
- TP_ARGS(priv_req),
- TP_STRUCT__entry(
- __string(name, priv_req->pep->name)
- __field(struct usb_request *, req)
- __field(void *, buf)
- __field(dma_addr_t, dma)
- ),
- TP_fast_assign(
- __assign_str(name);
- __entry->req = &priv_req->request;
- __entry->buf = priv_req->request.buf;
- __entry->dma = priv_req->request.dma;
- ),
- TP_printk("%s: req: %p, req buf %p, dma %p",
- __get_str(name), __entry->req, __entry->buf, &__entry->dma
- )
-);
-
-DEFINE_EVENT(cdns2_log_map_request, cdns2_map_request,
- TP_PROTO(struct cdns2_request *req),
- TP_ARGS(req)
-);
-DEFINE_EVENT(cdns2_log_map_request, cdns2_mapped_request,
- TP_PROTO(struct cdns2_request *req),
- TP_ARGS(req)
-);
-
DECLARE_EVENT_CLASS(cdns2_log_trb,
TP_PROTO(struct cdns2_endpoint *pep, struct cdns2_trb *trb),
TP_ARGS(pep, trb),
@@ -507,11 +443,6 @@ DEFINE_EVENT(cdns2_log_ep, cdns2_gadget_ep_disable,
TP_ARGS(pep)
);
-DEFINE_EVENT(cdns2_log_ep, cdns2_iso_out_ep_disable,
- TP_PROTO(struct cdns2_endpoint *pep),
- TP_ARGS(pep)
-);
-
DEFINE_EVENT(cdns2_log_ep, cdns2_ep_busy_try_halt_again,
TP_PROTO(struct cdns2_endpoint *pep),
TP_ARGS(pep)
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] cdns3: Remove unused tracepoints
2025-08-29 1:55 [PATCH 0/3] cdns: Remove unused tracepoints Steven Rostedt
2025-08-29 1:55 ` [PATCH 1/3] cdns2: " Steven Rostedt
@ 2025-08-29 1:55 ` Steven Rostedt
2025-09-01 2:32 ` Peter Chen (CIX)
2025-08-29 1:55 ` [PATCH 3/3] cdnsp: " Steven Rostedt
2 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2025-08-29 1:55 UTC (permalink / raw)
To: linux-kernel, linux-trace-kernel, linux-usb
Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Peter Chen, Pawel Laszczak, Greg Kroah-Hartman
From: Steven Rostedt <rostedt@goodmis.org>
Tracepoints that are defined take up around 5K each, even if they are not
used. If they are defined and not used, then they waste memory for unused
code. Soon unused tracepoints will cause warnings.
Remove the unused tracepoints of the cdns3 subsystem. They are:
cdns3_mapped_request
cdns3_map_request
cdns3_stream_transfer_split
cdns3_stream_transfer_split_next_part
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
drivers/usb/cdns3/cdns3-trace.h | 61 ---------------------------------
1 file changed, 61 deletions(-)
diff --git a/drivers/usb/cdns3/cdns3-trace.h b/drivers/usb/cdns3/cdns3-trace.h
index c4e542f1b9b7..21a6a2ce7a3d 100644
--- a/drivers/usb/cdns3/cdns3-trace.h
+++ b/drivers/usb/cdns3/cdns3-trace.h
@@ -283,39 +283,6 @@ TRACE_EVENT(cdns3_ep0_queue,
__entry->length)
);
-DECLARE_EVENT_CLASS(cdns3_stream_split_transfer_len,
- TP_PROTO(struct cdns3_request *req),
- TP_ARGS(req),
- TP_STRUCT__entry(
- __string(name, req->priv_ep->name)
- __field(struct cdns3_request *, req)
- __field(unsigned int, length)
- __field(unsigned int, actual)
- __field(unsigned int, stream_id)
- ),
- TP_fast_assign(
- __assign_str(name);
- __entry->req = req;
- __entry->actual = req->request.length;
- __entry->length = req->request.actual;
- __entry->stream_id = req->request.stream_id;
- ),
- TP_printk("%s: req: %p,request length: %u actual length: %u SID: %u",
- __get_str(name), __entry->req, __entry->length,
- __entry->actual, __entry->stream_id)
-);
-
-DEFINE_EVENT(cdns3_stream_split_transfer_len, cdns3_stream_transfer_split,
- TP_PROTO(struct cdns3_request *req),
- TP_ARGS(req)
-);
-
-DEFINE_EVENT(cdns3_stream_split_transfer_len,
- cdns3_stream_transfer_split_next_part,
- TP_PROTO(struct cdns3_request *req),
- TP_ARGS(req)
-);
-
DECLARE_EVENT_CLASS(cdns3_log_aligned_request,
TP_PROTO(struct cdns3_request *priv_req),
TP_ARGS(priv_req),
@@ -354,34 +321,6 @@ DEFINE_EVENT(cdns3_log_aligned_request, cdns3_prepare_aligned_request,
TP_ARGS(req)
);
-DECLARE_EVENT_CLASS(cdns3_log_map_request,
- TP_PROTO(struct cdns3_request *priv_req),
- TP_ARGS(priv_req),
- TP_STRUCT__entry(
- __string(name, priv_req->priv_ep->name)
- __field(struct usb_request *, req)
- __field(void *, buf)
- __field(dma_addr_t, dma)
- ),
- TP_fast_assign(
- __assign_str(name);
- __entry->req = &priv_req->request;
- __entry->buf = priv_req->request.buf;
- __entry->dma = priv_req->request.dma;
- ),
- TP_printk("%s: req: %p, req buf %p, dma %p",
- __get_str(name), __entry->req, __entry->buf, &__entry->dma
- )
-);
-DEFINE_EVENT(cdns3_log_map_request, cdns3_map_request,
- TP_PROTO(struct cdns3_request *req),
- TP_ARGS(req)
-);
-DEFINE_EVENT(cdns3_log_map_request, cdns3_mapped_request,
- TP_PROTO(struct cdns3_request *req),
- TP_ARGS(req)
-);
-
DECLARE_EVENT_CLASS(cdns3_log_trb,
TP_PROTO(struct cdns3_endpoint *priv_ep, struct cdns3_trb *trb),
TP_ARGS(priv_ep, trb),
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] cdns3: Remove unused tracepoints
2025-08-29 1:55 ` [PATCH 2/3] cdns3: " Steven Rostedt
@ 2025-09-01 2:32 ` Peter Chen (CIX)
0 siblings, 0 replies; 6+ messages in thread
From: Peter Chen (CIX) @ 2025-09-01 2:32 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, linux-trace-kernel, linux-usb, Masami Hiramatsu,
Mark Rutland, Mathieu Desnoyers, Andrew Morton, Pawel Laszczak,
Greg Kroah-Hartman
On 25-08-28 21:55:54, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Tracepoints that are defined take up around 5K each, even if they are not
> used. If they are defined and not used, then they waste memory for unused
> code. Soon unused tracepoints will cause warnings.
>
> Remove the unused tracepoints of the cdns3 subsystem. They are:
> cdns3_mapped_request
> cdns3_map_request
> cdns3_stream_transfer_split
> cdns3_stream_transfer_split_next_part
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/cdns3/cdns3-trace.h | 61 ---------------------------------
> 1 file changed, 61 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-trace.h b/drivers/usb/cdns3/cdns3-trace.h
> index c4e542f1b9b7..21a6a2ce7a3d 100644
> --- a/drivers/usb/cdns3/cdns3-trace.h
> +++ b/drivers/usb/cdns3/cdns3-trace.h
> @@ -283,39 +283,6 @@ TRACE_EVENT(cdns3_ep0_queue,
> __entry->length)
> );
>
> -DECLARE_EVENT_CLASS(cdns3_stream_split_transfer_len,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req),
> - TP_STRUCT__entry(
> - __string(name, req->priv_ep->name)
> - __field(struct cdns3_request *, req)
> - __field(unsigned int, length)
> - __field(unsigned int, actual)
> - __field(unsigned int, stream_id)
> - ),
> - TP_fast_assign(
> - __assign_str(name);
> - __entry->req = req;
> - __entry->actual = req->request.length;
> - __entry->length = req->request.actual;
> - __entry->stream_id = req->request.stream_id;
> - ),
> - TP_printk("%s: req: %p,request length: %u actual length: %u SID: %u",
> - __get_str(name), __entry->req, __entry->length,
> - __entry->actual, __entry->stream_id)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len, cdns3_stream_transfer_split,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len,
> - cdns3_stream_transfer_split_next_part,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> DECLARE_EVENT_CLASS(cdns3_log_aligned_request,
> TP_PROTO(struct cdns3_request *priv_req),
> TP_ARGS(priv_req),
> @@ -354,34 +321,6 @@ DEFINE_EVENT(cdns3_log_aligned_request, cdns3_prepare_aligned_request,
> TP_ARGS(req)
> );
>
> -DECLARE_EVENT_CLASS(cdns3_log_map_request,
> - TP_PROTO(struct cdns3_request *priv_req),
> - TP_ARGS(priv_req),
> - TP_STRUCT__entry(
> - __string(name, priv_req->priv_ep->name)
> - __field(struct usb_request *, req)
> - __field(void *, buf)
> - __field(dma_addr_t, dma)
> - ),
> - TP_fast_assign(
> - __assign_str(name);
> - __entry->req = &priv_req->request;
> - __entry->buf = priv_req->request.buf;
> - __entry->dma = priv_req->request.dma;
> - ),
> - TP_printk("%s: req: %p, req buf %p, dma %p",
> - __get_str(name), __entry->req, __entry->buf, &__entry->dma
> - )
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_map_request,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_mapped_request,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> DECLARE_EVENT_CLASS(cdns3_log_trb,
> TP_PROTO(struct cdns3_endpoint *priv_ep, struct cdns3_trb *trb),
> TP_ARGS(priv_ep, trb),
> --
> 2.50.1
>
>
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] cdnsp: Remove unused tracepoints
2025-08-29 1:55 [PATCH 0/3] cdns: Remove unused tracepoints Steven Rostedt
2025-08-29 1:55 ` [PATCH 1/3] cdns2: " Steven Rostedt
2025-08-29 1:55 ` [PATCH 2/3] cdns3: " Steven Rostedt
@ 2025-08-29 1:55 ` Steven Rostedt
2025-09-01 2:29 ` Peter Chen (CIX)
2 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2025-08-29 1:55 UTC (permalink / raw)
To: linux-kernel, linux-trace-kernel, linux-usb
Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Peter Chen, Pawel Laszczak, Greg Kroah-Hartman
From: Steven Rostedt <rostedt@goodmis.org>
Tracepoints that are defined take up around 5K each, even if they are not
used. If they are defined and not used, then they waste memory for unused
code. Soon unused tracepoints will cause warnings.
Remove the unused tracepoints of the cdnsp subsystem. They are:
cdnsp_defered_event
cdnsp_ep0_halted
cdnsp_free_priv_device
cdnsp_handle_cmd_flush_ep
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
drivers/usb/cdns3/cdnsp-trace.h | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/drivers/usb/cdns3/cdnsp-trace.h b/drivers/usb/cdns3/cdnsp-trace.h
index f2bcf77a5d0a..9b33a736c3de 100644
--- a/drivers/usb/cdns3/cdnsp-trace.h
+++ b/drivers/usb/cdns3/cdnsp-trace.h
@@ -178,11 +178,6 @@ DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_set_config,
TP_ARGS(msg)
);
-DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_halted,
- TP_PROTO(char *msg),
- TP_ARGS(msg)
-);
-
DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep_halt,
TP_PROTO(char *msg),
TP_ARGS(msg)
@@ -399,11 +394,6 @@ DEFINE_EVENT(cdnsp_log_trb, cdnsp_cmd_timeout,
TP_ARGS(ring, trb)
);
-DEFINE_EVENT(cdnsp_log_trb, cdnsp_defered_event,
- TP_PROTO(struct cdnsp_ring *ring, struct cdnsp_generic_trb *trb),
- TP_ARGS(ring, trb)
-);
-
DECLARE_EVENT_CLASS(cdnsp_log_pdev,
TP_PROTO(struct cdnsp_device *pdev),
TP_ARGS(pdev),
@@ -433,16 +423,6 @@ DEFINE_EVENT(cdnsp_log_pdev, cdnsp_alloc_priv_device,
TP_ARGS(vdev)
);
-DEFINE_EVENT(cdnsp_log_pdev, cdnsp_free_priv_device,
- TP_PROTO(struct cdnsp_device *vdev),
- TP_ARGS(vdev)
-);
-
-DEFINE_EVENT(cdnsp_log_pdev, cdnsp_setup_device,
- TP_PROTO(struct cdnsp_device *vdev),
- TP_ARGS(vdev)
-);
-
DEFINE_EVENT(cdnsp_log_pdev, cdnsp_setup_addressable_priv_device,
TP_PROTO(struct cdnsp_device *vdev),
TP_ARGS(vdev)
@@ -575,11 +555,6 @@ DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_stop_ep,
TP_ARGS(ctx)
);
-DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_flush_ep,
- TP_PROTO(struct cdnsp_ep_ctx *ctx),
- TP_ARGS(ctx)
-);
-
DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_set_deq_ep,
TP_PROTO(struct cdnsp_ep_ctx *ctx),
TP_ARGS(ctx)
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] cdnsp: Remove unused tracepoints
2025-08-29 1:55 ` [PATCH 3/3] cdnsp: " Steven Rostedt
@ 2025-09-01 2:29 ` Peter Chen (CIX)
0 siblings, 0 replies; 6+ messages in thread
From: Peter Chen (CIX) @ 2025-09-01 2:29 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, linux-trace-kernel, linux-usb, Masami Hiramatsu,
Mark Rutland, Mathieu Desnoyers, Andrew Morton, Pawel Laszczak,
Greg Kroah-Hartman
On 25-08-28 21:55:55, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Tracepoints that are defined take up around 5K each, even if they are not
> used. If they are defined and not used, then they waste memory for unused
> code. Soon unused tracepoints will cause warnings.
>
> Remove the unused tracepoints of the cdnsp subsystem. They are:
>
> cdnsp_defered_event
> cdnsp_ep0_halted
> cdnsp_free_priv_device
> cdnsp_handle_cmd_flush_ep
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/cdns3/cdnsp-trace.h | 25 -------------------------
> 1 file changed, 25 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-trace.h b/drivers/usb/cdns3/cdnsp-trace.h
> index f2bcf77a5d0a..9b33a736c3de 100644
> --- a/drivers/usb/cdns3/cdnsp-trace.h
> +++ b/drivers/usb/cdns3/cdnsp-trace.h
> @@ -178,11 +178,6 @@ DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_set_config,
> TP_ARGS(msg)
> );
>
> -DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_halted,
> - TP_PROTO(char *msg),
> - TP_ARGS(msg)
> -);
> -
> DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep_halt,
> TP_PROTO(char *msg),
> TP_ARGS(msg)
> @@ -399,11 +394,6 @@ DEFINE_EVENT(cdnsp_log_trb, cdnsp_cmd_timeout,
> TP_ARGS(ring, trb)
> );
>
> -DEFINE_EVENT(cdnsp_log_trb, cdnsp_defered_event,
> - TP_PROTO(struct cdnsp_ring *ring, struct cdnsp_generic_trb *trb),
> - TP_ARGS(ring, trb)
> -);
> -
> DECLARE_EVENT_CLASS(cdnsp_log_pdev,
> TP_PROTO(struct cdnsp_device *pdev),
> TP_ARGS(pdev),
> @@ -433,16 +423,6 @@ DEFINE_EVENT(cdnsp_log_pdev, cdnsp_alloc_priv_device,
> TP_ARGS(vdev)
> );
>
> -DEFINE_EVENT(cdnsp_log_pdev, cdnsp_free_priv_device,
> - TP_PROTO(struct cdnsp_device *vdev),
> - TP_ARGS(vdev)
> -);
> -
> -DEFINE_EVENT(cdnsp_log_pdev, cdnsp_setup_device,
> - TP_PROTO(struct cdnsp_device *vdev),
> - TP_ARGS(vdev)
> -);
> -
> DEFINE_EVENT(cdnsp_log_pdev, cdnsp_setup_addressable_priv_device,
> TP_PROTO(struct cdnsp_device *vdev),
> TP_ARGS(vdev)
> @@ -575,11 +555,6 @@ DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_stop_ep,
> TP_ARGS(ctx)
> );
>
> -DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_flush_ep,
> - TP_PROTO(struct cdnsp_ep_ctx *ctx),
> - TP_ARGS(ctx)
> -);
> -
> DEFINE_EVENT(cdnsp_log_ep_ctx, cdnsp_handle_cmd_set_deq_ep,
> TP_PROTO(struct cdnsp_ep_ctx *ctx),
> TP_ARGS(ctx)
> --
> 2.50.1
>
>
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread