From: "Peter Chen (CIX)" <peter.chen@kernel.org>
To: Steven Rostedt <rostedt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/3] cdns3: Remove unused tracepoints
Date: Mon, 1 Sep 2025 10:32:35 +0800 [thread overview]
Message-ID: <20250901023235.GB2344733@nchen-desktop> (raw)
In-Reply-To: <20250829015650.053498355@kernel.org>
On 25-08-28 21:55:54, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Tracepoints that are defined take up around 5K each, even if they are not
> used. If they are defined and not used, then they waste memory for unused
> code. Soon unused tracepoints will cause warnings.
>
> Remove the unused tracepoints of the cdns3 subsystem. They are:
> cdns3_mapped_request
> cdns3_map_request
> cdns3_stream_transfer_split
> cdns3_stream_transfer_split_next_part
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/cdns3/cdns3-trace.h | 61 ---------------------------------
> 1 file changed, 61 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-trace.h b/drivers/usb/cdns3/cdns3-trace.h
> index c4e542f1b9b7..21a6a2ce7a3d 100644
> --- a/drivers/usb/cdns3/cdns3-trace.h
> +++ b/drivers/usb/cdns3/cdns3-trace.h
> @@ -283,39 +283,6 @@ TRACE_EVENT(cdns3_ep0_queue,
> __entry->length)
> );
>
> -DECLARE_EVENT_CLASS(cdns3_stream_split_transfer_len,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req),
> - TP_STRUCT__entry(
> - __string(name, req->priv_ep->name)
> - __field(struct cdns3_request *, req)
> - __field(unsigned int, length)
> - __field(unsigned int, actual)
> - __field(unsigned int, stream_id)
> - ),
> - TP_fast_assign(
> - __assign_str(name);
> - __entry->req = req;
> - __entry->actual = req->request.length;
> - __entry->length = req->request.actual;
> - __entry->stream_id = req->request.stream_id;
> - ),
> - TP_printk("%s: req: %p,request length: %u actual length: %u SID: %u",
> - __get_str(name), __entry->req, __entry->length,
> - __entry->actual, __entry->stream_id)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len, cdns3_stream_transfer_split,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> -DEFINE_EVENT(cdns3_stream_split_transfer_len,
> - cdns3_stream_transfer_split_next_part,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> DECLARE_EVENT_CLASS(cdns3_log_aligned_request,
> TP_PROTO(struct cdns3_request *priv_req),
> TP_ARGS(priv_req),
> @@ -354,34 +321,6 @@ DEFINE_EVENT(cdns3_log_aligned_request, cdns3_prepare_aligned_request,
> TP_ARGS(req)
> );
>
> -DECLARE_EVENT_CLASS(cdns3_log_map_request,
> - TP_PROTO(struct cdns3_request *priv_req),
> - TP_ARGS(priv_req),
> - TP_STRUCT__entry(
> - __string(name, priv_req->priv_ep->name)
> - __field(struct usb_request *, req)
> - __field(void *, buf)
> - __field(dma_addr_t, dma)
> - ),
> - TP_fast_assign(
> - __assign_str(name);
> - __entry->req = &priv_req->request;
> - __entry->buf = priv_req->request.buf;
> - __entry->dma = priv_req->request.dma;
> - ),
> - TP_printk("%s: req: %p, req buf %p, dma %p",
> - __get_str(name), __entry->req, __entry->buf, &__entry->dma
> - )
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_map_request,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -DEFINE_EVENT(cdns3_log_map_request, cdns3_mapped_request,
> - TP_PROTO(struct cdns3_request *req),
> - TP_ARGS(req)
> -);
> -
> DECLARE_EVENT_CLASS(cdns3_log_trb,
> TP_PROTO(struct cdns3_endpoint *priv_ep, struct cdns3_trb *trb),
> TP_ARGS(priv_ep, trb),
> --
> 2.50.1
>
>
--
Best regards,
Peter
next prev parent reply other threads:[~2025-09-01 2:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 1:55 [PATCH 0/3] cdns: Remove unused tracepoints Steven Rostedt
2025-08-29 1:55 ` [PATCH 1/3] cdns2: " Steven Rostedt
2025-08-29 1:55 ` [PATCH 2/3] cdns3: " Steven Rostedt
2025-09-01 2:32 ` Peter Chen (CIX) [this message]
2025-08-29 1:55 ` [PATCH 3/3] cdnsp: " Steven Rostedt
2025-09-01 2:29 ` Peter Chen (CIX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901023235.GB2344733@nchen-desktop \
--to=peter.chen@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pawell@cadence.com \
--cc=rostedt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox