From: Steven Rostedt <rostedt@goodmis.org>
To: Elijah <me@elijahs.space>
Cc: Elijah Wright <git@elijahs.space>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: move buffer in trace_seq to end of struct
Date: Tue, 2 Sep 2025 16:00:20 -0400 [thread overview]
Message-ID: <20250902160020.5cd24fce@batman.local.home> (raw)
In-Reply-To: <ce062d82-41cb-42c0-b970-1312dbcd1094@elijahs.space>
On Thu, 21 Aug 2025 11:32:17 -0700
Elijah <me@elijahs.space> wrote:
> can we maybe encode the overflow state in seq_buf? check if
> seq_buf_has_overflowed and clamp len back to the used size
> (seq_buf_used) in a helper?
I could add a bit to the size?
diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h
index 52791e070506..ea4996851901 100644
--- a/include/linux/seq_buf.h
+++ b/include/linux/seq_buf.h
@@ -20,8 +20,9 @@
*/
struct seq_buf {
char *buffer;
- size_t size;
- size_t len;
+ unsigned int size;
+ unsigned int len:31;
+ unsigned int full:1;
};
#define DECLARE_SEQ_BUF(NAME, SIZE) \
-- Steve
next prev parent reply other threads:[~2025-09-02 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 5:39 [PATCH] tracing: move buffer in trace_seq to end of struct Elijah Wright
2025-08-21 15:43 ` Steven Rostedt
2025-08-21 15:53 ` Steven Rostedt
2025-08-21 18:32 ` Elijah
2025-09-02 20:00 ` Steven Rostedt [this message]
2025-09-02 20:03 ` Elijah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902160020.5cd24fce@batman.local.home \
--to=rostedt@goodmis.org \
--cc=git@elijahs.space \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=me@elijahs.space \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).