From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFEB827780E; Sat, 6 Sep 2025 12:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757161203; cv=none; b=Kbj19ws+Q5Pg6UV4/uJhwRdXCIRt9JpwYBeijMNWm1bw1j04a84x/admUarSePstApQvB8z5Ie9kJBouq041/KBkIdT/4YEwdDScDV0E2po2imGcLmOutHjT8E8Nkfzs0SuTbrZLk6SmGyGdgEEq19pDJcj8qUeA9APyZk2Mv/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757161203; c=relaxed/simple; bh=BKol4HL6/ZqnDnGKyyGY4AZwj2Kf559stTCHV+WJ3C0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RCppJ2rPuNYavLum+sKjBpK+ff6IkQLxazfJ+gbICjXntiSoeiLhYgwHMjuccrApsfui3GTMkopRSXFHPHLs34OJLLoh60GNfaRv0TSazyvMeAFvVGvIzwQrt8KMAd6m6TY6UoFZdBAL3PKjZPseh1VcbT2Pdx3acjhHtdV857I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xMzXnXPX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xMzXnXPX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B37BBC4CEE7; Sat, 6 Sep 2025 12:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757161203; bh=BKol4HL6/ZqnDnGKyyGY4AZwj2Kf559stTCHV+WJ3C0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xMzXnXPXsnW6iNHHptu6P/KVB3USWJaQnvXka/ambFUDvR3lg6FqZYyOI3r1RNndi u2fv3uRS9bVa1wDwex9kaVS1nRPpJGrYCRulB/ZjnaRPoj/iXM3XTqXoLEI7FdGNf1 0RiQvbmzpAWS+iFI19unGE4ng0138yMmmwnzKQrg= Date: Sat, 6 Sep 2025 14:20:00 +0200 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Mario Limonciello , Danilo Krummrich , Bjorn Helgaas , Pavel Machek , Len Brown , Christian =?iso-8859-1?Q?K=F6nig?= , "James E . J . Bottomley" , "Martin K . Petersen" , Steven Rostedt , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:SCSI SUBSYSTEM" , "open list:USB SUBSYSTEM" , "open list:TRACING" , AceLan Kao , Kai-Heng Feng , Mark Pearson , Merthan =?utf-8?Q?Karaka=C5=9F?= , Eric Naim Subject: Re: [PATCH v6 00/11] Improvements to S5 power consumption Message-ID: <2025090644-connected-coping-fbd2@gregkh> References: <20250818020101.3619237-1-superm1@kernel.org> <29e61472-5f41-4e76-9b5b-f3e106d6a629@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Sep 03, 2025 at 01:14:18PM +0200, Rafael J. Wysocki wrote: > On Wed, Sep 3, 2025 at 6:41 AM Mario Limonciello wrote: > > > > On 8/17/2025 9:00 PM, Mario Limonciello (AMD) wrote: > > > A variety of issues both in function and in power consumption have been > > > raised as a result of devices not being put into a low power state when > > > the system is powered off. > > > > > > There have been some localized changes[1] to PCI core to help these issues, > > > but they have had various downsides. > > > > > > This series instead tries to use the S4 flow when the system is being > > > powered off. This lines up the behavior with what other operating systems > > > do as well. If for some reason that fails or is not supported, run their > > > shutdown() callbacks. > > > > > > Cc: AceLan Kao > > > Cc: Kai-Heng Feng > > > Cc: Mark Pearson > > > Cc: Merthan Karakaş > > > Cc: Eric Naim > > > --- > > > v5->v6: > > > * Fix for LKP robot issue > > > * Some commit message changes > > > * Rebase on 6.17-rc2 > > > > > > Mario Limonciello (AMD) (11): > > > PM: Introduce new PMSG_POWEROFF event > > > scsi: Add PM_EVENT_POWEROFF into suspend callbacks > > > usb: sl811-hcd: Add PM_EVENT_POWEROFF into suspend callbacks > > > USB: Pass PMSG_POWEROFF event to suspend_common() for poweroff with S4 > > > flow > > > PCI: PM: Disable device wakeups when halting system through S4 flow > > > PCI: PM: Split out code from pci_pm_suspend_noirq() into helper > > > PCI: PM: Run bridge power up actions as part of restore phase > > > PCI: PM: Use pci_power_manageable() in pci_pm_poweroff_noirq() > > > PCI: Put PCIe bridges with downstream devices into D3 at hibernate > > > drm/amd: Avoid evicting resources at S5 > > > PM: Use hibernate flows for system power off > > > > > > drivers/base/power/main.c | 7 ++ > > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 + > > > drivers/pci/pci-driver.c | 99 +++++++++++++++------- > > > drivers/scsi/mesh.c | 1 + > > > drivers/scsi/stex.c | 1 + > > > drivers/usb/core/hcd-pci.c | 11 ++- > > > drivers/usb/host/sl811-hcd.c | 1 + > > > include/linux/pm.h | 5 +- > > > include/trace/events/power.h | 3 +- > > > kernel/reboot.c | 6 ++ > > > 10 files changed, 103 insertions(+), 35 deletions(-) > > > > > > > Rafael, Bjorn, > > > > Any feedback for this series? > > I still have the same basic concern as before: It is an intrusive > change likely to cause regressions to occur. > > It also changes the driver ABI quite dramatically because different > callbacks will now be used for system shutdown and kexec, for example, > at least on some platforms. > > Frankly, I'd like to know Greg's and Danilo's opinions on the direction here. > I've been ignoring this, sorry. Can someone resend the series and ask for my review then? thanks, greg k-h