From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, x86@kernel.org,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Hao Luo <haoluo@google.com>, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCHv2 perf/core 2/4] uprobe: Do not emulate/sstep original instruction when ip is changed
Date: Mon, 8 Sep 2025 14:17:21 +0200 [thread overview]
Message-ID: <20250908121721.GB5489@redhat.com> (raw)
In-Reply-To: <20250908121310.46824-3-jolsa@kernel.org>
On 09/08, Jiri Olsa wrote:
>
> If user decided to take execution elsewhere, it makes little sense
> to execute the original instruction, so let's skip it.
...
> @@ -2768,6 +2768,13 @@ static void handle_swbp(struct pt_regs *regs)
> /* Try to optimize after first hit. */
> arch_uprobe_optimize(&uprobe->arch, bp_vaddr);
>
> + /*
> + * If user decided to take execution elsewhere, it makes little sense
> + * to execute the original instruction, so let's skip it.
> + */
> + if (instruction_pointer(regs) != bp_vaddr)
> + goto out;
> +
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2025-09-08 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 12:13 [PATCHv2 perf/core 0/4] uprobe,bpf: Allow to change app registers from uprobe registers Jiri Olsa
2025-09-08 12:13 ` [PATCHv2 perf/core 1/4] bpf: Allow uprobe program to change context registers Jiri Olsa
2025-09-08 17:20 ` Alexei Starovoitov
2025-09-08 19:36 ` Jiri Olsa
2025-09-08 12:13 ` [PATCHv2 perf/core 2/4] uprobe: Do not emulate/sstep original instruction when ip is changed Jiri Olsa
2025-09-08 12:17 ` Oleg Nesterov [this message]
2025-09-08 12:13 ` [PATCHv2 perf/core 3/4] selftests/bpf: Add uprobe context registers changes test Jiri Olsa
2025-09-08 12:13 ` [PATCHv2 perf/core 4/4] selftests/bpf: Add uprobe context ip register change test Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908121721.GB5489@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).