From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9814B3570C1; Tue, 9 Sep 2025 19:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757445419; cv=none; b=a3zGMvp9bJqLLBDvPaZL+f/5dhoNHAKQ7FP82f4pNQpKlqaLdyb6ed8NNsqXlDSvVYpx0eYDHMpM0YxL8cSAzyRIfXEzJkL8sLmk1BV7NDAkFSHP9+/B342NRdS+j6a9U/OwZsFhbCi/R7LlbgnKmeDIgFqXyDtFW1Y7rQC/3vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757445419; c=relaxed/simple; bh=lZO49mOiU9nMXanXitdCGns/iICvFzwUE7jh8Qy4c6w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lJdQJF5xMJlZoPIecJm4O7dYtLlrR/4h+dcPJIY2wgwd1mEREcyEw1+JkeUmQiof9whNEw4IpnnlfqAIS7eS9SPiQhpGMIUWtKtuChFfR/z7HPLrklUbrmsA1H+ODEoXQltoZRLw4Fm9y9Yf0fZgnZdyjFcUR6Qf+8Bz9wqx1B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ctzTcQvD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ctzTcQvD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0016AC4CEFA; Tue, 9 Sep 2025 19:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757445419; bh=lZO49mOiU9nMXanXitdCGns/iICvFzwUE7jh8Qy4c6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ctzTcQvDiZTrnvtyL3xYyiN+0iSd2ISMJZm2IAi9RRwPdHcOv9NU4+76XBDyjUdo4 oPCd8IgPur2XViFXEDiGq05Zjy9msbpyoswNx0n7Sgmx44NZMZi129eB9luscDNUq1 vL3ULQxdiTk6ptjCWa5tA+9bY2KqRjtIH2ALEx6ICnAA1nPdIKvrr42spCNigpYeSi bQcdpCXxnO57cyRU6xwO6YFFABnFLI/GNcIRvOwygnOnHAy9XGYaecgqIOR8McZq/D Fszlw7I6VTEoltIdgxAhq+RlBkilbPBOHwPBn0SmdCL1Pj4jvDf6zTG/tT7nS5Ud2k cfYM1Fu5qrOMA== From: "Mario Limonciello (AMD)" To: "Rafael J . Wysocki" , Greg Kroah-Hartman , Danilo Krummrich , Bjorn Helgaas Cc: Pavel Machek , Len Brown , =?UTF-8?q?Christian=20K=C3=B6nig?= , "James E . J . Bottomley" , "Martin K . Petersen" , Steven Rostedt , linux-pm@vger.kernel.org (open list:HIBERNATION (aka Software Suspend, aka swsusp)), amd-gfx@lists.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM), linux-usb@vger.kernel.org (open list:USB SUBSYSTEM), linux-trace-kernel@vger.kernel.org (open list:TRACING), AceLan Kao , Kai-Heng Feng , Mark Pearson , =?UTF-8?q?Merthan=20Karaka=C5=9F?= , Eric Naim , "Guilherme G . Piccoli" , "Mario Limonciello (AMD)" , Denis Benato , Alex Deucher Subject: [PATCH v7 10/12] drm/amd: Avoid evicting resources at S5 Date: Tue, 9 Sep 2025 14:16:17 -0500 Message-ID: <20250909191619.2580169-11-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909191619.2580169-1-superm1@kernel.org> References: <20250909191619.2580169-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Normally resources are evicted on dGPUs at suspend or hibernate and on APUs at hibernate. These steps are unnecessary when using the S4 callbacks to put the system into S5. Cc: AceLan Kao Cc: Kai-Heng Feng Cc: Mark Pearson Cc: Denis Benato Cc: Merthan Karakaş Tested-by: Eric Naim Acked-by: Alex Deucher Signed-off-by: Mario Limonciello (AMD) --- v5: * No changes v4: * Add A-b tag for Alex * https://lore.kernel.org/linux-pci/20250616175019.3471583-1-superm1@kernel.org/ --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f9b4c4321f67c..4e4b7a63cc61e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -5017,6 +5017,10 @@ static int amdgpu_device_evict_resources(struct amdgpu_device *adev) if (!adev->in_s4 && (adev->flags & AMD_IS_APU)) return 0; + /* No need to evict when going to S5 through S4 callbacks */ + if (system_state == SYSTEM_HALT || system_state == SYSTEM_POWER_OFF) + return 0; + ret = amdgpu_ttm_evict_resources(adev, TTM_PL_VRAM); if (ret) { dev_warn(adev->dev, "evicting device resources failed\n"); -- 2.43.0