From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA552EC54C for ; Fri, 12 Sep 2025 10:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757671985; cv=none; b=H7Hsc0C/iFMhQ35D0jh6YY2q2ammj7SDIKloB+PSV5q9gkZvlmjjsH7k8k3CcB8Ors7+R2c/SbHWWn1w1e+z4zKThCGhGICYA4ucFj1fOcFDmYGqFB/kzzrxAjdMLycsEwlWz030bcrScPc4zrzlTZHlqqTzmKrPgfcCtUS9EEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757671985; c=relaxed/simple; bh=jd25GVZ1dwCG1KSIktqN4mRE3G30pXiK/2KO15zxh2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SfJojyXoCFPiXQZvJmDVzMgugcEDDajqM4Tc3xbLe1BBYt9z2erdKyfwI2hcLWOGxmGf+iIFfiXljsH2EqZz3iWMkd0F/exDzjUkGvVn1CzlIr5SEg83ruTDaq9zULEB9NkPtgCvyak/W2td/cs7BiELsW3gR40j6VeKPUKSDlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WERqiH6k; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WERqiH6k" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-772843b6057so1578578b3a.3 for ; Fri, 12 Sep 2025 03:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757671982; x=1758276782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Mx/ZUXbIMqKSHkTbty4rSJVQCBlfpfdQjz++MJLD94=; b=WERqiH6khVeaVy1OFHPzwoz3BZIOEB+P5oO7X+q62g7/LtUeW+aZGaL0GXHvz6lmuG oK3pZdsxtjG//c/pMvnrn/TAGsde+zmhJNrPjrprgothXziEyxzntaVfirUGLjdtrVZa Ctmy5Qi817FxRFhf81WOuhE63EfVvrKpYtMQFVw2kwuA+TAmdsrJuiXrVGrhX8I0KP0y DU0YgXHTzzSLM5L7BsE23HyOyB5hh1cGpTs27xi5SKrLCFiQ3VybG7gfHSIk176Gwlg7 eDMxN5OOfyMSdZBf9J6djK3YHysWShdJ5dm8jet1rkmnjNP4mfivuqQtYn2J7qagY/sp JA2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757671982; x=1758276782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Mx/ZUXbIMqKSHkTbty4rSJVQCBlfpfdQjz++MJLD94=; b=XNL9XnayYELD1S3PQFbNsOiw7euUT9VTlOSvaPuAqqoKED7Qpiz4Tt4zx4XMB8mAiR mVCfYVmTzVVy9oIqlRIwqJAhnA8Ou82vruLz1y+WVg2t0TWtJYY2Rra4c+q0YyhPUdiC b4tCcZtKavpnYmSOz897CpgYrQFHGREibEnOS5P/SQYa6Xzm8/6yT8ykTLsuX1deisXe korL6eb7b7t75DFeXlK750EAR+cSJ4MmEJ6LGvisNXgIb7ldPOxp7jvn5H8P5EYEb2dE oJBfj1mLt9QBh76UV6UnebJygHHlWlF/l00rUI0GhqrPlBgzi3QjlbyAaU5L9+F2Qjno THAA== X-Forwarded-Encrypted: i=1; AJvYcCWlJ6B/r1xgMmiTdvlwNLWUOsWn3uR2lUIvHT5X2UjW5+xdlEoXCe6u35wvtEyxIK1qw9FN5xst8RSSEuDOEIoa6sA=@vger.kernel.org X-Gm-Message-State: AOJu0YzWx8+qtMy9hTWdF6NyPt43eDzwAsad8FeL/9BR+C01GVcyVVd2 Y6uQtZ3GfuLzsjV/Y2zGYc1hfhy/pCOydfRmqVVbhHIyOip+4vXFtJ+G X-Gm-Gg: ASbGncvqeTIyyxJ91iyYL4sb+TOh/22T26QzpRUUWdfsEW7jQ2B32ZIVJ/nlgkK9u+o ibB1OEMnYBu8tnc9Ll+fIJ5UUBlFTfTF0PCgVEMXaE6ly1bAMiX8K0yw8junTRLrXH4TzodhQwY X1fMAlgLa6QrTdxnxkqkSfMOQVxdLiEF8CZ1fBASCBVYtqW0D5yTZf8aDEVW5s46CeN07ju9mf2 q31mqSjamGhyeFX493nZp9Lm6IxO9WMe4vhWqz2uL+M80pVG0hEI/BGTzX7hYYqn/0T/Fy6e8uD lyiTEPa5r0a0+IKTYjtLqh1hPq+dCioo7Ym/OcxNqt1DHnjheQDrcFJoTD8uwCWSRcpvKv6ajfG oT5VPzkUkyS3aTCBP2QdE8r2CP++mi8yNsQg/4ChCRldJt+L8Eg== X-Google-Smtp-Source: AGHT+IE+4u/LnZqfy4mSwj4sJkJVx6sl0nYi/VrPz9wqHW9cd8FRDoTWUsuOoKihHmm7ZzWEk3p2jA== X-Received: by 2002:a17:902:cecf:b0:251:493c:43e9 with SMTP id d9443c01a7336-25d243e79cdmr29426295ad.3.1757671982485; Fri, 12 Sep 2025 03:13:02 -0700 (PDT) Received: from localhost ([185.49.34.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25c37295f9dsm44540355ad.55.2025.09.12.03.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 03:13:01 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v4 13/21] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Fri, 12 Sep 2025 18:11:23 +0800 Message-ID: <20250912101145.465708-14-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250912101145.465708-1-wangjinchao600@gmail.com> References: <20250912101145.465708-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow dynamic enabling/disabling of kstackwatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 55 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 8e1dca45003e..9ef969f28e29 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -17,6 +17,43 @@ MODULE_LICENSE("GPL"); static struct ksw_config *ksw_config; static atomic_t config_file_busy = ATOMIC_INIT(0); +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret = ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret = ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active = true; + + pr_info("start watching: %s\n", ksw_config->config_str); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active = false; + + pr_info("stop watching: %s\n", ksw_config->config_str); +} + /* * Format of the configuration string: * function+ip_offset[+depth] [local_var_offset:local_var_len] @@ -109,6 +146,9 @@ static ssize_t kstackwatch_proc_write(struct file *file, if (copy_from_user(input, buffer, count)) return -EFAULT; + if (watching_active) + ksw_stop_watching(); + input[count] = '\0'; strim(input); @@ -123,12 +163,22 @@ static ssize_t kstackwatch_proc_write(struct file *file, return ret; } + ret = ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } static int kstackwatch_proc_show(struct seq_file *m, void *v) { - seq_printf(m, "%s\n", ksw_config->config_str); + if (watching_active) + seq_printf(m, "%s\n", ksw_config->config_str); + else + seq_puts(m, "not watching\n"); + return 0; } @@ -176,6 +226,9 @@ static int __init kstackwatch_init(void) static void __exit kstackwatch_exit(void) { + if (watching_active) + ksw_stop_watching(); + remove_proc_entry("kstackwatch", NULL); kfree(ksw_config); -- 2.43.0