From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-btrace@vger.kernel.org,
John Garry <john.g.garry@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Damien Le Moal <dlemoal@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 01/16] blktrace: split do_blk_trace_setup into two functions
Date: Fri, 19 Sep 2025 17:06:12 +0200 [thread overview]
Message-ID: <20250919150612.GA28352@lst.de> (raw)
In-Reply-To: <20250909110611.75559-2-johannes.thumshirn@wdc.com>
On Tue, Sep 09, 2025 at 01:05:56PM +0200, Johannes Thumshirn wrote:
> Split do_blk_trace_setup into two functions, this is done to prepare for
> an incoming new BLKTRACESETUP2 ioctl(2) which can receive extended
> parameters form user-space.
This not just splits the function, but also moves some of the logic
to the caller. Which looks fine, but should be documented here or
even better split out into a separate patch.
next prev parent reply other threads:[~2025-09-19 15:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 11:05 [PATCH 00/16] block: add blktrace support for zoned block device commands Johannes Thumshirn
2025-09-09 11:05 ` [PATCH 01/16] blktrace: split do_blk_trace_setup into two functions Johannes Thumshirn
2025-09-19 15:06 ` Christoph Hellwig [this message]
2025-09-09 11:05 ` [PATCH 02/16] blktrace: add definitions for blk_user_trace_setup2 Johannes Thumshirn
2025-09-19 15:07 ` Christoph Hellwig
2025-09-09 11:05 ` [PATCH 03/16] blktrace: pass blk_user_trace2 to setup functions Johannes Thumshirn
2025-09-19 15:07 ` Christoph Hellwig
2025-09-09 11:05 ` [PATCH 04/16] blktrace: add definitions for struct blk_io_trace2 Johannes Thumshirn
2025-09-19 15:08 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 05/16] blktrace: factor out recording a blktrace event Johannes Thumshirn
2025-09-19 15:09 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 06/16] blktrace: only calculate trace length once Johannes Thumshirn
2025-09-19 15:09 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 07/16] blktrace: split out relaying a blktrace event Johannes Thumshirn
2025-09-19 15:10 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 08/16] blktrace: change the internal action to 64bit Johannes Thumshirn
2025-09-19 15:10 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 09/16] blktrace: remove struct blk_io_trace from __blk_add_trace Johannes Thumshirn
2025-09-19 15:11 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 10/16] blktrace: differentiate between blk_io_trace versions Johannes Thumshirn
2025-09-19 15:12 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 11/16] blktrace: untangle if/else sequence in __blk_add_trace Johannes Thumshirn
2025-09-19 15:12 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 12/16] blktrace: add block trace commands for zone operations Johannes Thumshirn
2025-09-19 15:13 ` Christoph Hellwig
2025-09-09 11:06 ` [PATCH 13/16] blktrace: expose ZONE APPEND completions to blktrace Johannes Thumshirn
2025-09-09 11:06 ` [PATCH 14/16] blktrace: trace zone management operations Johannes Thumshirn
2025-09-09 11:06 ` [PATCH 15/16] blktrace: trace zone write plugging operations Johannes Thumshirn
2025-09-09 11:06 ` [PATCH 16/16] blktrace: handle BLKTRACESETUP2 ioctl Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919150612.GA28352@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=rostedt@goodmis.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).