Re: [PATCH] tracing: Add an option to show symbols in _text+offset for function profiler

[Masami Hiramatsu (Google) <mhiramat@kernel.org>]

On Sat, 20 Sep 2025 01:09:42 +0800
kernel test robot <lkp@intel.com> wrote:

> Hi Masami,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on trace/for-next]
> [also build test ERROR on linus/master v6.17-rc6 next-20250918]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Masami-Hiramatsu-Google/tracing-Add-an-option-to-show-symbols-in-_text-offset-for-function-profiler/20250919-135733
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
> patch link:    https://lore.kernel.org/r/175826135058.101165.7219957344129610147.stgit%40devnote2
> patch subject: [PATCH] tracing: Add an option to show symbols in _text+offset for function profiler
> config: arc-randconfig-001-20250919 (https://download.01.org/0day-ci/archive/20250920/202509200025.UH0WU2Qw-lkp@intel.com/config)
> compiler: arc-linux-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250920/202509200025.UH0WU2Qw-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509200025.UH0WU2Qw-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/trace/trace.c: In function 'create_trace_options_dir':
> >> kernel/trace/trace.c:526:16: error: 'TRACE_ITER_PROF_TEXT_OFFSET' undeclared (first use in this function); did you mean 'TRACE_ITER_CONTEXT_INFO'?
>      526 |                TRACE_ITER_PROF_TEXT_OFFSET)
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Aah, it should be defined always. OK, let me fix that in the next version.

Thanks!


>    kernel/trace/trace.c:9316:34: note: in expansion of macro 'TOP_LEVEL_TRACE_FLAGS'
>     9316 |                     !((1 << i) & TOP_LEVEL_TRACE_FLAGS))
>          |                                  ^~~~~~~~~~~~~~~~~~~~~
>    kernel/trace/trace.c:526:16: note: each undeclared identifier is reported only once for each function it appears in
>      526 |                TRACE_ITER_PROF_TEXT_OFFSET)
>          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/trace/trace.c:9316:34: note: in expansion of macro 'TOP_LEVEL_TRACE_FLAGS'
>     9316 |                     !((1 << i) & TOP_LEVEL_TRACE_FLAGS))
>          |                                  ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +526 kernel/trace/trace.c
> 
>    512	
>    513	/* trace_flags holds trace_options default values */
>    514	#define TRACE_DEFAULT_FLAGS						\
>    515		(FUNCTION_DEFAULT_FLAGS |					\
>    516		 TRACE_ITER_PRINT_PARENT | TRACE_ITER_PRINTK |			\
>    517		 TRACE_ITER_ANNOTATE | TRACE_ITER_CONTEXT_INFO |		\
>    518		 TRACE_ITER_RECORD_CMD | TRACE_ITER_OVERWRITE |			\
>    519		 TRACE_ITER_IRQ_INFO | TRACE_ITER_MARKERS |			\
>    520		 TRACE_ITER_HASH_PTR | TRACE_ITER_TRACE_PRINTK |		\
>    521		 TRACE_ITER_COPY_MARKER)
>    522	
>    523	/* trace_options that are only supported by global_trace */
>    524	#define TOP_LEVEL_TRACE_FLAGS (TRACE_ITER_PRINTK |			\
>    525		       TRACE_ITER_PRINTK_MSGONLY | TRACE_ITER_RECORD_CMD |	\
>  > 526		       TRACE_ITER_PROF_TEXT_OFFSET)
>    527	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>