From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A792FE052 for ; Wed, 24 Sep 2025 11:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714701; cv=none; b=kspRyXYY0OyIT7m0x5e8JZmD2jWp/eX93TM/8HnpUAhTdnxrpBmT8p+pKSJ23BVquevsEm+ZkA9UPrRrZ08nt8I1a1JXNo56eaaL0ZYmRC/qRmIfL2ZxbAe9LJZsItSC2L/zs8gBnG5Ufvfk7c5yV10TCLOZSLow7bifJk703+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714701; c=relaxed/simple; bh=UNpz5dM5lO613H1u9Fi56G2SPcRkZnRAbeW6JwAQp0c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=XKa2z0B4sy1D7F3R90KHA7v9iGi5hnweHYN+mkUk01759DUtoMHR1eoghV79W36rHWDEgBvzy17K9znvJpMZJURgFsXZmk7zqiGs7eyigveB3iMnyhMwDK7eUhQpEcFCkygD2aV91WDV2HCia0UCYNscfu8F99AL3m1KmYJ7YW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a4BRMNAs; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a4BRMNAs" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b550eff972eso4115168a12.3 for ; Wed, 24 Sep 2025 04:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758714695; x=1759319495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IkFW7ZSlDKq/LZM+zK73rBzgP1/UKF25L/8hqnEAXa4=; b=a4BRMNAsTgPxtWvDIPNjcePbjTSV+ugRmo3bT/A/d71rW21LlCG/XHsARlUQiyPzCZ S4E6u0gzhf/4PhTAr1wlW1G5nxwqUyuu35syW3Zq45No/IofeyuG+MqAe5oa/KwuFAku eoK85P/voqtTHBonAs3823vN36KtFthWQIpPraXD5bjK8mJ9jh9pqqIVqdBhnAxqmVzb qfeGNch+u3CEB/wxow/2/nTKNVZ0douMYsaB5MzuaIkzQ3/HJf/15+yFgZtTqGOaNmMq giv3+sTXBUW8/bSSQwNRMqWcYcNWHh3xAYW9tTSMc6XjdXMVCDTatXNKVYUC2fOGbVyl bBJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758714695; x=1759319495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IkFW7ZSlDKq/LZM+zK73rBzgP1/UKF25L/8hqnEAXa4=; b=DWNjZIBC+W2n4A2ar4WlNfi03uM2WUqSsnmyjsV0+kkG5XxjrN6IsLD7A9nLQATBZZ uqlPEXwH0slWcR95TFqY/gXMDku5bQvTjHG4s5kVQdTdI2l+m0cOI+LX7s3CsqaH0j1U FNvSFULlwEVXinK/+oS0c/bTg7kiSSseR1kFF5Mhc8onsGWtJEsEkExdOa0bHoOSOHrZ 2hYawB/3eofPcBEkEV87/2ZSVmnSQCQ1VKNK5x8RFtKRRcYY36VRgcURjrYiEYN5+My4 7RtZudSKDfg9cT+NRo5io8qB2+d2ExF3xxFj86/733qRhtVYRZzDI5F4TPd3/A4qt0Vb g9qQ== X-Forwarded-Encrypted: i=1; AJvYcCX3VDES7wuNYbc/Rlb3HESqRpphxGfoC8I3HJG7u+mwymNvk/8P2QK9ZFodWUEBU0h8atTjKa/VY4Vlkad23nZq1+s=@vger.kernel.org X-Gm-Message-State: AOJu0YycbB7ynwMt4EHB8M4gvNjPpEKvmhMQk8oZoslRnDRILvY9Fv3o JSsN4CgPJbnuJ1sbXWcciY4moX7/B3T+zbAk1LWk+YpZPgu3/fOMAq9R X-Gm-Gg: ASbGncuNJxp2J5Heu/xLx5jt8NRCzo5U9UuWESngcqfZAKr37j+mI+TxWaQpGopKCF+ ws/vhmoaESE4kVwyj1m1ynzuKr0hxpdKnfjazS6DC8qNQNU9EOnrLiXEkI//GyMsxjavX/MZ8ek +YMJ1Qt6WI3LV2+s9HCSc2/vIWZZY3MScVnDhsouSBXlWIB6yfGGhNUj5D4bMvdFOGttszl66WN VFuFDfVqFl0RBTeoEbZik6EneKQy/O6k5AsFJ7VwwL5JLKy8v88nub/F6gi++BbySvxuuS991FC QiI4RLjmWutfeEeQFvUI5CdfBjpMylREgmId0o+pUrgh7AQ8RI08NTUKsEJt9+ShiLk1OrhJZJd KMiwODc6seHA78HTqWHklIbq5Ag== X-Google-Smtp-Source: AGHT+IFpw5g/nyg0mjoFnafm0OORRDCd2mc5ondqV3KNE7Z5tP/VaQRZBOA+j3BmtPgUBBTfxZ4Mhg== X-Received: by 2002:a17:903:3586:b0:240:9dd8:219b with SMTP id d9443c01a7336-27cc61bd32dmr78200575ad.49.1758714694622; Wed, 24 Sep 2025 04:51:34 -0700 (PDT) Received: from localhost ([23.142.224.65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-269802fe096sm189570425ad.104.2025.09.24.04.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 04:51:34 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v5 00/23] mm/ksw: Introduce real-time KStackWatch debugging tool Date: Wed, 24 Sep 2025 19:50:43 +0800 Message-ID: <20250924115124.194940-1-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch series introduces KStackWatch, a lightweight debugging tool to detect kernel stack corruption in real time. It installs a hardware breakpoint (watchpoint) at a function's specified offset using `kprobe.post_handler` and removes it in `fprobe.exit_handler`. This covers the full execution window and reports corruption immediately with time, location, and a call stack. The motivation comes from scenarios where corruption occurs silently in one function but manifests later in another, without a direct call trace linking the two. Such bugs are often extremely hard to debug with existing tools. These scenarios are demonstrated in test 3–5 (silent corruption test, patch 20). Key features include: * Immediate and precise corruption detection * Support multiple watchpoints for concurrently called functions * Lockless design, usable in any context * Depth filter for recursive calls * Minimal impact on reproducibility * Flexible procfs configuration with key=val syntax To validate the approach, the patch includes a test module and a test script. There is a workflow example described in detail in the documentation (patch 22). Please read the document first if you want an overview. --- Patches 1–3 of this series are also used in the wprobe work proposed by Masami Hiramatsu, so there may be some overlap between our patches. Patch 3 comes directly from Masami Hiramatsu (thanks). --- Changelog V5: * Support key=value input format * Support multiple watchpoints * Support watching instruction inside loop * Support recursion depth tracking with generation * Ignore triggers from fprobe trampoline * Split watch_on into watch_get and watch_on to fail fast * Handle ksw_stack_prepare_watch error * Rewrite silent corruption test * Add multiple watchpoints test * Add an example in documentation V4: https://lore.kernel.org/all/20250912101145.465708-1-wangjinchao600@gmail.com/ * Solve the lockdep issues with: * per-task KStackWatch context to track depth * atomic flag to protect watched_addr * Use refactored version of arch_reinstall_hw_breakpoint V3: https://lore.kernel.org/all/20250910052335.1151048-1-wangjinchao600@gmail.com/ * Use modify_wide_hw_breakpoint_local() (from Masami) * Add atomic flag to restrict /proc/kstackwatch to a single opener * Protect stack probe with an atomic PID flag * Handle CPU hotplug for watchpoints * Add preempt_disable/enable in ksw_watch_on_local_cpu() * Introduce const struct ksw_config *ksw_get_config(void) and use it * Switch to global watch_attr, remove struct watch_info * Validate local_var_len in parser() * Handle case when canary is not found * Use dump_stack() instead of show_regs() to allow module build * Reduce logging and comments * Format logs with KBUILD_MODNAME * Remove unused headers * Add new document V2: https://lore.kernel.org/all/20250904002126.1514566-1-wangjinchao600@gmail.com/ * Make hardware breakpoint and stack operations architecture-independent. V1: https://lore.kernel.org/all/20250828073311.1116593-1-wangjinchao600@gmail.com/ * Replaced kretprobe with fprobe for function exit hooking, as suggested by Masami Hiramatsu * Introduced per-task depth logic to track recursion across scheduling * Removed the use of workqueue for a more efficient corruption check * Reordered patches for better logical flow * Simplified and improved commit messages throughout the series * Removed initial archcheck which should be improved later * Replaced the multiple-thread test with silent corruption test * Split self-tests into a separate patch to improve clarity. * Added a new entry for KStackWatch to the MAINTAINERS file. RFC: https://lore.kernel.org/lkml/20250818122720.434981-1-wangjinchao600@gmail.com/ --- The series is structured as follows: Jinchao Wang (22): x86/hw_breakpoint: Unify breakpoint install/uninstall x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint mm/ksw: add build system support mm/ksw: add ksw_config struct and parser mm/ksw: add singleton /proc/kstackwatch interface mm/ksw: add HWBP pre-allocation mm/ksw: Add atomic watchpoint management api mm/ksw: ignore false positives from exit trampolines mm/ksw: support CPU hotplug sched: add per-task context mm/ksw: add entry kprobe and exit fprobe management mm/ksw: add per-task ctx tracking mm/ksw: resolve stack watch addr and len mm/ksw: manage probe and HWBP lifecycle via procfs mm/ksw: add self-debug helpers mm/ksw: add test module mm/ksw: add stack overflow test mm/ksw: add recursive depth test mm/ksw: add multi-thread corruption test cases tools/ksw: add test script docs: add KStackWatch document MAINTAINERS: add entry for KStackWatch Masami Hiramatsu (Google) (1): HWBP: Add modify_wide_hw_breakpoint_local() API Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kstackwatch.rst | 316 ++++++++++++++++++++++ MAINTAINERS | 8 + arch/Kconfig | 10 + arch/x86/Kconfig | 1 + arch/x86/include/asm/hw_breakpoint.h | 8 + arch/x86/kernel/hw_breakpoint.c | 148 ++++++----- include/linux/hw_breakpoint.h | 6 + include/linux/kstackwatch_types.h | 14 + include/linux/sched.h | 5 + kernel/events/hw_breakpoint.c | 37 +++ mm/Kconfig.debug | 18 ++ mm/Makefile | 1 + mm/kstackwatch/Makefile | 8 + mm/kstackwatch/kernel.c | 263 +++++++++++++++++++ mm/kstackwatch/kstackwatch.h | 58 +++++ mm/kstackwatch/stack.c | 240 +++++++++++++++++ mm/kstackwatch/test.c | 332 ++++++++++++++++++++++++ mm/kstackwatch/watch.c | 305 ++++++++++++++++++++++ tools/kstackwatch/kstackwatch_test.sh | 52 ++++ 20 files changed, 1769 insertions(+), 62 deletions(-) create mode 100644 Documentation/dev-tools/kstackwatch.rst create mode 100644 include/linux/kstackwatch_types.h create mode 100644 mm/kstackwatch/Makefile create mode 100644 mm/kstackwatch/kernel.c create mode 100644 mm/kstackwatch/kstackwatch.h create mode 100644 mm/kstackwatch/stack.c create mode 100644 mm/kstackwatch/test.c create mode 100644 mm/kstackwatch/watch.c create mode 100755 tools/kstackwatch/kstackwatch_test.sh -- 2.43.0