From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A8A308F27 for ; Wed, 24 Sep 2025 11:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714757; cv=none; b=MnqXrDI2hSJgdvlOJNYbl6mv/ATCBFX3ICQWIY5uGQHW4HP5YzjTmH75APSVd8Msaacj/sJRdDQBqpoDy1my4+dNzrrbbwo0xESOKsidoxdRUsIZhQH3+O7Nb5b8G71o+1vXNhDX3+nwHCiRKEOuhwFZtgtMNnH+3zA8caewryo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714757; c=relaxed/simple; bh=iAqT9ehP+7na6p9OmCJ4sZ82YPBCnKZ9ZITAqnPBA1U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IQvSSIFd1+o0p+onTadFXvQampS6N1A2Xdoj2ph+zuZRvbNq1BTi54tepLZZbc4HW38l6vJVeQpASZ5B0NfCJJzj9TyCRoEJ3WhQD4KZDPT0y+YtycbRyOQ9xAKARfRSbFcldRSjBdXRCj659AgirS1OmWJ8dMAzYYUlchI5OpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MHTYa/k+; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MHTYa/k+" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3306d93e562so6010375a91.1 for ; Wed, 24 Sep 2025 04:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758714750; x=1759319550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=MHTYa/k+6ECs357AhrvtLv3+d+73xCHlewJANdPDeVVBs4baqSQks4VcCRT3od2KlD TGstrAuMWBc3jmmoZFx+oae35ZAvAYvywhAtWk2ZbtXMVzz47auOqwqvix62PsKZ5HDB 36hB/dC9CSViXW+tHKbePe2QIXG4dOi9JiVZHJz9MWiaHSfgRFPGEcCDVSXoiXS71Byt r6tXUrrdi1JcuS+HfNnQjpWww13adXmfdXFef4q0uSE58I3Y/7SFYC6nzS6TZRqHcj3M kN3ZI6v9QgwY2aUnn4LLb4CoIyCcZIaiHzajCEybkKvMhUz+XWRcCQoiYetvmzfu6JcM 4uzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758714750; x=1759319550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CDvSRov2FamkqE0fpRbb1mATCdcadu0+ybcKu6XxB6c=; b=WeYMexyHs2SD6tUZuIpEANrLDzQH7At6a3gnll0oHDzVtoNsxGYe9toNBa4QrBOdWE 4FZvcXzp+nEwGV9OcetEITSyKCgmjK5Eoee8I3PGcDDRY/HEYHadlspno3+YfZcpU+aN 6pSaRa/1kaOgsGlGnj8VYzSdqi723+jUECoSDwkxFNjGc9a6o0k2GDo3n9hO7Sd4jfEE kJUyALm5DJrdlUY1bMMqHNq8foFdxXTBKFSSN3a8taHwY2l9nN4pKV7KAwHbZHBQDyh0 MpjjBefReST3nl4x0nsKaJGLKbwSbku58V6y8Lp9vlVE8x3G0K/gvNjuuJrbicPGa3CM CERw== X-Forwarded-Encrypted: i=1; AJvYcCU6lvezVuRsqfTjxxc5nvYxKEE3GvtRanEgTRDcW1OaODyZaNZs9FhE64G0+hP6Zemf6yypLfAZGx/tBf7HOjDdfiw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6tEsTeqDz2uryc39tY5NqUydbm1So6zKWBR91L8nPyXbuyPUR 9lBfYIABkTRSZNacB6NsPGZsafUR47c4VMz2hjcbn7mzcUaYzQVDZjFV X-Gm-Gg: ASbGncteBcK2VrFR5Rq/+HhQNtcz4uwsh7Ut6npNuS0f64m1fD5CP7DZJxyB9zL11ml Wtzk7HNrCL/l0z//Z9gLgFcdIvv/SHU+TkzEGO1piCdiadTauUJ557w+2w145zPKucUNTqyjXKv 6sTqio3OSkjXPd1U8rSsEs+sgjsGaT/Pd/eGI9bG6Ew9HLltFVn0vg2bnoOQrYrMeATU/VQNPpG OLpCpV4kL4K0enUR1ShIa9ACh3xh3XYMfUqvpiuwAKp0WgLjkY3rEpazp5mo7I8BAwTpPL6vnKN fO6586rzSSHhJjDRnZIWtyZ/dT4inCJ6Gtlc7FloX0E+SWyW/hWG8PiQjWQy1IGD/VepUardryp 7bUHATMjMOnxrLX0l76q8Trl50A== X-Google-Smtp-Source: AGHT+IF5ZwoBk0ceUXLZjQvXdKYyDk7CfR+Or0oVbNtL2fgYtH3GTtcS1SuTeoBLjpovsRj6PgtdCw== X-Received: by 2002:a17:90b:1844:b0:32e:87fa:d95f with SMTP id 98e67ed59e1d1-332a98f6f1fmr6851528a91.32.1758714749765; Wed, 24 Sep 2025 04:52:29 -0700 (PDT) Received: from localhost ([23.142.224.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341bd90587sm2190418a91.6.2025.09.24.04.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 04:52:29 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v5 15/23] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Wed, 24 Sep 2025 19:50:58 +0800 Message-ID: <20250924115124.194940-16-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250924115124.194940-1-wangjinchao600@gmail.com> References: <20250924115124.194940-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow dynamic enabling/disabling of KStackWatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 55 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 4a06ddadd9c7..11aa06908ff1 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -13,6 +13,43 @@ static struct ksw_config *ksw_config; static atomic_t config_file_busy = ATOMIC_INIT(0); +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret = ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret = ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active = true; + + pr_info("start watching: %s\n", ksw_config->user_input); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active = false; + + pr_info("stop watching: %s\n", ksw_config->user_input); +} + struct param_map { const char *name; /* long name */ const char *short_name; /* short name (2 letters) */ @@ -126,6 +163,9 @@ static ssize_t kstackwatch_proc_write(struct file *file, if (copy_from_user(input, buffer, count)) return -EFAULT; + if (watching_active) + ksw_stop_watching(); + input[count] = '\0'; strim(input); @@ -140,12 +180,22 @@ static ssize_t kstackwatch_proc_write(struct file *file, return ret; } + ret = ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } static int kstackwatch_proc_show(struct seq_file *m, void *v) { - seq_printf(m, "%s\n", ksw_config->user_input); + if (watching_active) + seq_printf(m, "%s\n", ksw_config->user_input); + else + seq_puts(m, "not watching\n"); + return 0; } @@ -193,6 +243,9 @@ static int __init kstackwatch_init(void) static void __exit kstackwatch_exit(void) { + if (watching_active) + ksw_stop_watching(); + remove_proc_entry("kstackwatch", NULL); kfree(ksw_config->func_name); kfree(ksw_config->user_input); -- 2.43.0