From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-btrace@vger.kernel.org,
John Garry <john.g.garry@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Damien Le Moal <dlemoal@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 11/15] blktrace: add block trace commands for zone operations
Date: Fri, 3 Oct 2025 09:32:57 +0200 [thread overview]
Message-ID: <20251003073257.GE12624@lst.de> (raw)
In-Reply-To: <20250925150231.67342-12-johannes.thumshirn@wdc.com>
On Thu, Sep 25, 2025 at 05:02:27PM +0200, Johannes Thumshirn wrote:
> Add block trace commands for zone operations. These are added as a
> separate set of 'block trace commands' shifted by 32bit so that they do
> not interfere with the old 16bit wide trace command field in 'struct
> blk_io_trace' action.
Can you explain how the commands are handled for old/new here?
Because I'd still much prefer to sort things out so that they make
sense for the new code if possible. i.e. have a 32-bit command
and 32 bit flags, and use sensible encoding for the new one, and
remap the supported once to the old organically grown one.
next prev parent reply other threads:[~2025-10-03 7:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 15:02 [PATCH v2 00/15] block: add blktrace support for zoned block device commands Johannes Thumshirn
2025-09-25 15:02 ` [PATCH v2 01/15] blktrace: only calculate trace length once Johannes Thumshirn
2025-10-01 6:12 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 02/15] blktrace: factor out recording a blktrace event Johannes Thumshirn
2025-10-01 6:14 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 03/15] blktrace: split out relaying " Johannes Thumshirn
2025-10-01 6:19 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 04/15] blktrace: untangle if/else sequence in __blk_add_trace Johannes Thumshirn
2025-10-01 6:19 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 05/15] blktrace: change the internal action to 64bit Johannes Thumshirn
2025-10-01 6:21 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 06/15] blktrace: split do_blk_trace_setup into two functions Johannes Thumshirn
2025-10-01 6:25 ` Damien Le Moal
2025-10-03 7:27 ` Christoph Hellwig
2025-09-25 15:02 ` [PATCH v2 07/15] blktrace: add definitions for blk_user_trace_setup2 Johannes Thumshirn
2025-10-01 6:27 ` Damien Le Moal
2025-10-03 7:29 ` Christoph Hellwig
2025-09-25 15:02 ` [PATCH v2 08/15] blktrace: pass blk_user_trace2 to setup functions Johannes Thumshirn
2025-10-01 6:34 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 09/15] blktrace: add definitions for struct blk_io_trace2 Johannes Thumshirn
2025-10-01 6:37 ` Damien Le Moal
2025-10-03 7:31 ` Christoph Hellwig
2025-09-25 15:02 ` [PATCH v2 10/15] blktrace: differentiate between blk_io_trace versions Johannes Thumshirn
2025-10-01 7:21 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 11/15] blktrace: add block trace commands for zone operations Johannes Thumshirn
2025-10-01 7:23 ` Damien Le Moal
2025-10-03 7:32 ` Christoph Hellwig [this message]
2025-10-07 13:08 ` Johannes Thumshirn
2025-10-08 6:14 ` hch
2025-10-08 6:16 ` Johannes Thumshirn
2025-10-09 11:17 ` Johannes Thumshirn
2025-10-10 7:32 ` hch
2025-09-25 15:02 ` [PATCH v2 12/15] blktrace: expose ZONE APPEND completions to blktrace Johannes Thumshirn
2025-10-01 7:28 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 13/15] blktrace: trace zone management operations Johannes Thumshirn
2025-10-01 7:30 ` Damien Le Moal
2025-10-08 13:29 ` Johannes Thumshirn
2025-10-08 22:41 ` Damien Le Moal
2025-10-09 9:57 ` Johannes Thumshirn
2025-09-25 15:02 ` [PATCH v2 14/15] blktrace: trace zone write plugging operations Johannes Thumshirn
2025-10-01 7:31 ` Damien Le Moal
2025-09-25 15:02 ` [PATCH v2 15/15] blktrace: handle BLKTRACESETUP2 ioctl Johannes Thumshirn
2025-10-01 7:35 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003073257.GE12624@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=rostedt@goodmis.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).