From: Steven Rostedt <rostedt@goodmis.org>
To: Runping Lai <runpinglai@google.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Wattson CI <wattson-external@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Luo Gengkun <luogengkun@huaweicloud.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v1] Revert "tracing: Fix tracing_marker may trigger page fault during preempt_disable"
Date: Tue, 7 Oct 2025 17:42:08 -0400 [thread overview]
Message-ID: <20251007174208.11fd02da@gandalf.local.home> (raw)
In-Reply-To: <20251007163141.1034b120@gandalf.local.home>
On Tue, 7 Oct 2025 16:31:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> +static void trace_user_fault_buffer_free(struct trace_user_buf_info *tinfo)
> +{
> + char *buf;
> + int cpu;
> +
> + for_each_possible_cpu(cpu) {
> + buf = per_cpu_ptr(tinfo->tbuf, cpu)->buf;
> + kfree(buf);
> + }
Oops, missed:
free_percpu(tinfo->tbuf);
here.
-- Steve
> + kfree(tinfo);
> +}
next prev parent reply other threads:[~2025-10-07 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 0:34 [PATCH v1] Revert "tracing: Fix tracing_marker may trigger page fault during preempt_disable" Runping Lai
2025-10-07 2:10 ` Steven Rostedt
2025-10-07 18:19 ` Runping Lai
2025-10-07 19:43 ` Steven Rostedt
2025-10-07 20:31 ` Steven Rostedt
2025-10-07 21:42 ` Steven Rostedt [this message]
2025-10-07 23:25 ` Runping Lai
2025-10-08 0:21 ` Steven Rostedt
2025-10-08 16:32 ` Steven Rostedt
2025-10-08 17:12 ` Runping Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007174208.11fd02da@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luogengkun@huaweicloud.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=runpinglai@google.com \
--cc=torvalds@linux-foundation.org \
--cc=wattson-external@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).