* [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
@ 2025-08-20 21:47 Thorsten Blum
2025-08-25 7:05 ` Masami Hiramatsu
0 siblings, 1 reply; 6+ messages in thread
From: Thorsten Blum @ 2025-08-20 21:47 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers
Cc: linux-hardening, Thorsten Blum, linux-kernel, linux-trace-kernel
strcpy() is deprecated; use memcpy() instead.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
kernel/trace/trace_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 5cbdc423afeb..d3ba5869d32c 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -214,7 +214,7 @@ void __trace_probe_log_err(int offset, int err_type)
p = command;
for (i = 0; i < trace_probe_log.argc; i++) {
len = strlen(trace_probe_log.argv[i]);
- strcpy(p, trace_probe_log.argv[i]);
+ memcpy(p, trace_probe_log.argv[i], len);
p[len] = ' ';
p += len + 1;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
2025-08-20 21:47 [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err() Thorsten Blum
@ 2025-08-25 7:05 ` Masami Hiramatsu
2025-09-08 10:13 ` Thorsten Blum
0 siblings, 1 reply; 6+ messages in thread
From: Masami Hiramatsu @ 2025-08-25 7:05 UTC (permalink / raw)
To: Thorsten Blum
Cc: Steven Rostedt, Mathieu Desnoyers, linux-hardening, linux-kernel,
linux-trace-kernel
On Wed, 20 Aug 2025 23:47:18 +0200
Thorsten Blum <thorsten.blum@linux.dev> wrote:
> strcpy() is deprecated; use memcpy() instead.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
OK, looks good to me.
Thanks,
> ---
> kernel/trace/trace_probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 5cbdc423afeb..d3ba5869d32c 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -214,7 +214,7 @@ void __trace_probe_log_err(int offset, int err_type)
> p = command;
> for (i = 0; i < trace_probe_log.argc; i++) {
> len = strlen(trace_probe_log.argv[i]);
> - strcpy(p, trace_probe_log.argv[i]);
> + memcpy(p, trace_probe_log.argv[i], len);
> p[len] = ' ';
> p += len + 1;
> }
> --
> 2.50.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
2025-08-25 7:05 ` Masami Hiramatsu
@ 2025-09-08 10:13 ` Thorsten Blum
2025-09-08 23:53 ` Masami Hiramatsu
0 siblings, 1 reply; 6+ messages in thread
From: Thorsten Blum @ 2025-09-08 10:13 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Steven Rostedt, Mathieu Desnoyers, linux-hardening, linux-kernel,
linux-trace-kernel
Hi Masami,
On 25. Aug 2025, at 09:05, Masami Hiramatsu (Google) wrote:
> On Wed, 20 Aug 2025 23:47:18 +0200
> Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
>> strcpy() is deprecated; use memcpy() instead.
>>
>> Link: https://github.com/KSPP/linux/issues/88
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> OK, looks good to me.
Did you forget to add a Reviewed-by: tag and/or to add it to your tree?
Thanks,
Thorsten
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
2025-09-08 10:13 ` Thorsten Blum
@ 2025-09-08 23:53 ` Masami Hiramatsu
2025-10-07 23:14 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Masami Hiramatsu @ 2025-09-08 23:53 UTC (permalink / raw)
To: Thorsten Blum
Cc: Steven Rostedt, Mathieu Desnoyers, linux-hardening, linux-kernel,
linux-trace-kernel
On Mon, 8 Sep 2025 12:13:23 +0200
Thorsten Blum <thorsten.blum@linux.dev> wrote:
> Hi Masami,
>
> On 25. Aug 2025, at 09:05, Masami Hiramatsu (Google) wrote:
> > On Wed, 20 Aug 2025 23:47:18 +0200
> > Thorsten Blum <thorsten.blum@linux.dev> wrote:
> >
> >> strcpy() is deprecated; use memcpy() instead.
> >>
> >> Link: https://github.com/KSPP/linux/issues/88
> >> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> >
> > OK, looks good to me.
>
> Did you forget to add a Reviewed-by: tag and/or to add it to your tree?
Thanks for ping me. No problem, I will add my Signed-by when
picking this to probes/for-next.
Since I will be responsible for applying this patch and sending
it to Linus, this includes the "Reviewed-by" as well.
Thank you,
>
> Thanks,
> Thorsten
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
2025-09-08 23:53 ` Masami Hiramatsu
@ 2025-10-07 23:14 ` Steven Rostedt
2025-10-07 23:57 ` Masami Hiramatsu
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2025-10-07 23:14 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Thorsten Blum, Mathieu Desnoyers, linux-hardening, linux-kernel,
linux-trace-kernel
On Tue, 9 Sep 2025 08:53:08 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Mon, 8 Sep 2025 12:13:23 +0200
> Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> > Hi Masami,
> >
> > On 25. Aug 2025, at 09:05, Masami Hiramatsu (Google) wrote:
> > > On Wed, 20 Aug 2025 23:47:18 +0200
> > > Thorsten Blum <thorsten.blum@linux.dev> wrote:
> > >
> > >> strcpy() is deprecated; use memcpy() instead.
> > >>
> > >> Link: https://github.com/KSPP/linux/issues/88
> > >> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > >
> > > OK, looks good to me.
> >
> > Did you forget to add a Reviewed-by: tag and/or to add it to your tree?
>
> Thanks for ping me. No problem, I will add my Signed-by when
> picking this to probes/for-next.
> Since I will be responsible for applying this patch and sending
> it to Linus, this includes the "Reviewed-by" as well.
>
Was this ever sent to Linus?
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err()
2025-10-07 23:14 ` Steven Rostedt
@ 2025-10-07 23:57 ` Masami Hiramatsu
0 siblings, 0 replies; 6+ messages in thread
From: Masami Hiramatsu @ 2025-10-07 23:57 UTC (permalink / raw)
To: Steven Rostedt
Cc: Thorsten Blum, Mathieu Desnoyers, linux-hardening, linux-kernel,
linux-trace-kernel
On Tue, 7 Oct 2025 19:14:15 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 9 Sep 2025 08:53:08 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > On Mon, 8 Sep 2025 12:13:23 +0200
> > Thorsten Blum <thorsten.blum@linux.dev> wrote:
> >
> > > Hi Masami,
> > >
> > > On 25. Aug 2025, at 09:05, Masami Hiramatsu (Google) wrote:
> > > > On Wed, 20 Aug 2025 23:47:18 +0200
> > > > Thorsten Blum <thorsten.blum@linux.dev> wrote:
> > > >
> > > >> strcpy() is deprecated; use memcpy() instead.
> > > >>
> > > >> Link: https://github.com/KSPP/linux/issues/88
> > > >> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > > >
> > > > OK, looks good to me.
> > >
> > > Did you forget to add a Reviewed-by: tag and/or to add it to your tree?
> >
> > Thanks for ping me. No problem, I will add my Signed-by when
> > picking this to probes/for-next.
> > Since I will be responsible for applying this patch and sending
> > it to Linus, this includes the "Reviewed-by" as well.
> >
>
> Was this ever sent to Linus?
Yeah, but rejected with other patches in probes/for-next.
I thought it was a part of cleanup, or should I sent it urgently?
Then I can move this to probes/fixes.
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-07 23:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 21:47 [PATCH] tracing: probes: Replace strcpy() with memcpy() in __trace_probe_log_err() Thorsten Blum
2025-08-25 7:05 ` Masami Hiramatsu
2025-09-08 10:13 ` Thorsten Blum
2025-09-08 23:53 ` Masami Hiramatsu
2025-10-07 23:14 ` Steven Rostedt
2025-10-07 23:57 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).