From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD3127B358 for ; Wed, 8 Oct 2025 19:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759953596; cv=none; b=JbkgJDFLgdXWSPrDkGZSEwLPW/MJA1w5M1MkZGBjigae7Pb3km93VRnFAqmGC8Bv+CVr9kdAvP3s2WJv4cy6anA6F/jeBlaePga+UJbKTxNS2ijVbttPYiwMQLNSiTC5MN37G/ogghxCOQLxS73CLbiI7uiGWr+gn2HgNoYr+6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759953596; c=relaxed/simple; bh=eC6iWnNBNyM2qZxYKEtLZwJZLXCisj1zl5uKGzp7UB4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=kqRqzCLyr7c+KXfqjIFUXRM823u7eX1XUMJroPNFozoaktoyP893nDUNWLLDlgh9Gj/xXqrsn0vYxr+ReKjbbH8NmuMNWjCMEEKBMZejH8z9quOnJSfTAqSlUg0MmSn/+c2rb5xaG/LkkCD3z6yK2k3hLl3Ani/II75og7ArhUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fintwXOR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fintwXOR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759953594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFfsvgXlRSf6rwDo6xn40BqTVmK62+JiqJARnqqZUVw=; b=fintwXORuzlwasiNb2sfXzcJhHE8+0UrSdKRihNXQT6L9RhtqFBG+zoCYrZ3qNatkJ/LCF 9Y7+EQ4J1IZkZXTjOHEswO01CUwiNHPnswTK+Pf6rKtEL2D2baRr6rt6j2aT9hsDduVW7p kuj52p9Uy3LTULUlbqrgw6GN9Z6fkKw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-dqCkUWTJMc-ZE4nj87osUg-1; Wed, 08 Oct 2025 15:59:52 -0400 X-MC-Unique: dqCkUWTJMc-ZE4nj87osUg-1 X-Mimecast-MFC-AGG-ID: dqCkUWTJMc-ZE4nj87osUg_1759953591 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-42421b15185so224086f8f.1 for ; Wed, 08 Oct 2025 12:59:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759953591; x=1760558391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cFfsvgXlRSf6rwDo6xn40BqTVmK62+JiqJARnqqZUVw=; b=NSJdr9xec9JM52wTSDueMSSO1Ob3w+dvFy6a1cADaqL5DPJpaTihI8ofNRmQ9o9s5s nuoR5u6LVGiAytX3UixcXR21PFBUGX80eLsMeyQg/jNq+S+ZfV6Mub0jJtlPqtL6oGbY jXGxzlPrTMMZWswdd8BJthFVz6/GusjMWlctWg7jyns+2jA5Rtxt2/l11ftP5VgTwkY2 Ip8mBcWhE7A3rwY5xnahwYM7ILrswAqGVPWNb2XbkLEvty8dgBSr7sX2Gf6BQfcds+7P 8wNQJKkQ+REz3nDU2hHAp8itoO42n1mXYfirgAMhTgtSKeqymRTZyHaREIwyv0PqaQZv dUBA== X-Forwarded-Encrypted: i=1; AJvYcCUHNUuhx9D6GMNrFCFsyFmq+yMVeCinV3I46JlYMIJ+5x+nYOboVo0lKFfRfhuqsR/nn2gHfSqo3VE1j6KSj5HAPSE=@vger.kernel.org X-Gm-Message-State: AOJu0YwEno1/XTlOPG54LAYjyLXD2tSL56DLAXpcpwQmcmg7fJGOfWIS pbtPhjoBKZF+EQ0h1qxQBn2+8qWZuSbe10evhPLxb7UrPBMJZur3fiYJqkzQquHcN/oolUKef4i r55CDgZNXs3IbnB08W/1bE9rktlsZs3T5w56QmtE6xlYp+YHgIJ/p9jZkeVAQtEQuSwHE9GKP5A == X-Gm-Gg: ASbGnctI3ZFlnHc3GcDPmRFcj9c3zEXR+Fr0agirr5TNQrBqyJds/2Y3pXjC3WdNYk9 aOE98ER2ofoAA4dnfT1CiuuafSqjChkOjrrwWFnJ/YYvNhWy+gNEWK5eFB9kedcg5zZopXslZBJ XMxZk2CddLOgfwSguDL2DQfJk6jwZLfoIUfAk6hYjM9rGP38rImwBm7ukd7XFHoKh9ay6F11hdB /pkmvFxlCR1uzWfC5QKVsv3W5XBidPEBUnTRDtikIqD2avHI19eRzigNm2aqSkopJFyPgBuAu5g KyvN1l+K+nxvZHoyt0R+cjEOkoUO9VwO6HHFLfPVX6cv80x0tRrtWrmUpuIUCZE= X-Received: by 2002:a05:6000:2210:b0:407:77f9:949f with SMTP id ffacd0b85a97d-4266e7c61aemr2522389f8f.28.1759953591304; Wed, 08 Oct 2025 12:59:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDzNUKc6b/ceMuaj4GD/u+xwcihuiULQIOyPD0gPH1NRrkBwWHaQIL25rVPGtipU8o4UOfBw== X-Received: by 2002:a05:6000:2210:b0:407:77f9:949f with SMTP id ffacd0b85a97d-4266e7c61aemr2522377f8f.28.1759953590902; Wed, 08 Oct 2025 12:59:50 -0700 (PDT) Received: from costa-tp.redhat.com ([2a00:a041:e2eb:5500:8728:d68a:a687:c89b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8efffasm31209583f8f.41.2025.10.08.12.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 12:59:50 -0700 (PDT) From: Costa Shulyupin To: Steven Rostedt , Tomas Glozar , Costa Shulyupin , Crystal Wood , John Kacur , Jan Stancek , Tiezhu Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/5] tools/rtla: Replace timerlat_hist_usage("...") with fatal("...") Date: Wed, 8 Oct 2025 22:59:03 +0300 Message-ID: <20251008195905.333514-4-costa.shul@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251008195905.333514-1-costa.shul@redhat.com> References: <20251008195905.333514-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ogJwsI9_GwvIvoYNr7G3DHOlz38Xu2CquKZu8hQkjNk_1759953591 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true A long time ago, when the usage help was short, it was a favor to the user to show it on error. Now that the usage help has become very long, it is too noisy to dump the complete help text for each typo after the error message itself. Replace timerlat_hist_usage("...") with fatal("...") on errors. Remove the already unused 'usage' argument from timerlat_hist_usage(). Signed-off-by: Costa Shulyupin --- tools/tracing/rtla/src/timerlat_hist.c | 36 +++++++++++--------------- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/src/timerlat_hist.c index 6504556be5e4..fcc4f2e9213b 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -710,7 +710,7 @@ timerlat_print_stats(struct osnoise_tool *tool) /* * timerlat_hist_usage - prints timerlat top usage message */ -static void timerlat_hist_usage(char *usage) +static void timerlat_hist_usage(void) { int i; @@ -766,18 +766,12 @@ static void timerlat_hist_usage(char *usage) NULL, }; - if (usage) - fprintf(stderr, "%s\n", usage); - fprintf(stderr, "rtla timerlat hist: a per-cpu histogram of the timer latency (version %s)\n", VERSION); for (i = 0; msg[i]; i++) fprintf(stderr, "%s\n", msg[i]); - if (usage) - exit(EXIT_FAILURE); - exit(EXIT_SUCCESS); } @@ -884,7 +878,7 @@ static struct common_params case 'c': retval = parse_cpu_set(optarg, ¶ms->common.monitored_cpus); if (retval) - timerlat_hist_usage("\nInvalid -c cpu list\n"); + fatal("\nInvalid -c cpu list\n"); params->common.cpus = optarg; break; case 'C': @@ -901,7 +895,7 @@ static struct common_params params->common.hist.bucket_size = get_llong_from_str(optarg); if (params->common.hist.bucket_size == 0 || params->common.hist.bucket_size >= 1000000) - timerlat_hist_usage("Bucket size needs to be > 0 and <= 1000000\n"); + fatal("Bucket size needs to be > 0 and <= 1000000\n"); break; case 'D': config_debug = 1; @@ -909,12 +903,12 @@ static struct common_params case 'd': params->common.duration = parse_seconds_duration(optarg); if (!params->common.duration) - timerlat_hist_usage("Invalid -D duration\n"); + fatal("Invalid -D duration\n"); break; case 'e': tevent = trace_event_alloc(optarg); if (!tevent) - fatal("Error alloc trace event"); + fatal("Error alloc trace event\n"); if (params->common.events) tevent->next = params->common.events; @@ -925,11 +919,11 @@ static struct common_params params->common.hist.entries = get_llong_from_str(optarg); if (params->common.hist.entries < 10 || params->common.hist.entries > 9999999) - timerlat_hist_usage("Entries must be > 10 and < 9999999\n"); + fatal("Entries must be > 10 and < 9999999\n"); break; case 'h': case '?': - timerlat_hist_usage(NULL); + timerlat_hist_usage(); break; case 'H': params->common.hk_cpus = 1; @@ -949,12 +943,12 @@ static struct common_params case 'p': params->timerlat_period_us = get_llong_from_str(optarg); if (params->timerlat_period_us > 1000000) - timerlat_hist_usage("Period longer than 1 s\n"); + fatal("Period longer than 1 s\n"); break; case 'P': retval = parse_prio(optarg, ¶ms->common.sched_param); if (retval == -1) - timerlat_hist_usage("Invalid -P priority"); + fatal("Invalid -P priority\n"); params->common.set_sched = 1; break; case 's': @@ -1004,7 +998,7 @@ static struct common_params if (retval) fatal("Error adding trigger %s\n", optarg); } else { - timerlat_hist_usage("--trigger requires a previous -e\n"); + fatal("--trigger requires a previous -e\n"); } break; case '7': /* filter */ @@ -1013,13 +1007,13 @@ static struct common_params if (retval) fatal("Error adding filter %s\n", optarg); } else { - timerlat_hist_usage("--filter requires a previous -e\n"); + fatal("--filter requires a previous -e\n"); } break; case '8': params->dma_latency = get_llong_from_str(optarg); if (params->dma_latency < 0 || params->dma_latency > 10000) - fatal("--dma-latency needs to be >= 0 and < 10000"); + fatal("--dma-latency needs to be >= 0 and < 10000\n"); break; case '9': params->no_aa = 1; @@ -1060,10 +1054,10 @@ static struct common_params fatal("rtla needs root permission\n"); if (params->common.hist.no_irq && params->common.hist.no_thread) - timerlat_hist_usage("no-irq and no-thread set, there is nothing to do here"); + fatal("no-irq and no-thread set, there is nothing to do here\n"); if (params->common.hist.no_index && !params->common.hist.with_zeros) - timerlat_hist_usage("no-index set with with-zeros is not set - it does not make sense"); + fatal("no-index set with with-zeros is not set - it does not make sense\n"); /* * Auto analysis only happens if stop tracing, thus: @@ -1072,7 +1066,7 @@ static struct common_params params->no_aa = 1; if (params->common.kernel_workload && params->common.user_workload) - timerlat_hist_usage("--kernel-threads and --user-threads are mutually exclusive!"); + fatal("--kernel-threads and --user-threads are mutually exclusive!\n"); /* * If auto-analysis or trace output is enabled, switch from BPF mode to -- 2.51.0