[PATCH v1] tools/rtla: Remove unused function declarations

[PATCH v1] tools/rtla: Remove unused function declarations

[Costa Shulyupin]

Historically four function declarations remain orphaned or duplicated.

Remove them to keep the source clean.

Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
---
 tools/tracing/rtla/src/osnoise.h | 3 ---
 tools/tracing/rtla/src/utils.h   | 1 -
 2 files changed, 4 deletions(-)

diff --git a/tools/tracing/rtla/src/osnoise.h b/tools/tracing/rtla/src/osnoise.h
index 895687030c0b..75de0d5c706a 100644
--- a/tools/tracing/rtla/src/osnoise.h
+++ b/tools/tracing/rtla/src/osnoise.h
@@ -58,8 +58,6 @@ int osnoise_set_irq_disable(struct osnoise_context *context, bool onoff);
 void osnoise_report_missed_events(struct osnoise_tool *tool);
 int osnoise_apply_config(struct osnoise_tool *tool, struct osnoise_params *params);
 
-int osnoise_hist_main(int argc, char *argv[]);
-int osnoise_top_main(int argc, char **argv);
 int osnoise_enable(struct osnoise_tool *tool);
 int osnoise_main(int argc, char **argv);
 int hwnoise_main(int argc, char **argv);
@@ -68,4 +66,3 @@ extern struct tool_ops timerlat_top_ops, timerlat_hist_ops;
 extern struct tool_ops osnoise_top_ops, osnoise_hist_ops;
 
 int run_tool(struct tool_ops *ops, int argc, char *argv[]);
-int hist_main_loop(struct osnoise_tool *tool);
diff --git a/tools/tracing/rtla/src/utils.h b/tools/tracing/rtla/src/utils.h
index a2a6f89f342d..6086e246bd85 100644
--- a/tools/tracing/rtla/src/utils.h
+++ b/tools/tracing/rtla/src/utils.h
@@ -23,7 +23,6 @@ void err_msg(const char *fmt, ...);
 long parse_seconds_duration(char *val);
 void get_duration(time_t start_time, char *output, int output_size);
 
-int parse_cpu_list(char *cpu_list, char **monitored_cpus);
 long long get_llong_from_str(char *start);
 
 static inline void
-- 
2.51.0

Re: [PATCH v1] tools/rtla: Remove unused function declarations

[Tomas Glozar]

ne 12. 10. 2025 v 9:13 odesílatel Costa Shulyupin
<costa.shul@redhat.com> napsal:
>
> Historically four function declarations remain orphaned or duplicated.
>

For future reference, it is helpful to include where exactly and why
those were removed, especially considering that three of those four
were only removed in the most recent tag (6.18-rc1). For this case:

Commit 2f3172f9dd5 ("tools/rtla: Consolidate code between
osnoise/timerlat and hist/top") removed
{osnoise,timerlat}_{hist,top}_main() functions in favor of a common
function, run_tool(). Remove also their declarations to keep with
source clean, along with parse_cpu_list(), which was replaced by
parse_cpu_set() in commit 894c29c76b2b ("rtla: Change monitored_cpus
from char * to cpu_set_t").

> Remove them to keep the source clean.
>
> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
> ---

Tomas