* [PATCH 13/21] trace: don't use GENMASK()
[not found] <20251025162858.305236-1-yury.norov@gmail.com>
@ 2025-10-25 16:32 ` Yury Norov (NVIDIA)
2025-10-25 19:29 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-10-25 16:32 UTC (permalink / raw)
To: Linus Walleij, Lee Jones, linux-arm-kernel, linux-kernel,
Steven Rostedt, Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers,
linux-trace-kernel
Cc: Yury Norov (NVIDIA)
GENMASK(high, low) notation is confusing. FIRST_BITS() is more
appropriate.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
kernel/trace/fgraph.c | 10 +++++-----
kernel/trace/trace_probe.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
index 484ad7a18463..4f21bd837055 100644
--- a/kernel/trace/fgraph.c
+++ b/kernel/trace/fgraph.c
@@ -106,10 +106,10 @@
* (RESERVED or BITMAP)
*/
#define FGRAPH_FRAME_OFFSET_BITS 10
-#define FGRAPH_FRAME_OFFSET_MASK GENMASK(FGRAPH_FRAME_OFFSET_BITS - 1, 0)
+#define FGRAPH_FRAME_OFFSET_MASK FIRST_BITS(FGRAPH_FRAME_OFFSET_BITS)
#define FGRAPH_TYPE_BITS 2
-#define FGRAPH_TYPE_MASK GENMASK(FGRAPH_TYPE_BITS - 1, 0)
+#define FGRAPH_TYPE_MASK FIRST_BITS(FGRAPH_TYPE_BITS)
#define FGRAPH_TYPE_SHIFT FGRAPH_FRAME_OFFSET_BITS
enum {
@@ -123,7 +123,7 @@ enum {
* FGRAPH_INDEX (12-27) bits holding the gops index wanting return callback called
*/
#define FGRAPH_INDEX_BITS 16
-#define FGRAPH_INDEX_MASK GENMASK(FGRAPH_INDEX_BITS - 1, 0)
+#define FGRAPH_INDEX_MASK FIRST_BITS(FGRAPH_INDEX_BITS)
#define FGRAPH_INDEX_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS)
/*
@@ -135,12 +135,12 @@ enum {
* data_size == 0 means 1 word, and 31 (=2^5 - 1) means 32 words.
*/
#define FGRAPH_DATA_BITS 5
-#define FGRAPH_DATA_MASK GENMASK(FGRAPH_DATA_BITS - 1, 0)
+#define FGRAPH_DATA_MASK FIRST_BITS(FGRAPH_DATA_BITS)
#define FGRAPH_DATA_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS)
#define FGRAPH_MAX_DATA_SIZE (sizeof(long) * (1 << FGRAPH_DATA_BITS))
#define FGRAPH_DATA_INDEX_BITS 4
-#define FGRAPH_DATA_INDEX_MASK GENMASK(FGRAPH_DATA_INDEX_BITS - 1, 0)
+#define FGRAPH_DATA_INDEX_MASK FIRST_BITS(FGRAPH_DATA_INDEX_BITS)
#define FGRAPH_DATA_INDEX_SHIFT (FGRAPH_DATA_SHIFT + FGRAPH_DATA_BITS)
#define FGRAPH_MAX_INDEX \
diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h
index 08b5bda24da2..88de129dcde0 100644
--- a/kernel/trace/trace_probe.h
+++ b/kernel/trace/trace_probe.h
@@ -401,7 +401,7 @@ static inline int traceprobe_get_entry_data_size(struct trace_probe *tp)
#define TPARG_FL_USER BIT(4)
#define TPARG_FL_FPROBE BIT(5)
#define TPARG_FL_TPOINT BIT(6)
-#define TPARG_FL_LOC_MASK GENMASK(4, 0)
+#define TPARG_FL_LOC_MASK FIRST_BITS(5)
static inline bool tparg_is_function_entry(unsigned int flags)
{
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 13/21] trace: don't use GENMASK()
[not found] <20251025164023.308884-1-yury.norov@gmail.com>
@ 2025-10-25 16:40 ` Yury Norov (NVIDIA)
0 siblings, 0 replies; 4+ messages in thread
From: Yury Norov (NVIDIA) @ 2025-10-25 16:40 UTC (permalink / raw)
To: Linus Torvalds, Linus Walleij, Nicolas Frattaroli, Steven Rostedt,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel
Cc: Yury Norov (NVIDIA), Rasmus Villemoes
GENMASK(high, low) notation is confusing. FIRST_BITS() is more
appropriate.
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
---
kernel/trace/fgraph.c | 10 +++++-----
kernel/trace/trace_probe.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
index 484ad7a18463..4f21bd837055 100644
--- a/kernel/trace/fgraph.c
+++ b/kernel/trace/fgraph.c
@@ -106,10 +106,10 @@
* (RESERVED or BITMAP)
*/
#define FGRAPH_FRAME_OFFSET_BITS 10
-#define FGRAPH_FRAME_OFFSET_MASK GENMASK(FGRAPH_FRAME_OFFSET_BITS - 1, 0)
+#define FGRAPH_FRAME_OFFSET_MASK FIRST_BITS(FGRAPH_FRAME_OFFSET_BITS)
#define FGRAPH_TYPE_BITS 2
-#define FGRAPH_TYPE_MASK GENMASK(FGRAPH_TYPE_BITS - 1, 0)
+#define FGRAPH_TYPE_MASK FIRST_BITS(FGRAPH_TYPE_BITS)
#define FGRAPH_TYPE_SHIFT FGRAPH_FRAME_OFFSET_BITS
enum {
@@ -123,7 +123,7 @@ enum {
* FGRAPH_INDEX (12-27) bits holding the gops index wanting return callback called
*/
#define FGRAPH_INDEX_BITS 16
-#define FGRAPH_INDEX_MASK GENMASK(FGRAPH_INDEX_BITS - 1, 0)
+#define FGRAPH_INDEX_MASK FIRST_BITS(FGRAPH_INDEX_BITS)
#define FGRAPH_INDEX_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS)
/*
@@ -135,12 +135,12 @@ enum {
* data_size == 0 means 1 word, and 31 (=2^5 - 1) means 32 words.
*/
#define FGRAPH_DATA_BITS 5
-#define FGRAPH_DATA_MASK GENMASK(FGRAPH_DATA_BITS - 1, 0)
+#define FGRAPH_DATA_MASK FIRST_BITS(FGRAPH_DATA_BITS)
#define FGRAPH_DATA_SHIFT (FGRAPH_TYPE_SHIFT + FGRAPH_TYPE_BITS)
#define FGRAPH_MAX_DATA_SIZE (sizeof(long) * (1 << FGRAPH_DATA_BITS))
#define FGRAPH_DATA_INDEX_BITS 4
-#define FGRAPH_DATA_INDEX_MASK GENMASK(FGRAPH_DATA_INDEX_BITS - 1, 0)
+#define FGRAPH_DATA_INDEX_MASK FIRST_BITS(FGRAPH_DATA_INDEX_BITS)
#define FGRAPH_DATA_INDEX_SHIFT (FGRAPH_DATA_SHIFT + FGRAPH_DATA_BITS)
#define FGRAPH_MAX_INDEX \
diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h
index 08b5bda24da2..88de129dcde0 100644
--- a/kernel/trace/trace_probe.h
+++ b/kernel/trace/trace_probe.h
@@ -401,7 +401,7 @@ static inline int traceprobe_get_entry_data_size(struct trace_probe *tp)
#define TPARG_FL_USER BIT(4)
#define TPARG_FL_FPROBE BIT(5)
#define TPARG_FL_TPOINT BIT(6)
-#define TPARG_FL_LOC_MASK GENMASK(4, 0)
+#define TPARG_FL_LOC_MASK FIRST_BITS(5)
static inline bool tparg_is_function_entry(unsigned int flags)
{
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 13/21] trace: don't use GENMASK()
2025-10-25 16:32 ` Yury Norov (NVIDIA)
@ 2025-10-25 19:29 ` Steven Rostedt
2025-10-25 19:36 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2025-10-25 19:29 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Linus Walleij, Lee Jones, linux-arm-kernel, linux-kernel,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers,
linux-trace-kernel
On Sat, 25 Oct 2025 12:32:55 -0400
"Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
> GENMASK(high, low) notation is confusing. FIRST_BITS() is more
> appropriate.
>
I'm fine with this change as a clean up, but...
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> ---
> kernel/trace/fgraph.c | 10 +++++-----
> kernel/trace/trace_probe.h | 2 +-
Make this two different patches. trace_probe and fgraph go through
different topic branches.
Thanks,
-- Steve
> 2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 13/21] trace: don't use GENMASK()
2025-10-25 19:29 ` Steven Rostedt
@ 2025-10-25 19:36 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2025-10-25 19:36 UTC (permalink / raw)
To: Yury Norov (NVIDIA)
Cc: Linus Walleij, Lee Jones, linux-arm-kernel, linux-kernel,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers,
linux-trace-kernel
On Sat, 25 Oct 2025 15:29:54 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 25 Oct 2025 12:32:55 -0400
> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>
> > GENMASK(high, low) notation is confusing. FIRST_BITS() is more
> > appropriate.
> >
>
> I'm fine with this change as a clean up, but...
>
> > Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> > ---
> > kernel/trace/fgraph.c | 10 +++++-----
> > kernel/trace/trace_probe.h | 2 +-
>
> Make this two different patches. trace_probe and fgraph go through
> different topic branches.
OK, I see this is part of a patch series that adds FIRST_BITS().
Please add that first, and the rest of the patches can go though their
individual trees. Something like this change I would like to make sure
doesn't accidentally cause a regression. That means it must go through
my tests before it gets applied.
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-25 19:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251025164023.308884-1-yury.norov@gmail.com>
2025-10-25 16:40 ` [PATCH 13/21] trace: don't use GENMASK() Yury Norov (NVIDIA)
[not found] <20251025162858.305236-1-yury.norov@gmail.com>
2025-10-25 16:32 ` Yury Norov (NVIDIA)
2025-10-25 19:29 ` Steven Rostedt
2025-10-25 19:36 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).