From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Masami Hiramatsu (Google) <mhiramat@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, Jinchao Wang <wangjinchao600@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Aishwarya.TCV@arm.com
Subject: Re: [PATCH v5 6/8] selftests: tracing: Add a basic testcase for wprobe
Date: Tue, 28 Oct 2025 10:55:49 +0900 [thread overview]
Message-ID: <20251028105549.ae94e8eeb42f4efc183d2807@kernel.org> (raw)
In-Reply-To: <20251028084222.a3c1ae97d125d9bd88fc565b@kernel.org>
On Tue, 28 Oct 2025 08:42:22 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> ~ # cd /sys/kernel/tracing/
> /sys/kernel/tracing # echo 'w:my_wprobe w@jiffies' >> dynamic_events
> /sys/kernel/tracing # echo 1 > events/wprobes/my_wprobe/enable
> [ 54.942288] trace_wprobe: enable_trace_wprobe called
> [ 54.945306] trace_wprobe: trying to register wprobes
> [ 54.947367] trace_wprobe: __register_trace_wprobe called
> [ 54.949586] trace_wprobe: registering wprobe at addr: 0xffffb6ce429fb200, len: 4, type: 2
> [ 54.951639] Creating wide hw breakpoint on CPU 0
> [ 54.966390] Creating kernel counter on CPU 0 for event type 5
> [ 54.967758] perf_install_in_context: event 00000000736da1d9 ctx 000000005d4db900 cpu 0
> [ 54.972015] perf_install_in_context2: event 00000000736da1d9 ctx set to 000000005d4db900
> [ 54.976697] cpu_function_call: calling function on CPU 0, func: __perf_install_in_context+0x0/0x2c8
>
> What happen if the cpu calls function on itself by
> smp_call_function_single() on arm64?
>
> smp_call_function_single(this_cpu, remote_function, &data, 1);
Sorry, that was printk buffering issue. I used trace_printk() instead
and persistent ring buffer[1] to trace it.
[1] https://docs.kernel.org/trace/debugging.html#persistent-buffers-across-boots
~ # echo 1 > /sys/kernel/tracing/instances/boot_map/options/trace_printk_dest
~ # echo 'w:my_wprobe w@jiffies' >> /sys/kernel/tracing/dynamic_events
~ # echo 1 > /sys/kernel/tracing/events/wprobes/my_wprobe/enable
QEMU 8.2.2 monitor - type 'help' for more information
(qemu) system_reset
...
~ # cat /sys/kernel/tracing/instances/boot_map/trace
# tracer: nop
#
# entries-in-buffer/entries-written: 16/16 #P:1
#
# _-----=> irqs-off/BH-disabled
# / _----=> need-resched
# | / _---=> hardirq/softirq
# || / _--=> preempt-depth
# ||| / _-=> migrate-disable
# |||| / delay
# TASK-PID CPU# ||||| TIMESTAMP FUNCTION
# | | | ||||| | |
<...>-63 [000] ..... 21.065038: register_wide_hw_breakpoint: Creating wide hw breakpoint on CPU 0
<...>-63 [000] ..... 21.079678: perf_event_create_kernel_counter: Creating kernel counter on CPU 0 for event type 5
<...>-63 [000] ..... 21.080051: perf_install_in_context: perf_install_in_context: event 000000000b3ac4d3 ctx 00000000097d6337 cpu 0
<...>-63 [000] ..... 21.080140: perf_install_in_context: perf_install_in_context2: event 000000000b3ac4d3 ctx set to 00000000097d6337
<...>-63 [000] ..... 21.080939: cpu_function_call: cpu_function_call: calling function on CPU 0, func: __perf_install_in_context+0x0/0x2f0
<...>-63 [000] ..... 21.080966: smp_call_function_single: smp_call_function_single: calling function on CPU 0, func: remote_function+0x0/0x78, wait=1
<...>-63 [000] ...1. 21.080973: smp_call_function_single: smp_call_function_single: running on CPU 0, call CPU 0
<...>-63 [000] ...1. 21.081099: smp_call_function_single: smp_call_function_single: checking for potential deadlock conditions
<...>-63 [000] ...1. 21.081259: generic_exec_single: generic_exec_single: preparing to call function on CPU 0, func: remote_function+0x0/0x78
<...>-63 [000] ...1. 21.081269: generic_exec_single: Executing smp_call_function_single on self CPU 0, func: remote_function+0x0/0x78
<...>-63 [000] d..1. 21.081289: csd_do_func: csd_do_func: CPU 0 executing func remote_function+0x0/0x78
<...>-63 [000] d..1. 21.081429: __perf_install_in_context: __perf_install_in_context: event 000000000b3ac4d3 ctx 00000000097d6337
<...>-63 [000] d..2. 21.083211: hw_breakpoint_control: hw_breakpoint_control: ops=0
<...>-63 [000] d..1. 21.084191: __perf_install_in_context: __perf_install_in_context: event 000000000b3ac4d3 done, ret=0
<...>-63 [000] d..1. 21.084237: csd_do_func: csd_do_func: CPU 0 finished func remote_function+0x0/0x78
<...>-63 [000] d..1. 21.084243: generic_exec_single: Finished csd_lock_record(NULL)
~ #
So the last message is right before the local_irq_restore() in
generic_exec_single().
static int generic_exec_single(int cpu, call_single_data_t *csd)
{
...
csd_lock_record(csd);
csd_unlock(csd);
local_irq_save(flags);
csd_do_func(func, info, NULL);
csd_lock_record(NULL);
trace_printk("Finished csd_lock_record(NULL)\n"); <-
local_irq_restore(flags);
return 0;
Actually, I added another trace_printk() right after generic_exec_single().
err = generic_exec_single(cpu, csd);
trace_printk("generic_exec_single returned %d for CPU %d, func: %pS\n",
err, cpu, func);
This means after setting the hw_breakpoint, when enabing the IRQ,
the machine is frozen - but qemu is running busy.
Can we specify the kernel memory address to HW breakpoint on arm64?
Thank you,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-10-28 1:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 1:16 [PATCH v5 0/8] tracing: wprobe: Add wprobe for watchpoint Masami Hiramatsu (Google)
2025-09-23 1:16 ` [PATCH v5 1/8] tracing: wprobe: Add watchpoint probe event based on hardware breakpoint Masami Hiramatsu (Google)
2025-10-01 0:30 ` Masami Hiramatsu
2025-09-23 1:17 ` [PATCH v5 2/8] x86/hw_breakpoint: Unify breakpoint install/uninstall Masami Hiramatsu (Google)
2025-09-23 1:17 ` [PATCH v5 3/8] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint Masami Hiramatsu (Google)
2025-09-23 1:17 ` [PATCH v5 4/8] HWBP: Add modify_wide_hw_breakpoint_local() API Masami Hiramatsu (Google)
2025-09-23 1:17 ` [PATCH v5 5/8] tracing: wprobe: Add wprobe event trigger Masami Hiramatsu (Google)
2025-09-23 1:17 ` [PATCH v5 6/8] selftests: tracing: Add a basic testcase for wprobe Masami Hiramatsu (Google)
2025-10-24 21:31 ` Mark Brown
2025-10-27 2:29 ` Masami Hiramatsu
2025-10-27 13:43 ` Masami Hiramatsu
2025-10-27 23:42 ` Masami Hiramatsu
2025-10-28 1:55 ` Masami Hiramatsu [this message]
2025-10-28 15:42 ` Masami Hiramatsu
2025-10-29 2:43 ` Masami Hiramatsu
2025-10-29 8:20 ` Masami Hiramatsu
2025-10-30 0:09 ` Masami Hiramatsu
2025-09-23 1:17 ` [PATCH v5 7/8] selftests: tracing: Add syntax " Masami Hiramatsu (Google)
2025-09-23 1:18 ` [PATCH v5 8/8] selftests: ftrace: Add wprobe trigger testcase Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028105549.ae94e8eeb42f4efc183d2807@kernel.org \
--to=mhiramat@kernel.org \
--cc=Aishwarya.TCV@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wangjinchao600@gmail.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).