From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] tracing: Add an option to show symbols in _text+offset for function profiler
Date: Fri, 31 Oct 2025 08:27:36 -0400 [thread overview]
Message-ID: <20251031082736.1a2c4660@gandalf.local.home> (raw)
In-Reply-To: <20251031102947.c2cc7f437db1399c7ebc1863@kernel.org>
On Fri, 31 Oct 2025 10:29:47 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > +static inline int probe_print_ip_sym(struct trace_seq *s, unsigned long ip,
> > + int flags)
> > +{
> > + retun seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET);
> > +}
> >
> > And use that instead.
>
> Shouldn't we make it trace-wide function ?
Sure.
-- Steve
next prev parent reply other threads:[~2025-10-31 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 3:30 [PATCH v6 0/2] tracing: Add an option to show symbols in _text+offset for function profiler Masami Hiramatsu (Google)
2025-10-30 3:30 ` [PATCH v6 1/2] tracing: Allow tracer to add more than 32 options Masami Hiramatsu (Google)
2025-10-30 3:30 ` [PATCH v6 2/2] tracing: Add an option to show symbols in _text+offset for function profiler Masami Hiramatsu (Google)
2025-10-30 9:25 ` [PATCH v6 0/2] " Steven Rostedt
2025-10-31 1:29 ` Masami Hiramatsu
2025-10-31 12:27 ` Steven Rostedt [this message]
2025-10-31 2:13 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031082736.1a2c4660@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).